Reviewers: rchandia,

Description:
Remove a couple of JDK 1.6-isms


Please review this at http://gwt-code-reviews.appspot.com/1178801/show

Affected files:
  M dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java
  M user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java


Index: dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java
===================================================================
--- dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java (revision 9337) +++ dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java (working copy)
@@ -657,7 +657,7 @@
   private List<JClassType> classChain(JClassType cls) {
     LinkedList<JClassType> chain = new LinkedList<JClassType>();
     while (cls != null) {
-      chain.push(cls);
+      chain.addFirst(cls);
       cls = cls.getSuperclass();
     }
     return chain;
Index: user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java
===================================================================
--- user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java (revision 9337)
+++ user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java   (working copy)
@@ -396,7 +396,7 @@
     String rpcTokenImplementation = "";
     for (JClassType rpcTokenSubtype : rpcTokenSubtypes) {
       if (typesSentFromBrowser.isSerializable(rpcTokenSubtype)) {
-        if (!rpcTokenImplementation.isEmpty()) {
+        if (rpcTokenImplementation.length() > 0) {
           // >1 implematation of RpcToken, bail
           rpcTokenImplementation = "";
           break;
@@ -405,7 +405,7 @@
         }
       }
     }
-    if (!rpcTokenImplementation.isEmpty()) {
+    if (rpcTokenImplementation.length() > 0) {
       srcWriter.println("@Override");
srcWriter.println("protected void checkRpcTokenType(RpcToken token) {");
       srcWriter.indent();


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to