[gwt-contrib] TBR

2010-01-15 Thread Ray Ryan
http://code.google.com/p/google-web-toolkit/source/detail?r=7420 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] TBR: float -> cssFloat in TabLayoutPanel

2009-12-01 Thread Joel Webber
http://code.google.com/p/google-web-toolkit/source/detail?r=7228 This was a mistake on my part. Some browsers (e.g., Firefox) won't accept elem.style['float'], but rather require elem.style['cssFloat']. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] TBR: fix xhtml.net url in TopPanel.ui.xml

2009-11-17 Thread Ray Ryan
Joel, submitted this TBR you http://code.google.com/p/google-web-toolkit/source/detail?r=6977 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] TBR: r6883 [EOM]

2009-11-12 Thread Joel Webber
-- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] TBR: r6636

2009-11-04 Thread Joel Webber
Fixes checkstyle errors in LayoutCommand: http://code.google.com/p/google-web-toolkit/source/detail?r=6635 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] TBR requested

2009-11-03 Thread Ray Ryan
http://code.google.com/p/google-web-toolkit/source/detail?r=6631 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] TBR requested

2009-11-02 Thread Ray Ryan
Joel, I submitted http://code.google.com/p/google-web-toolkit/source/detail?r=6596 TBR you --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] TBR: hook up some tests that weren't running

2009-10-29 Thread Ray Ryan
Dan, I submitted this TBR you: http://code.google.com/p/google-web-toolkit/source/detail?r=6555 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] TBR requested

2009-10-29 Thread Ray Ryan
Hey, Bruce. I TBR'd you on these: http://code.google.com/p/google-web-toolkit/source/detail?r=6550 http://code.google.com/p/google-web-toolkit/source/detail?r=6552 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~--

[gwt-contrib] TBR request on tweak to HTMLPanelTest

2009-09-14 Thread Ray Ryan
Joel, I tbr'd this to you. Can you take a look? http://code.google.com/p/google-web-toolkit/source/detail?r=6141 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] TBR: checkstyle fix for Layout patch

2009-08-04 Thread Ray Ryan
http://code.google.com/p/google-web-toolkit/source/detail?r=5878 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] TBR: r5696 (deprecating HistoryImpl.setUpdateHashOnIE6())

2009-07-09 Thread Joel Webber
http://code.google.com/p/google-web-toolkit/source/detail?r=5696 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] TBR: r5635 [EOM]

2009-06-26 Thread Joel Webber
--~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] TBR: r4576

2009-01-28 Thread Joel Webber
One more fix to un-break the 1.6 build. Mind reviewing to make sure I'm not crazy? --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] TBR: releases/1.6 r4569

2009-01-28 Thread Joel Webber
Ray, I need you to review the change I just committed to the 1.6 release branch as r4569 (I went ahead and committed it to get the build back on track). It turns out that old Firefoxen have a few quirks related to event dispatching that I failed to notice. Details: http://code.google.com/p/google-

[gwt-contrib] TBR Incubator review for HasHandlers breakage

2009-01-21 Thread Ray Ryan
Fix submitted TBR emily at incubator r1432. Fixes breakage due to HasHandlers change from gwt r4494 rjrjr --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] TBR Code review on DatePicker branch, more clean up

2008-12-02 Thread Ray Ryan
http://code.google.com/p/google-web-toolkit/source/detail?r=4239 Addresses some of the remaining issues from http://groups.google.com/group/Google-Web-Toolkit- Contributors/browse_thread/thread/486babc9bb0863a9 In particular, nukes the unused Iterator class from ElementMapper, fixes a bug in Dat

[gwt-contrib] TBR review needed on r4235 (date picker branch)

2008-12-02 Thread Ray Ryan
Tweaks in response to review of r4188. Use Labels instead of TextBoxes in examples, and explain use of VerticalPanel in DatePicker. http://code.google.com/p/google-web-toolkit/source/detail?r=4235 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Tool

[gwt-contrib] TBR needed on r4214

2008-12-01 Thread Ray Ryan
When you have a moment: http://code.google.com/p/google-web-toolkit/source/detail?r=4214 beef up TODO per jlabanca's review of r4165. TBR jlabanca rjrjr --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~---

[gwt-contrib] TBR Code review: update 1.6 branch-info.txt

2008-11-20 Thread Ray Ryan
John, I just put this in TBR you. rjrjr -- Forwarded message -- From: <[EMAIL PROTECTED]> Date: Thu, Nov 13, 2008 at 8:15 PM Subject: [gwt-contrib] [google-web-toolkit commit] r4071 - branches/1_6_clean_events To: [EMAIL PROTECTED] Author: [EMAIL PROTECTED] Date: Thu Nov 13 17:1