Re: [gphoto-devel] CHDK live view

2018-03-24 Thread Marcus Meissner
On Sat, Mar 24, 2018 at 01:32:03AM +0300, Alexey Kryukov wrote: > On Fri, 23 Mar 2018 20:39:19 +0100 > Marcus Meissner wrote: > > > + header->version_major = dtoh32a(&data[off]); > > + header->version_minor = dtoh32a(&data[off+=4]); > > > > Here data[off] is used twice. > > Hmm. I see nothin

Re: [gphoto-devel] CHDK live view

2018-03-23 Thread Alexey Kryukov
On Fri, 23 Mar 2018 20:39:19 +0100 Marcus Meissner wrote: > + header->version_major = dtoh32a(&data[off]); > + header->version_minor = dtoh32a(&data[off+=4]); > > Here data[off] is used twice. Hmm. I see nothing wrong with this, as 0+=4 should return 4. At least it works this way for me:

Re: [gphoto-devel] CHDK live view

2018-03-23 Thread Marcus Meissner
On Fri, Mar 23, 2018 at 01:38:49PM +0300, Alexey Kryukov wrote: > Hi, > > I've noticed there is currently no capture-preview support for CHDK, > although some stubs are present in the code. Of course, remote capture > without live view isn't that useful. So here's a patch, which also > updates chd

[gphoto-devel] CHDK live view

2018-03-23 Thread Alexey Kryukov
Hi, I've noticed there is currently no capture-preview support for CHDK, although some stubs are present in the code. Of course, remote capture without live view isn't that useful. So here's a patch, which also updates chdk_live_view.h to the recent version. It supports either jpeg (needs libjpeg)