Looks good.
Stefan
2010/7/8 Piotr Jaroszyński :
> image_set_cmdline() strdup()s cmdline, which free_image() doesn't clean
> up.
>
> Signed-off-by: Piotr Jaroszyński
> ---
>
> Another thing found by valgrind.
>
> src/core/image.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> d
I was going to queue up a few more but fixing embedded images is
important. Will merge tomorrow unless anyone has objections.
The following changes since commit 7d9c4049ce94bd3db601ed9c5f68b99341ccfd62:
[romprefix] Do not check for BBS compatibility (2010-07-07 20:22:19 +0100)
are available i
On Fri, Jul 9, 2010 at 2:15 AM, Marty Connor wrote:
> Ah, ok, thanks Alessandro. That fix should be committed soon.
I have it queued for the next ipxe-sync:
http://git.etherboot.org/?p=people/stefanha/gpxe.git;a=shortlog;h=refs/heads/ipxe-sync
Stefan
> / Marty /
>
> Alessandro Salvatori wrote
On Sat, Jul 3, 2010 at 10:07 PM, Stefan Hajnoczi wrote:
> On Sat, Jul 3, 2010 at 9:52 PM, Stefan Hajnoczi wrote:
>> This patch adds a native gPXE virtio-net driver and removes the legacy
>> Etherboot virtio-net driver. The main reasons for doing this are:
>>
>> 1. Multiple virtio-net NICs are no
Thanks for resending it!
Stefan
On Fri, Jul 9, 2010 at 6:20 AM, Glenn Brown wrote:
>> Did patch 1/1 tag_type make it to the mailing list? I don't seem to have
>> it.
>
> I received a copy via CC, and sent the patch set with 'git send-email' so I
> don't think the loss was sender error, for what
Did patch 1/1 tag_type make it to the mailing list? I don't seem to have it.
I received a copy via CC, and sent the patch set with 'git send-email'
so I don't think the loss was sender error, for what it's worth.
Anyway, I've included the patch below, inline, and also attached a copy
in case
Ah, ok, thanks Alessandro. That fix should be committed soon.
/ Marty /
Alessandro Salvatori wrote on 7/8/10 8:51 PM:
> I already submitted a fix to iPXE for that some time back...
>
> http://git.ipxe.org/ipxe.git/commitdiff/3cefc5a
>
> -Alessandro-
>
> On Thu, Jul 8, 2010 at 17:43, Marty Connor
I already submitted a fix to iPXE for that some time back...
http://git.ipxe.org/ipxe.git/commitdiff/3cefc5a
-Alessandro-
On Thu, Jul 8, 2010 at 17:43, Marty Connor wrote:
> A user reported that rom-o-matic.net was failing when an embedded image
> was added to r8169.usb.
>
> I did a manual bui
A user reported that rom-o-matic.net was failing when an embedded image was
added to r8169.usb.
I did a manual build and got this result:
[...@rom src]$ cat > bar
#!gpxe
autoboot
[...@rom src]$ make bin/r8169.usb EMBEDDED_IMAGE=bar
[BUILD] bin/embedded.o
image/embedded.c:40: error: u
Did patch 1/1 tag_type make it to the mailing list? I don't seem to have it.
Thanks,
Stefan
On 7 Jul 2010 00:20, "Glenn Brown" wrote:
> The following patch set adds user-friendly features to the settings
> user interface, transforming the "config" command into a settings
> browser capable of nav
<>___
gPXE-devel mailing list
gPXE-devel@etherboot.org
http://etherboot.org/mailman/listinfo/gpxe-devel
On Thursday 08 Jul 2010 15:45:50 Marty Connor wrote:
> >> Quoting numbers like 60% is poor form.
> >
> > You are welcome to keep it at 0%. I have no particular interest in
> > having my code backported into the gPXE tree.
>
> But you seem just fine with using the 40% (by your calculations) of wor
Michael Brown wrote on 7/8/10 4:56 AM:
> On Thursday 08 Jul 2010 00:09:17 Marty Connor wrote:
>> Quoting numbers like 60% is poor form.
>
> You are welcome to keep it at 0%. I have no particular interest in having my
> code backported into the gPXE tree.
But you seem just fine with using the 40%
image_set_cmdline() strdup()s cmdline, which free_image() doesn't clean
up.
Signed-off-by: Piotr Jaroszyński
---
Another thing found by valgrind.
src/core/image.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/core/image.c b/src/core/image.c
index e29d4cc..d7fed72
On Wed, 2010-07-07 at 22:12 +0100, Michael Brown wrote:
> I concur that a global setting should override netdev-specific settings here.
>
> I think that clearing just netX/filename and netX/root-path is maybe too
> specific; would it be cleaner to clear netX.dhcp (and proxydhcp etc) at the
> e
On Thursday 08 Jul 2010 00:09:17 Marty Connor wrote:
> Quoting numbers like 60% is poor form.
You are welcome to keep it at 0%. I have no particular interest in having my
code backported into the gPXE tree.
> You clearly have committed lots
> of useful code, but there is a lot more to FOSS than
16 matches
Mail list logo
