Re: [gPXE-devel] [PATCH] [compiler] Mark weak functions noinline

2010-07-17 Thread Stefan Hajnoczi
On Wed, Jul 14, 2010 at 10:13 AM, Stefan Hajnoczi wrote: > Weak functions whose visibility is hidden may be inlined due to a bug in > GCC.  Explicitly mark weak functions noinline to work around the > problem. > > This makes the PXE_MENU config option work again, the PXE boot menu was > never bein

Re: [gPXE-devel] [PATCH] [compiler] Mark weak functions noinline

2010-07-14 Thread Joshua Oreman
On Wed, Jul 14, 2010 at 2:13 AM, Stefan Hajnoczi wrote: > Weak functions whose visibility is hidden may be inlined due to a bug in > GCC.  Explicitly mark weak functions noinline to work around the > problem. ACK. Thanks for putting this together. -- Josh > This makes the PXE_MENU config option

[gPXE-devel] [PATCH] [compiler] Mark weak functions noinline

2010-07-14 Thread Stefan Hajnoczi
Weak functions whose visibility is hidden may be inlined due to a bug in GCC. Explicitly mark weak functions noinline to work around the problem. This makes the PXE_MENU config option work again, the PXE boot menu was never being called because the compiler inlined a weak stub function. The GCC