Hi Laurent,
I take it the comments are copied from StrictMath and so the code may
not always follow their guidelines (if you set CHECK_NAN to false for
instance).
I notice that CHECK_NAN is false, but you get the right result below.
Do you also get the right result for the Floor function?
Hi Laurent,
I still have no idea what you mean when you say "arrays = [0]".
Does that mean "new foo[0]"? Or "new foo[getBucketSize of bucket #0]"?
The latter is what I was envisioning using...
...jim
On 6/19/15 5:08 AM, Laurent Bourgès wrote:
Jim,
here are the bench
On 6/19/15 12:24 AM, Laurent Bourgès wrote:
As you wonder if initial arrays are still necessary, I will run tonight
some benchmarks with initial arrays = [0].
"arrays = [0]" - is that arrays set to bucket 0 sizes? That would be my guess
as to how to proceed.
Exactly: I changed MarlinCons
Jim,
Here is a new webrev to improve FloatMath:
http://cr.openjdk.java.net/~lbourges/marlin/marlin-s3.0/
I tested it with following float values:
floats = [-2.13422758E9, -1.37992608E8, -134758.4, -131.5, -17.2,
-1.9, -0.9, -1.0E-4, -1.0E-8, -1.0E-23, -100.0, -3.0, -1.0, -0.0, 0.0, 0.0,
1.0
Changeset: 4a6f98026ca6
Author:lbourges
Date: 2015-06-19 22:15 +0200
URL:
http://hg.openjdk.java.net/graphics-rasterizer/jdk9/jdk/rev/4a6f98026ca6
Marlin renderer #2
Summary: Second marlin patch
Reviewed-by: flar
Contributed-by: bourges.laur...@gmail.com
! src/java.desktop/share/c
Jim,
here are the benchmark results:
- REF: Marlin reference = initial capacity tuned for arrays and
OffHeapEdgeArray
- NO_INITIAL: initial arrays = [0]
- NO_INITIALS_OFFHEAP_16: initial arrays = [0] and OffHeapEdgeArray(16)
I pushed all details (stats & benchmarks):
http://cr.openjdk.java.net/~l
Hi Jim,
>> I will now try being more opened minded to your valuable comments to
>> improve code maintainability without sacrifying too much the performance
>> level.
>
> It's a philosophy, not a hard requirement. And it is more important in a
large project, especially Open Source where you get ne
