[bug #61089] [troff] assertion failed: 'desired_space.is_zero() && nspaces == 0'

2021-09-02 Thread Dave
Follow-up Comment #10, bug #61089 (project groff): [comment #8 comment #8:] > Reverting this one change definitely restores groff 1.22.4 > behavior for John's ono.tmac... That is some kind of voodoo. There should be only two possibilities: 0 output_width > 0: in this case, the new "if" is

[bug #61089] [troff] assertion failed: 'desired_space.is_zero() && nspaces == 0'

2021-09-02 Thread John Gardner
Follow-up Comment #9, bug #61089 (project groff): > John, is this enough information for you to put together a (much) smaller reproducer? Aye, I narrowed it down to the following test-case: 01 .de _ 02 .na 03 .nh 04 .ll 0 05 .di A 06 \&\\$1 07 .di 08 .br 09 .. 10 ._ "

Groff examples on gopher

2021-09-02 Thread Thomas Dupond
Hello everyone, No one asked for it, no one will use it, but now the repository is available on gopher as well at gopher://froude.eu/1/groff . If you find any mistakes in this gopher hole, please tell me, my formatting script is terrible so there should be some mistakes. Regards, Thomas

[bug #44714] compatibility mode: .do request and macro expansion via \* collide

2021-09-02 Thread G. Branden Robinson
Follow-up Comment #1, bug #44714 (project groff): [comment #0 original submission:] > Consider the following snippet. > > > .de1 aa > . tm compatibility mode = '\\n(.C' > .. > . > .cp 1 > . > .do tm > \*(aa\ > > > The expected output is > > > compatibility mode = '0' > > > since macro

[bug #61100] [troff] do_request(): assertion failed: 'do_old_compatible_flag == -1'

2021-09-02 Thread G. Branden Robinson
Follow-up Comment #4, bug #61100 (project groff): [comment #2 comment #2:] > [comment #1 comment #1:] > > In ".do while ...", the "do" is valid for the whole loop. > > Is this documented? I don't find mention of it in the Texinfo manual. Some language I just pushed, but had been working on

[bug #61089] [troff] assertion failed: 'desired_space.is_zero() && nspaces == 0'

2021-09-02 Thread G. Branden Robinson
Follow-up Comment #7, bug #61089 (project groff): Getting to John's actual code, the problem appears to be the emission of an empty line while inside a diversion, but only sometimes. The trouble occurs in a string-downcasing macro (which uses the new groff .stringdown request if it is

[bug #61089] [troff] assertion failed: 'desired_space.is_zero() && nspaces == 0'

2021-09-02 Thread G. Branden Robinson
Follow-up Comment #8, bug #61089 (project groff): Returning to the groff side of things, and why my infinite-loop-fixing commit caused this problem, here is the code change in question. (There were no other changes in that commit except to the ChangeLog and to add editor aid comments to

Re: [PATCH] [mdoc] .At: produce "Version 7 AT UNIX/32V"

2021-09-02 Thread наб
Hi! On Thu, Sep 02, 2021 at 02:32:53PM +0200, Ingo Schwarze wrote: > the patch is incorrect as posted: \*[doc-str-At] resets the font, > so "/32V" needs to be inserted before it, see below for a corrected > version. Hm, the other .At macros only .Tnise "AT" and "UNIX", SysIII is "Tn(AT) No(System

Re: [PATCH] [mdoc] .At: produce "Version 7 AT UNIX/32V"

2021-09-02 Thread Ingo Schwarze
Hello, the patch is incorrect as posted: \*[doc-str-At] resets the font, so "/32V" needs to be inserted before it, see below for a corrected version. OK schwarze@ if someone wants to push the patch, or i can push it if another developer tells me too. I think backward compatibility is not a

[bug #61089] [troff] assertion failed: 'desired_space.is_zero() && nspaces == 0'

2021-09-02 Thread G. Branden Robinson
Follow-up Comment #6, bug #61089 (project groff): [comment #4 comment #4:] > [comment #3 comment #3:] > > There are reasons to believe it isn't the culprit though: > > I'd add (3) the newly introduced code path emits a warning, so we can tell if the code is following commit bcdf2f4c

[bug #61075] TODO: item `check' target

2021-09-02 Thread G. Branden Robinson
Update of bug #61075 (project groff): Status: In Progress => Fixed Open/Closed:Open => Closed Planned Release:None => 1.23.0

[groff] 25/34: [libgroff]: Boolify `font::load_desc()` retval.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit f629fa4b5f4edceca84b74efb6b9d8117470ac90 Author: G. Branden Robinson AuthorDate: Sat Aug 28 18:56:36 2021 +1000 [libgroff]: Boolify `font::load_desc()` retval. * src/include/font.h (font::load_desc): *

[groff] 22/34: Un-indirect token concatenation via macro.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit 4153e4da24f088b29da5e801042cb0a5164a1156 Author: G. Branden Robinson AuthorDate: Sat Aug 28 10:33:48 2021 +1000 Un-indirect token concatenation via macro. * src/include/itable.h: * src/include/ptable.h: Do

[groff] 27/34: [libgroff]: Fix code style nit.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit 3c4df711a19ed439e230c845dd30ac6a96f7c292 Author: G. Branden Robinson AuthorDate: Sun Aug 29 00:30:00 2021 +1000 [libgroff]: Fix code style nit. * src/libs/libgroff/errarg.cpp (errprint): Replace `assert(0)` with

[groff] 17/34: Drop support for `ARRAY_DELETE_NEEDS_SIZE`.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit bda851ae93e1979514b547e0e83992092719ab64 Author: G. Branden Robinson AuthorDate: Sat Aug 28 09:45:16 2021 +1000 Drop support for `ARRAY_DELETE_NEEDS_SIZE`. * src/include/lib.h [ARRAY_DELETE_NEEDS_SIZE]: Drop

[groff] 11/34: [tests]: Apply naming convention.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit de84807538bbc4db255320bab9867330affc5432 Author: G. Branden Robinson AuthorDate: Mon Aug 23 23:59:07 2021 +1000 [tests]: Apply naming convention. * tmac/tests/e_footnotes_work_with_columns.sh: Rename from...

[groff] 10/34: groff(1): Fix style and organizational nits.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit 34580bf391068839c9f7e4d79a46e0ae7964c4b4 Author: G. Branden Robinson AuthorDate: Mon Aug 23 23:51:25 2021 +1000 groff(1): Fix style and organizational nits. Combine "Notes" and "Bugs" sections into a

[groff] 07/34: doc/groff.texi: Fix erroneous Texinfo command.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit 3afc7f8826c59e9172a9b7405b3204969e19a23a Author: G. Branden Robinson AuthorDate: Mon Aug 23 19:41:19 2021 +1000 doc/groff.texi: Fix erroneous Texinfo command. Use @xref instead of @ref. --- doc/groff.texi | 17

[groff] 33/34: doc/groff.texi (Text): Fix error in macro intro.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit 876a23016e5893ff0d9bd7fe8c844b9347735af5 Author: G. Branden Robinson AuthorDate: Mon Aug 30 00:11:32 2021 +1000 doc/groff.texi (Text): Fix error in macro intro. End macros need only be defined by the time they're

[groff] 32/34: doc/groff.texi: Fix style, content, grammar nits.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit 54e30b6d78e6dfd0f554756654f9910e4f23fce8 Author: G. Branden Robinson AuthorDate: Mon Aug 30 00:04:23 2021 +1000 doc/groff.texi: Fix style, content, grammar nits. * Add another motivation for \E usage in strings:

[groff] 34/34: [docs]: Clarify material on writing macros.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit 6ada943af7134202521454d0ca98b83b489d0e87 Author: G. Branden Robinson AuthorDate: Thu Sep 2 16:13:50 2021 +1000 [docs]: Clarify material on writing macros. Recast and add material for further precision and

[groff] 31/34: [docs]: Update italic correction discussion.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit 97419a4d8c89b20e883e64f050a03b9ae748a2e7 Author: G. Branden Robinson AuthorDate: Sun Aug 29 21:03:19 2021 +1000 [docs]: Update italic correction discussion. I think I figured out why some people disfavor the term

[groff] 30/34: groff_man_style(7): Fix unescaped hyphen.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit fadb0d17be373a04ffa742fc29c925afb3e41c3d Author: G. Branden Robinson AuthorDate: Sun Aug 29 20:45:50 2021 +1000 groff_man_style(7): Fix unescaped hyphen. ...in discussion of unescaped hyphen. :ironicface: ---

[groff] 26/34: [libgroff]: Demote `need_space` to Boolean.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit d617afdc974f92973f39ea7349dcfb565c8ac13f Author: G. Branden Robinson AuthorDate: Sat Aug 28 20:43:31 2021 +1000 [libgroff]: Demote `need_space` to Boolean. * src/libs/libgroff/error.cpp

[groff] 24/34: [libgroff]: Boolify `font::load()` return value.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit cd0ecd22c1297361fa9e68d58ab3356626b5cf45 Author: G. Branden Robinson AuthorDate: Sat Aug 28 18:45:03 2021 +1000 [libgroff]: Boolify `font::load()` return value. * src/include/font.h (font::load): *

[groff] 23/34: m4/groff.m4: Fail if cpp is pre-C89.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit ff103f9da5f704c1b780aed186033d9492955f56 Author: G. Branden Robinson AuthorDate: Sat Aug 28 11:34:20 2021 +1000 m4/groff.m4: Fail if cpp is pre-C89. * m4/groff.m4 (TRADITIONAL_CPP): Update `AC_MSG_CHECKING`

[groff] 19/34: [libgroff]: Drop `ad_delete` preprocessor wrapper.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit f078d60b9e76817e4c36ce4788010bb0bfc195ed Author: G. Branden Robinson AuthorDate: Fri Aug 27 18:13:32 2021 +1000 [libgroff]: Drop `ad_delete` preprocessor wrapper. ...for the `delete` operator. It has been

[groff] 21/34: [libgroff]: Drop support for `TRADITIONAL_CPP`.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit cc2bea41accd62e0e2abb81a66d0fbe1faa26745 Author: G. Branden Robinson AuthorDate: Sat Aug 28 10:19:20 2021 +1000 [libgroff]: Drop support for `TRADITIONAL_CPP`. This means a C preprocessor that does not support

[groff] 18/34: m4/groff.m4 (GROFF_ARRAY_DELETE): Lethalize check.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit 9f00373ec3747e5e2f30c662153d6a4dfb9e437f Author: G. Branden Robinson AuthorDate: Sat Aug 28 10:03:46 2021 +1000 m4/groff.m4 (GROFF_ARRAY_DELETE): Lethalize check. * m4/groff.m4 (GROFF_ARRAY_DELETE): Update

[groff] 16/34: [libgroff]: Drop redefinition of `INT_MIN`.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit 153d49d940bf9632fe8039107b66625d44aa93fb Author: G. Branden Robinson AuthorDate: Fri Aug 27 12:12:18 2021 +1000 [libgroff]: Drop redefinition of `INT_MIN`. * src/include/lib.h: Drop redefinition of `INT_MIN`. It

[groff] 12/34: [ms]: Exercise terminological discipline in docs.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit 2e81da5aa6f8414fa0f7568a89899976348f9aef Author: G. Branden Robinson AuthorDate: Tue Aug 24 12:22:28 2021 +1000 [ms]: Exercise terminological discipline in docs. * "using" macros -> "calling" macros * "use"

[groff] 29/34: groff_diff(7): Fix nits in \V description.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit 301ab81e3dd3cfb9d2a1b827c0878dfec2c23eec Author: G. Branden Robinson AuthorDate: Sun Aug 29 20:43:40 2021 +1000 groff_diff(7): Fix nits in \V description. Content: * Say "interpreted _even_ in copy mode".

[groff] 13/34: TODO: Drop "make check" item.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit 3398d2641915b879e8ec6d621d47ab68f35ba484 Author: G. Branden Robinson AuthorDate: Tue Aug 24 12:27:36 2021 +1000 TODO: Drop "make check" item. Implemented by Bertrand at least as far back as commit aee96c8625, 6

[groff] 14/34: [libgroff]: Refactor `font::scan_papersize()`.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit 8b2e692af9493d7201667485ef7ee2632cdafa5c Author: G. Branden Robinson AuthorDate: Tue Aug 24 22:07:40 2021 +1000 [libgroff]: Refactor `font::scan_papersize()`. * src/libs/libgroff/font.cpp (font::scan_papersize):

[groff] 28/34: [troff]: Tweak diagnostic message.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit 86457dc5251dbb3e5cfa4c9630226881707dc716 Author: G. Branden Robinson AuthorDate: Sun Aug 29 00:34:07 2021 +1000 [troff]: Tweak diagnostic message. * src/roff/troff/env.cpp (environment::environment): Use

[groff] 08/34: groff_man_style(7): Tighten wording.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit 36b40c536f5084e44f390f3924bd85fbcb274dab Author: G. Branden Robinson AuthorDate: Mon Aug 23 19:48:16 2021 +1000 groff_man_style(7): Tighten wording. --- tmac/groff_man.7.man.in | 10 -- 1 file changed, 4

[groff] 09/34: troff(1): Tighten description of `-i` option.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit 0461bd12fbf5a546c1344cea4e51fde98165d050 Author: G. Branden Robinson AuthorDate: Mon Aug 23 23:39:49 2021 +1000 troff(1): Tighten description of `-i` option. --- src/roff/troff/troff.1.man | 2 +- 1 file changed, 1

[groff] 04/34: tmac/an.tmac: Make code more accessible.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit 5e99268a22a1abd2595a63bef4ecc4dbe0164954 Author: G. Branden Robinson AuthorDate: Mon Aug 23 16:58:31 2021 +1000 tmac/an.tmac: Make code more accessible. * tmac/an.tmac (IP): Make code more accessible by using a

[groff] 02/34: doc/groff.texi: Recast `.backtrace` description.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit d78ed35dd6054a7e9fc203ac1e8c811c7a309f14 Author: G. Branden Robinson AuthorDate: Mon Aug 23 15:26:17 2021 +1000 doc/groff.texi: Recast `.backtrace` description. --- doc/groff.texi | 24 +--- 1 file

[groff] 05/34: src/utils/grog/grog.pl: Tweak comments.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit 9a0bb9be3d780b421bb96ed2c0a999cd3cce811a Author: G. Branden Robinson AuthorDate: Mon Aug 23 17:03:40 2021 +1000 src/utils/grog/grog.pl: Tweak comments. --- src/utils/grog/grog.pl | 4 ++-- 1 file changed, 2

[groff] 03/34: [docs]: Tighten discussion of warning categories.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit f73b8ec0a2cf2a2ff4e626e635a5fdc38a8fa927 Author: G. Branden Robinson AuthorDate: Mon Aug 23 15:27:32 2021 +1000 [docs]: Tighten discussion of warning categories. * `escape`: Drop sentence already covered in our

[groff] 15/34: [libgroff]: Drop long-dead `COOKIE_BUG` logic.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit 4f319f4db376aea27c98f0d1011cf2d548b3dd65 Author: G. Branden Robinson AuthorDate: Fri Aug 27 11:21:00 2021 +1000 [libgroff]: Drop long-dead `COOKIE_BUG` logic. * src/libs/libgroff/new.cpp (operator new, operator

[groff] 01/34: groff_diff(7): Delete spurious comma.

2021-09-02 Thread G. Branden Robinson
gbranden pushed a commit to branch master in repository groff. commit b2d793c10b85b6966a0994f6aecca0c0b46e476c Author: G. Branden Robinson AuthorDate: Mon Aug 23 15:22:27 2021 +1000 groff_diff(7): Delete spurious comma. --- man/groff_diff.7.man | 3 +-- 1 file changed, 1 insertion(+), 2