Re: Bug#421437: groff: grops and grodvi crash on invalid input

2020-11-30 Thread G. Branden Robinson
At 2020-11-22T18:00:29+, brian m. carlson wrote: > On 2020-11-22 at 13:10:15, John Gardner wrote: > > That's assuming he didn't patch devps/DESC locally with an arbitrary > > ` sizescale` or `unitwidth` parameter (which may have been an > > attempt to make coordinates easier to visualise). But

Re: groff: grops and grodvi crash on invalid input

2020-11-23 Thread Dave Kemper
(This no longer has anything to do with Debian bug #421437, so I took it off the cc.) On 11/22/20, John Gardner wrote: >> What do you think about a warning for drawing outside the page >> boundaries? > > I can't see that benefiting anybody, quite frankly. Since all coordinates > are precomputed,

Re: groff: grops and grodvi crash on invalid input

2020-11-22 Thread John Gardner
> > What do you think about a warning for drawing outside the page boundaries? I can't see that benefiting anybody, quite frankly. Since all coordinates are precomputed, users are unlikely to see such a message in practice. Personally, I find Groff's postprocessors too chatty, and would really a

Re: Bug#421437: groff: grops and grodvi crash on invalid input

2020-11-22 Thread brian m. carlson
On 2020-11-22 at 13:10:15, John Gardner wrote: > > > > He declared a groff-compatible ps device resolution of 72000 but didn't > > scale his arguments. > > > That's assuming he didn't patch devps/DESC locally with an arbitrary ` > sizescale` or `unitwidth` parameter (which may have been an attemp

Re: groff: grops and grodvi crash on invalid input

2020-11-22 Thread G. Branden Robinson
At 2020-11-23T00:10:15+1100, John Gardner wrote: > IMHO, it would be more intuitive to make this [a positioning command before the first 'p' command] > a no-op, rather than an error (a warning at *most*). Users may wish to > "prepostprocess" the formatted output to control page order, extract > or

Re: groff: grops and grodvi crash on invalid input

2020-11-22 Thread John Gardner
> > He declared a groff-compatible ps device resolution of 72000 but didn't > scale his arguments. That's assuming he didn't patch devps/DESC locally with an arbitrary ` sizescale` or `unitwidth` parameter (which may have been an attempt to make coordinates easier to visualise). But your point st

Re: groff: grops and grodvi crash on invalid input

2020-11-22 Thread G. Branden Robinson
At 2020-11-22T23:15:46+1100, G. Branden Robinson wrote: > I'm attaching his version of the grops crasher, my reduced and > corrected version, and a diff between them. Why do I say these things when I know I'll forget to do it? Trying again. Regards, Branden x Typesetter ps x resolution 72000 1 1

Re: groff: grops and grodvi crash on invalid input

2020-11-22 Thread G. Branden Robinson
At 2020-11-22T13:42:22+1100, John Gardner wrote: > > > > In the meantime, John Gardner, who's written his own "ditroff" > > interpreter in JavaScript, might be able to offer some useful insights > > on the well-formedness of your sample documents. > > Sorry, I completely missed this. No worries.

Re: groff: grops and grodvi crash on invalid input

2020-11-22 Thread G. Branden Robinson
package groff-base tag 421437 + upstream fixed-upstream thanks I can verify that, as I suspected (I mention that only because my suspicions are so often incorrect), both instances arose from the same bug, fixed in groff upstream last year and expected in the 1.23.0 release. Details: $ grodvi ./c

Re: groff: grops and grodvi crash on invalid input

2020-11-21 Thread John Gardner
> > In the meantime, John Gardner, who's written his own "ditroff" > interpreter in JavaScript, might be able to offer some useful insights > on the well-formedness of your sample documents. Sorry, I completely missed this. The samples look fine. Try converting their line-endings from CRLF to LF

Re: groff: grops and grodvi crash on invalid input

2020-11-18 Thread G. Branden Robinson
Hi Brian, Following up on an almost 14 year old bug report... I can't reproduce these SEGVs with groff git HEAD. I would have thought they're the same bug since the groff output drivers outsource all of their parsing to the driver library, src/libs/libdriver/input.cpp. However, there's some sug