[grpc-io] Re: gRFC L21: GPR API review

2018-01-25 Thread 'Vijay Pai' via grpc.io
I view the following as an interesting one. host_port.h provides two utility functions for name management: gpr_join_host_port and gpr_split_host_port . Both are used in several places inside core. They are also used in the core and C++ tests. So those are still fine with privatizing. However,

[grpc-io] Re: gRFC L21: GPR API review

2018-01-25 Thread 'Vijay Pai' via grpc.io
Thanks for the feedback! Yes, everything in alloc.h definitely stays since those are used in multiple language implementations. Same with time and logging -- all the language bindings use them heavily. I think our sync and atm also stay since they are certainly used in some of our language bind

[grpc-io] Re: gRFC L21: GPR API review

2018-01-25 Thread 'Christopher Warrington - MSFT' via grpc.io
> This is a proposal to curate the contents of the include/grpc/support > directory, which is the public surface of the GPR API, as many of the > entries in that API are not actually publicly needed or used. The result > will be a smaller installation and fewer API surface points. Seems reason