Re: [patch] configfile

2005-02-13 Thread Yoshinori K. Okuji
On Sunday 13 February 2005 20:41, Marco Gerards wrote: > It just seems it a bit awkward to me. I have no idea how big the > stack is on the PC and if it will cause problems. I don't know, either, but I guess it would consume less than 1KB per configfile, because large data is allocated on the he

Re: Scripting

2005-02-13 Thread Hollis Blanchard
On Feb 13, 2005, at 12:56 PM, Marco Gerards wrote: Serbinenko Vladimir <[EMAIL PROTECTED]> writes: What kind of parser is it? It's a direct parser with aritmetic subparser. Main parser is grub_bash_execute, arithmetic subparser is grub_bash_eval_arith. grub_bash_execute determinates the special cas

Re: [patch] set prefix on PPC

2005-02-13 Thread Hollis Blanchard
On Feb 13, 2005, at 12:35 PM, Marco Gerards wrote: Hollis Blanchard <[EMAIL PROTECTED]> writes: This code sets the GRUB "prefix" environment variable from the OF /chosen/bootpath property. It must therefore translate between the two syntaxes. Personally I don't like setting prefix to the path grubo

Re: Scripting

2005-02-13 Thread Serbinenko Vladimir
Marco Gerards wrote: Serbinenko Vladimir <[EMAIL PROTECTED]> writes: - Why does everything happen with strings? Because environment variables are the strings and it's not really needed to convert them (excluding the calculating) Personally I don't like it too much. I prefer keeping

Re: [patch] configfile

2005-02-13 Thread Marco Gerards
"Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes: > On Sunday 13 February 2005 18:53, Marco Gerards wrote: >> This is the main reason I have not implemented this command yet. To >> me it would seem better to update the data in the already running >> normal mode. > > Why? Are you afraid of memory e

Re: Scripting

2005-02-13 Thread Marco Gerards
Serbinenko Vladimir <[EMAIL PROTECTED]> writes: >>- Why does everything happen with strings? >> > Because environment variables are the strings and it's not really > needed to convert them (excluding the calculating) Personally I don't like it too much. I prefer keeping such information in a str

Re: [patch] configfile

2005-02-13 Thread Yoshinori K. Okuji
On Sunday 13 February 2005 18:53, Marco Gerards wrote: > This is the main reason I have not implemented this command yet. To > me it would seem better to update the data in the already running > normal mode. Why? Are you afraid of memory exhaustion? Okuji __

Re: [patch] configfile

2005-02-13 Thread Hollis Blanchard
On Feb 13, 2005, at 11:53 AM, Marco Gerards wrote: When this is called from normal mode, by running a command this means that another normal mode will be started again. If you run this command a few times, you would see a lot normal modes running when examining the stack, right? Hmm, I think you'r

Re: [patch] ls on PPC

2005-02-13 Thread Marco Gerards
Hollis Blanchard <[EMAIL PROTECTED]> writes: > Turns out the `ls' module was omitted from PPC's module list. Once I > added it, I found it needs one more libgcc export. Yeah, that's the reason why it was turned off. Feel free to commit this patch. Thanks, Marco __

Re: [Suggestion] LILO-like direct menu item access && scripting

2005-02-13 Thread Marc-Jano Knopp
On Fri, 11 Feb 2005 at 18:13 (+0100), Serbinenko Vladimir wrote: > Marc-Jano Knopp wrote: > >On Fri, 11 Feb 2005 at 15:34 (+0100), Serbinenko Vladimir wrote: > >>Marc-Jano Knopp wrote: > >>>On Fri, 11 Feb 2005 at 10:38 (+0100), Yoshinori K. Okuji wrote: > On Thursday 10 February 2005 22:51, Mar

Re: [patch] set prefix on PPC

2005-02-13 Thread Marco Gerards
Hollis Blanchard <[EMAIL PROTECTED]> writes: Hi, > This code sets the GRUB "prefix" environment variable from the OF > /chosen/bootpath property. It must therefore translate between the two > syntaxes. Personally I don't like setting prefix to the path grubof was loaded from. Mainly because of

Re: [patch] configfile

2005-02-13 Thread Marco Gerards
Hollis Blanchard <[EMAIL PROTECTED]> writes: > 2005-02-13 Hollis Blanchard <[EMAIL PROTECTED]> > > * conf/i386-pc.rmk (pkgdata_MODULES): Add configfile.mod. > * conf/powerpc-ieee1275.rmk (pkgdata_MODULES): Likewise. > * commands/configfile.mod: New file. Could you please add i

[patch] set prefix on PPC

2005-02-13 Thread Hollis Blanchard
Any comments on this patch? This code sets the GRUB "prefix" environment variable from the OF /chosen/bootpath property. It must therefore translate between the two syntaxes. I believe most of this code could be moved to a kern/ieee1275/device.c file, but that can wait until there is another supp

Re: [patch] configfile

2005-02-13 Thread Yoshinori K. Okuji
On Sunday 13 February 2005 16:18, Hollis Blanchard wrote: > I haven't tested on i386. I'm not sure about the `nested' parameter > to grub_normal_execute, but this code seems to be working fine. If NESTED is non-zero, the menu and the command-line interface should display a bit different messages

[patch] configfile

2005-02-13 Thread Hollis Blanchard
While working on setting prefix correctly, I found it useful to have the `configfile' command like GRUB Legacy. I haven't tested on i386. I'm not sure about the `nested' parameter to grub_normal_execute, but this code seems to be working fine. 2005-02-13 Hollis Blanchard <[EMAIL PROTECTED]>

[patch] ls on PPC

2005-02-13 Thread Hollis Blanchard
Turns out the `ls' module was omitted from PPC's module list. Once I added it, I found it needs one more libgcc export. -Hollis 2005-02-13 Hollis Blanchard <[EMAIL PROTECTED]> * conf/powerpc-ieee1275.rmk (pkgdata_MODULES): Add ls.mod. * include/grub/powerpc/libgcc.h (__mulsf3):