Re: [PATCH] add a counter in grub_dprintf

2008-06-26 Thread Robert Millan
On Sat, Jun 21, 2008 at 04:35:07PM +0200, Javier Martín wrote: Why not modify the build system to create _two_ instances of kernel.img, one with and another without debugging? grub_mkimage would create the normal, smaller core.img (without dprintf) for installing and embedding; and store a

macbook keyboard workaround (Re: [PATCH] Loading windows in macbook)

2008-06-26 Thread Robert Millan
On Wed, Jun 25, 2008 at 04:11:18AM +0800, Bean wrote: Hi, This patch fix two problem that can cause problem for grub-pc in macbook. Somewhat unrelated but, it just made me remember: I received reports that performing the keyboard workaround for macbook twice would hang GRUB. This is

Re: Failure to embed core.img is fatal now

2008-06-26 Thread Robert Millan
On Wed, Jun 25, 2008 at 05:48:34PM -0400, Pavel Roskin wrote: I'm also surprised that the code alternately uses dir and DEFAULT_DIRECTORY to calculate core_path. core_path is calculated 3 times in one function! If dir and DEFAULT_DIRECTORY are used correctly, I suggest that two different

Re: [PATCH] disk/fs_uuid.c

2008-06-26 Thread Robert Millan
On Fri, Jun 06, 2008 at 06:23:39PM +0200, Robert Millan wrote: Even with this efficiency problem, since it doesn't interfere with anything else I'm inclined to commit it, if nobody objects. Committed. -- Robert Millan GPLv2 I know my rights; I want my phone call! DRM What good is a phone

Re: Switch to SVN ?

2008-06-26 Thread Marco Gerards
Yoshinori K. Okuji [EMAIL PROTECTED] writes: On Tuesday 17 June 2008 14:48:52 Marco Gerards wrote: Hi, Bean [EMAIL PROTECTED] writes: It seems svn is available at savannah: https://savannah.gnu.org/forum/forum.php?forum_id=5340 any plan to switch ? This seems like a good idea to

Re: Failure to embed core.img is fatal now

2008-06-26 Thread Pavel Roskin
On Thu, 2008-06-26 at 16:20 +0200, Robert Millan wrote: On Wed, Jun 25, 2008 at 05:48:34PM -0400, Pavel Roskin wrote: I'm also surprised that the code alternately uses dir and DEFAULT_DIRECTORY to calculate core_path. core_path is calculated 3 times in one function! If dir and

Re: [PATCH] add a counter in grub_dprintf

2008-06-26 Thread Javier Martín
El jue, 26-06-2008 a las 16:08 +0200, Robert Millan escribió: On Sat, Jun 21, 2008 at 04:35:07PM +0200, Javier Martín wrote: Why not modify the build system to create _two_ instances of kernel.img, one with and another without debugging? grub_mkimage would create the normal, smaller

Re: macbook keyboard workaround (Re: [PATCH] Loading windows in macbook)

2008-06-26 Thread Bean
On Thu, Jun 26, 2008 at 10:13 PM, Robert Millan [EMAIL PROTECTED] wrote: On Wed, Jun 25, 2008 at 04:11:18AM +0800, Bean wrote: Hi, This patch fix two problem that can cause problem for grub-pc in macbook. Somewhat unrelated but, it just made me remember: I received reports that performing

Re: Failure to embed core.img is fatal now

2008-06-26 Thread Pavel Roskin
On Thu, 2008-06-26 at 10:48 -0400, Pavel Roskin wrote: Anyway, I think there is a much simpler approach. Changes to the memory image of core.img should be applied after the image is tested for readability. Until then, they should be in temporary variables. Here's the patch. It's an