Re: no commit allowed under discussion

2009-04-06 Thread Bean
On Tue, Apr 7, 2009 at 8:37 AM, Yoshinori K. Okuji wrote: > On Tuesday 07 April 2009 01:43:17 Bean wrote: >> On Sat, Apr 4, 2009 at 8:53 PM, Bean wrote: >> > On Sat, Apr 4, 2009 at 5:30 PM, Yoshinori K. Okuji > wrote: >> >> I've undone r2063, since we're still discussing how to / not to split >>

Re: multiboot2

2009-04-06 Thread phcoder
Yoshinori K. Okuji wrote: 1) double the size of flags. 8 features per category seems to be few. I do not agree on this. As you can see, most bits are still undefined after over 10-year usage of the Multiboot Specification. I do not want to change it without any real issue. The difference i

Re: [PATCH] Video mode fixes in linux loader

2009-04-06 Thread Pavel Roskin
On Tue, 2009-04-07 at 09:31 +0900, Yoshinori K. Okuji wrote: > > + free_pages(); > > Please insert a space before the parenthesis. Done. > This is not due to you, but the comment above is not synchronized with the > code apparently. Can you fix it? Fixed and committed. -- Regards, Pavel Ros

Re: no commit allowed under discussion

2009-04-06 Thread phcoder
Yoshinori K. Okuji wrote: On Tuesday 07 April 2009 01:43:17 Bean wrote: On Sat, Apr 4, 2009 at 8:53 PM, Bean wrote: On Sat, Apr 4, 2009 at 5:30 PM, Yoshinori K. Okuji wrote: I've undone r2063, since we're still discussing how to / not to split modules. Bean, you must respect teamwork. If yo

Re: [PATCH] Split of normal mode (version 2)

2009-04-06 Thread Yoshinori K. Okuji
On Tuesday 07 April 2009 01:39:23 Bean wrote: > Hi, > > This is another update of the patch. Thank you. I will review your patch and send comments tonight. Regards, Okuji > 1, Now completion.c is in menu.mod, and menu_viewer.c is in misc.mod, > the reason for the switch is to allow configfile to

Re: no commit allowed under discussion

2009-04-06 Thread Yoshinori K. Okuji
On Tuesday 07 April 2009 01:43:17 Bean wrote: > On Sat, Apr 4, 2009 at 8:53 PM, Bean wrote: > > On Sat, Apr 4, 2009 at 5:30 PM, Yoshinori K. Okuji wrote: > >> I've undone r2063, since we're still discussing how to / not to split > >> modules. Bean, you must respect teamwork. If you are unable to

Re: stat for FreeBSD

2009-04-06 Thread Yoshinori K. Okuji
On Tuesday 07 April 2009 00:48:37 Andrey Shuvikov wrote: > Here is the patch against the latest revision to make grub-probe working on > FreeBSD. It includes this ioctl call, FreeBSD device names parsing, and > accounts for the fact that disk drives are character devices under FreeBSD. Do you have

Re: [PATCH] Video mode fixes in linux loader

2009-04-06 Thread Yoshinori K. Okuji
On Tuesday 07 April 2009 00:34:03 Pavel Roskin wrote: > Hello! > > This is an attempt to fix all issues with the video mode handling in the > new Linux loader. > > First of all, free_page() doesn't belong to grub_linux_unload(). The > later function is called after the new kernel has been loaded,

Re: UFS fixes

2009-04-06 Thread Yoshinori K. Okuji
On Monday 06 April 2009 22:29:58 phcoder wrote: > Here are the fixes for UFS. Basically it's a resubmit of my previous > patch. It works fine with both solaris UFS and recent BSD UFS2. Does it > break anything for anyone with ufs? I don't have UFS, but the patch looks good to me. Regards, Okuji

Re: multiboot2

2009-04-06 Thread Yoshinori K. Okuji
On Monday 06 April 2009 08:34:23 phcoder wrote: > These issues still remain > > phcoder wrote: > > Hello I was looking into multiboot2 specifications and have some > > suggestions: > > 1) double the size of flags. 8 features per category seems to be few. I do not agree on this. As you can see, mos

Re: Grub2 svn2059

2009-04-06 Thread BandiPat
Yoshinori K. Okuji wrote: On Saturday 04 April 2009 04:02:18 BandiPat wrote: Yoshinori K. Okuji wrote: On Friday 03 April 2009 14:17:04 step21 wrote: Hey, just a wild guess, but I think boot.mod got dropped and the boot command is now included in minicmd.mod Yes, it seems so. And, it is a mis

Re: on splitting modules

2009-04-06 Thread Bean
On Mon, Apr 6, 2009 at 1:55 AM, Yoshinori K. Okuji wrote: > Hello, > > I have written an article on the wiki right now: > > http://grub.enbug.org/OnSplittingModules > > This article is based on our discussion on the IRC. I think the disagreement > between Bean and me derived from that I didn't kno

Re: memory allocator enhancements...

2009-04-06 Thread phcoder
phcoder wrote: Hello, one additional consideration is to let grub2 stay in memory even after OS loads. This way it would be possibly to expose any file/partition accessible through grub2 system as a virtual int13h disk. For this to be a it's very desirable to put all modules that may need to s

Re: no commit allowed under discussion

2009-04-06 Thread Bean
On Sat, Apr 4, 2009 at 8:53 PM, Bean wrote: > On Sat, Apr 4, 2009 at 5:30 PM, Yoshinori K. Okuji wrote: >> I've undone r2063, since we're still discussing how to / not to split >> modules. >> Bean, you must respect teamwork. If you are unable to follow such a >> fundamental rule, I will have to

Re: [PATCH] parttool

2009-04-06 Thread Pavel Roskin
On Mon, 2009-04-06 at 18:25 +0200, phcoder wrote: > The problem is that the exact available options depend on partition type > so you have to specify > parttool help > Unfortunately for now you have to load the module pcpart.mod manually. > I'll fix this problem by making parttool load the corr

Re: [PATCH] parttool

2009-04-06 Thread phcoder
Pavel Roskin wrote: On Mon, 2009-04-06 at 17:56 +0200, phcoder wrote: Pavel Roskin wrote: On Mon, 2009-04-06 at 11:52 +0200, phcoder wrote: Fixed & commited. My next patch will be to add automatic module loading in parttool It would be great to make parttool actually give some usage informati

Re: [PATCH] parttool

2009-04-06 Thread Pavel Roskin
On Mon, 2009-04-06 at 17:56 +0200, phcoder wrote: > Pavel Roskin wrote: > > On Mon, 2009-04-06 at 11:52 +0200, phcoder wrote: > >> Fixed & commited. My next patch will be to add automatic module loading > >> in parttool > > > > It would be great to make parttool actually give some usage informati

Re: [PATCH] parttool

2009-04-06 Thread phcoder
Pavel Roskin wrote: On Mon, 2009-04-06 at 11:52 +0200, phcoder wrote: Fixed & commited. My next patch will be to add automatic module loading in parttool It would be great to make parttool actually give some usage information. Right now, there is no information at all. grub> parttool error: t

Re: [PATCH] parttool

2009-04-06 Thread Pavel Roskin
On Mon, 2009-04-06 at 11:52 +0200, phcoder wrote: > Fixed & commited. My next patch will be to add automatic module loading > in parttool It would be great to make parttool actually give some usage information. Right now, there is no information at all. grub> parttool error: too few arguments gr

Re: stat for FreeBSD

2009-04-06 Thread Andrey Shuvikov
--- On Sat, 2/7/09, Robert Millan wrote: > From: Robert Millan > Subject: Re: stat for FreeBSD > To: "The development of GRUB 2" > Date: Saturday, February 7, 2009, 2:39 PM > On Mon, Dec 15, 2008 at 09:24:41AM > -0800, Andrey Shuvikov wrote: > > I don't have much experience developing under Fre

[PATCH] Video mode fixes in linux loader

2009-04-06 Thread Pavel Roskin
Hello! This is an attempt to fix all issues with the video mode handling in the new Linux loader. First of all, free_page() doesn't belong to grub_linux_unload(). The later function is called after the new kernel has been loaded, just before the boot. Thus it obliterates the data set up by the

UFS fixes

2009-04-06 Thread phcoder
Here are the fixes for UFS. Basically it's a resubmit of my previous patch. It works fine with both solaris UFS and recent BSD UFS2. Does it break anything for anyone with ufs? 2009-04-06 Vladimir Serbinenko UFS improvements * fs/ufs.c (INODE_NBLOCKS): new definition

Re: [PATCH] parttool

2009-04-06 Thread phcoder
Fixed & commited. My next patch will be to add automatic module loading in parttool Yoshinori K. Okuji wrote: On Saturday 04 April 2009 18:22:39 phcoder wrote: Can someone review this patch? Only some style should be corrected. For example: +#ifndef GRUB_UTIL + if (!parts) +grub_dl_unre

Re: grub2 and network boot

2009-04-06 Thread Felix Zielcke
Am Sonntag, den 05.04.2009, 23:52 -0400 schrieb Pavel Roskin: > On Sun, 2009-04-05 at 22:47 -0500, Dallas Clement wrote: > > Hello All, > > > > Forgive me for asking a newb question, but could someone please tell > > me how to configure grub2 to do either a TFTP or NFS boot? I am > > assuming thi