Re: On grub_strchr implementation

2009-11-01 Thread BVK
Attached is the new patch without NULL dereference checks. I looked at grub_strchr and grub_strrchr calls as much as I can, and they don't seem to rely on NULL dereference behavior. But it was not feasible to verify this for some cases, as we are using function pointers (like, grub_disk_dev->open

[PATCH,HURD] Fix 10_hurd for separate /boot case.

2009-11-01 Thread Samuel Thibault
Hello, This patch fixes the 10_hurd script in the case where /boot is in a separate partition. Samuel 2009-11-02 Samuel Thibault * util/grub.d/10_hurd.in: Call prepare_grub_to_access_device ${GRUB_DEVICE_BOOT} before loading /boot kernel. Index: util/grub.d/10_hurd.in ===

[PATCH,HURD] Fix GNU/Hurd partition number

2009-11-01 Thread Samuel Thibault
Hello, This patch fixes partition number translation on GNU/Hurd. Samuel 2009-11-02 Samuel Thibault * util/hostdisk.c (grub_util_biosdisk_get_grub_dev): Subtract 1 from GNU partition number to get internal grub DOS partition number. Index: util/hostdisk.c

Using Grub & Licensing....

2009-11-01 Thread demetrioussharpe
Is there any way of using the grub header without causing my kernel to become GPL? I'd like to use grub, but I also want to chose which license I use, rather than let grub's header choose for me. Dee ___ Grub-devel mailing list Grub-devel@gnu.org http:

Re: On grub_strchr implementation

2009-11-01 Thread BVK
On Mon, Nov 2, 2009 at 3:28 AM, Robert Millan wrote: > > But you also added a check for NULL dereference.  Is that also required by > the standard? > Standard doesn't say anything about it, so I guess it means, it is left for implementations. Old grub_strchr implementation has this check, so kep

Re: gettext branch

2009-11-01 Thread Carles Pina i Estany
Hi, On Nov/01/2009, Carles Pina i Estany wrote: > On Nov/01/2009, Carles Pina i Estany wrote: > > > bzr.savannah.gnu.org/grub/people/cpina/gettext2 > > (notice the 2 at the end!) > > without the 2, Robert moved it correctly. > > So the address of the gettext branch is. > bzr.savannah.gnu.org/

Re: gettext branch

2009-11-01 Thread Carles Pina i Estany
Hi, On Nov/01/2009, Carles Pina i Estany wrote: > bzr.savannah.gnu.org/grub/people/cpina/gettext2 > (notice the 2 at the end!) without the 2, Robert moved it correctly. So the address of the gettext branch is. bzr.savannah.gnu.org/grub/people/cpina/gettext2 Cheers, -- Carles Pina i Estany

Re: [PATH] grub-mkrelpath

2009-11-01 Thread Robert Millan
On Sun, Nov 01, 2009 at 04:39:42PM +0100, Felix Zielcke wrote: > > I added now a comment that this shouldn't ever happen. > > New version avaible at > bzr+ssh://bzr.savannah.gnu.org/grub/people/fzielcke/mkrelpath Vladimir, could you review and consider for inclusion in experimental? Or if you'r

Re: On grub_strchr implementation

2009-11-01 Thread Robert Millan
On Mon, Nov 02, 2009 at 12:24:33AM +0530, BVK wrote: > hi, > > > As per http://www.opengroup.org/onlinepubs/009695399/functions/strchr.html > strchr method should consider '\0' as part of the string, which means, > strchr should return '\0' character position when it is passed as the > character

gettext branch

2009-11-01 Thread Carles Pina i Estany
Hello, After some time of non-activity I'm back, and I think that during the next weeks with enough time to finish the gettext topic. The branch is here: bzr.savannah.gnu.org/grub/people/cpina/gettext2 (notice the 2 at the end!) We have talked about the gettext two times, last time was last Ju

On grub_strchr implementation

2009-11-01 Thread BVK
hi, As per http://www.opengroup.org/onlinepubs/009695399/functions/strchr.html strchr method should consider '\0' as part of the string, which means, strchr should return '\0' character position when it is passed as the character to look for. I believe, grub_strchr is intended to mimic standard

Re: bzr trunk failed to build from separate build directory

2009-11-01 Thread BVK
On Sun, Nov 1, 2009 at 11:30 PM, Felix Zielcke wrote: > Solution is to add `-I$(srcdir)/include' to TARGET_CPPFLAGS in Makefile > or Makefile.in and call configure again Thanks. -- bvk-chaitanya ___ Grub-devel mailing list Grub-devel@gnu.org http:

Re: bzr trunk failed to build from separate build directory

2009-11-01 Thread Felix Zielcke
Am Sonntag, den 01.11.2009, 22:58 +0530 schrieb BVK: > hi > > Bazaar branch, http://bzr.savannah.gnu.org/r/grub/trunk/grub doesn't > seem to build from separate build directory? When I tried building it > from trunk, it goes fine. > > gcc -Iboot/i386/pc -I../trunk/boot/i386/pc -isystem=../trunk/

bzr trunk failed to build from separate build directory

2009-11-01 Thread BVK
hi Bazaar branch, http://bzr.savannah.gnu.org/r/grub/trunk/grub doesn't seem to build from separate build directory? When I tried building it from trunk, it goes fine. gcc -Iboot/i386/pc -I../trunk/boot/i386/pc -isystem=../trunk/include -I. -I./include -Wall -W -DASM_FILE=1 -nostdinc -fno-built

Re: [GITGRUB] New menu interface (implementation)

2009-11-01 Thread Bean
Hi, Update: New handler class menu_viewer, new menu system is now a menu viewer handler. (emenu.mod) Remove reader handler class. New module lib.mod containing helper functions. Move common function for normal.mod to lib.mod. Move the menu out of normal.mod as standalone menu viewer. (nmenu.mod)

Re: [PATH] grub-mkrelpath

2009-11-01 Thread Felix Zielcke
Am Samstag, den 29.08.2009, 09:51 +0200 schrieb Felix Zielcke: > Am Samstag, den 29.08.2009, 01:55 +0200 schrieb Robert Millan: > > On Fri, Aug 28, 2009 at 07:58:39PM +0200, Felix Zielcke wrote: > > > +#else /* ! HAVE_REALPATH */ > > > + grub_util_warn ("grub-mkrelpath might not work on your OS co

Re: "error: invalid magic number" when booting from ISO loopback

2009-11-01 Thread Ron
On Sun, 2009-11-01 at 08:53 +0100, Vladimir 'phcoder' Serbinenko wrote: > Ron wrote: > > On Sat, 2009-10-31 at 18:30 +0100, Robert Millan wrote: > > > >> On Sat, Oct 31, 2009 at 06:01:56PM +0100, Ron wrote: > >> > >>> Hi, > >>> > >>> I was playing around with Grub2 (latest svn version) and

Re: GPT BIOS boot partition and installing to a partition

2009-11-01 Thread Robert Millan
On Sat, Oct 31, 2009 at 02:29:45PM -0400, Dave Vasilevsky wrote: > On my GPT-partitioned MacBook, I seem to have two options for booting > with grub-pc: > > 1. Install grub to the start of an existing partition. This coexists > well with the rEFIt boot menu, but requires blocklists to load > core.

Re: "error: invalid magic number" when booting from ISO loopback

2009-11-01 Thread Vladimir 'phcoder' Serbinenko
Ron wrote: > On Sat, 2009-10-31 at 18:30 +0100, Robert Millan wrote: > >> On Sat, Oct 31, 2009 at 06:01:56PM +0100, Ron wrote: >> >>> Hi, >>> >>> I was playing around with Grub2 (latest svn version) and its loopback >>> feature and had some problems to boot an ISO. The ISO file is the 32Bit