Re: Imminent bugfix release (1.97.1)

2009-11-10 Thread Bean
On Tue, Nov 10, 2009 at 1:39 PM, Bean wrote: > On Tue, Nov 10, 2009 at 5:34 AM, Vladimir 'phcoder' Serbinenko > wrote: >> But now it has a technical problem: it may read post array definitions. >> If any of post-array memory is MMIO or absent reading from it may have >> peculiar consequences >>>

Re: Imminent bugfix release (1.97.1)

2009-11-10 Thread Bean
On Tue, Nov 10, 2009 at 4:28 PM, Bean wrote: > On Tue, Nov 10, 2009 at 1:39 PM, Bean wrote: >> On Tue, Nov 10, 2009 at 5:34 AM, Vladimir 'phcoder' Serbinenko >> wrote: >>> But now it has a technical problem: it may read post array definitions. >>> If any of post-array memory is MMIO or absent re

Re: Imminent bugfix release (1.97.1)

2009-11-10 Thread Bean
On Tue, Nov 10, 2009 at 4:46 PM, Bean wrote: > Hi, > > Just in case p2 is optimized out by gcc: > > typedef char grub_password_t[1024]; > > int > grub_auth_strcmp (const grub_password_t s1, const grub_password_t s2) > { >  char r1 = 0; >  char r2 = 0; >  char r3 = 0; >  char *p1, *p2; >  int i; >

Re: Imminent bugfix release (1.97.1)

2009-11-10 Thread Bean
On Tue, Nov 10, 2009 at 4:52 PM, Bean wrote: > Hi, > > Perhaps this one, it's more symmetrical: > > typedef char grub_password_t[1024]; > > int > grub_auth_strcmp (const grub_password_t s1, const grub_password_t s2) > { >  char r1 = 0; >  char r2 = 0; >  char r3 = 0; >  char *p1, *p2; >  int i; >

RE: Grub-devel Digest, Vol 69, Issue 19

2009-11-10 Thread Pedro A ARANDA
Hi all, just my .2 euto-cents: With this function, you always assume that strlen(s1) <= strlen(s2), right? > int > grub_auth_strcmp (const char *s1, const char *s2) > { > int n; > volatile int ret = 0; > > for (n = grub_strlen (s1); n >= 0; n--) > { > if (*s1 != *s2) > r

Re: Imminent bugfix release (1.97.1)

2009-11-10 Thread Bean
Hi, Oh, I just come up with a better way to do this: typedef char grub_password_t[1024]; int grub_auth_strcmp (const grub_password_t s1, const grub_password_t s2) { char r1 = 0; char r2 = 0; char *p; int i, c; p = &r1; c = 0; for (i = 0; i < sizeof (grub_password_t); i++, s1++, s2++)

Re: Grub-devel Digest, Vol 69, Issue 19

2009-11-10 Thread richardvo...@gmail.com
On Tue, Nov 10, 2009 at 4:06 AM, Pedro A ARANDA wrote: > Hi all, > > just my .2 euto-cents: > > With this function, you always assume that strlen(s1) <= strlen(s2), > right? > >> int >> grub_auth_strcmp (const char *s1, const char *s2) >> { >> int n; >> volatile int ret = 0; >> >> for (n = gru

Re: mingw32 compile fixes (Re: [GITGRUB] New menu interface (implementation))

2009-11-10 Thread Bean
On Tue, Nov 10, 2009 at 4:03 AM, Robert Millan wrote: > On Tue, Nov 10, 2009 at 12:46:06AM +0800, Bean wrote: >> >> MINGW don't have fnmatch.h, add fnmatch.h to include >> MINGW don't define S_IROTH, S_IRGRP and u_char >> MINGW don't have lstat, getuid and getgid. > > I started making some adjustm

Re: Imminent bugfix release (1.97.1)

2009-11-10 Thread Duboucher Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Bean a écrit : > Hi, > > Oh, I just come up with a better way to do this: > > typedef char grub_password_t[1024]; > > int > grub_auth_strcmp (const grub_password_t s1, const grub_password_t s2) > { > char r1 = 0; > char r2 = 0; > char *p; > int

Re: Imminent bugfix release (1.97.1)

2009-11-10 Thread Bean
On Tue, Nov 10, 2009 at 10:25 PM, Duboucher Thomas wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Bean a écrit : >> Hi, >> >> Oh, I just come up with a better way to do this: >> >> typedef char grub_password_t[1024]; >> >> int >> grub_auth_strcmp (const grub_password_t s1, const grub

Re: Imminent bugfix release (1.97.1)

2009-11-10 Thread richardvo...@gmail.com
On Tue, Nov 10, 2009 at 8:25 AM, Duboucher Thomas wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Bean a écrit : >> Hi, >> >> Oh, I just come up with a better way to do this: >> >> typedef char grub_password_t[1024]; >> >> int >> grub_auth_strcmp (const grub_password_t s1, const grub_

Re: Imminent bugfix release (1.97.1)

2009-11-10 Thread Duboucher Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 richardvo...@gmail.com a écrit : > > for (it = retval = 0; it < PASSPHRASE_MAXSIZE; it++, input++, key++) > >> After changing the parameter type, those postincrements won't do what >> you expect. > Damn examinations; I really need to sleep! =)

Re: Imminent bugfix release (1.97.1)

2009-11-10 Thread Duboucher Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Bean a écrit : > > Hi, > > My previous function ensures that execution time is the same > regardless of the input. Although it's not necessary, I guess it's a > nice feature to have. BTW, the simpler function does leak one > information, the size of

Re: Imminent bugfix release (1.97.1)

2009-11-10 Thread Vladimir 'phcoder' Serbinenko
Duboucher Thomas wrote: > Bean a écrit : > > Hi, > > > My previous function ensures that execution time is the same > > regardless of the input. Although it's not necessary, I guess it's a > > nice feature to have. BTW, the simpler function does leak one > > information, the size of buffer as the e

Re: Imminent bugfix release (1.97.1)

2009-11-10 Thread Vladimir 'phcoder' Serbinenko
Bean wrote: > On Tue, Nov 10, 2009 at 10:25 PM, Duboucher Thomas > wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Bean a écrit : >> >>> Hi, >>> >>> Oh, I just come up with a better way to do this: >>> >>> typedef char grub_password_t[1024]; >>> >>> int >>> grub_auth_st

Re: Imminent bugfix release (1.97.1)

2009-11-10 Thread Duboucher Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Vladimir 'phcoder' Serbinenko a écrit : > With this change grub_auth_strcmp becomes a misnomer. I would prefer to > call it grub_auth_memcmp then. I'll also look into which other free > secure strcmp are available Asking developpers of project

LVM write support from grub2. Writing to environment block in core.img

2009-11-10 Thread Roger Cruz
Hi there developers, I posted this message last night and I was wondering if one of you would be kind enough to make a reply as to your assessment of having an LVM write function implemented. I am in dire need to have this capability so I'm willing to code myself if need to. I just need to un

Re: LVM write support from grub2. Writing to environment block in core.img

2009-11-10 Thread Vladimir 'phcoder' Serbinenko
Roger Cruz wrote: > Hi there developers, > > I posted this message last night and I was wondering if one of you > would be kind enough to make a reply as to your assessment of having > an LVM write function implemented. I am in dire need to have this > capability so I'm willing to code myself if n

Re: Feature request: network devices

2009-11-10 Thread mardok45
Are you talking about Grub legacy? I would like to use Grub2 just for the sake of being up-to-date. What needs to be added to Grub2 to be able to boot via TFTP? I can't make any promises, but I would like to see if I can add the features myself as a side project (when I'm not busy with school).

Roadmap for LUA support in GRUB

2009-11-10 Thread Roman Shaposhnik
Hi! I was very excited to see Ubuntu 9.10 being one of the first distributions to officially switch to GRUB v2, but there was one fly in that ointment of happiness -- the lack of Lua scripting :-( Browsing the archives of grub-devel reveals that Lua support was moved to grub-extras which makes me

Bug in read_handler_list (autoloading) ???

2009-11-10 Thread BVK
Hi, I was trying grub-emu from experimental branch, and grub-emu aborts with below error. It seems read_handler_list function is trying to grub_free non-heap global objects. Suspecious code (read_handler_list in normal/handler.c): /* Override previous handler.lst. */

Re: Feature request: network devices

2009-11-10 Thread Seth Goldberg
Hi, Enhancing the TFTP & PXE boot capabilities of GRUB2 is extremely important to our use of GRUB2, so if you're interested in doing this work, please let me know so we can coordinate our efforts. Thanks, --S Quoting mardok45, who wrote the following on Tue, 10 Nov 2009: Are you talkin

Re: Feature request: network devices

2009-11-10 Thread Bean
On Wed, Nov 11, 2009 at 12:32 PM, Seth Goldberg wrote: > Hi, > >  Enhancing the TFTP & PXE boot capabilities of GRUB2 is extremely important > to our use of GRUB2, so if you're interested in doing this work, please let > me know so we can coordinate our efforts. Hi, Isn't TFTP and PXE boot suppo

Re: Feature request: network devices

2009-11-10 Thread Vasily Averin
Bean wrote: > On Wed, Nov 11, 2009 at 12:32 PM, Seth Goldberg wrote: >> Hi, >> >> Enhancing the TFTP & PXE boot capabilities of GRUB2 is extremely important >> to our use of GRUB2, so if you're interested in doing this work, please let >> me know so we can coordinate our efforts. > > Hi, > > Is

Re: Feature request: network devices

2009-11-10 Thread Bean
On Wed, Nov 11, 2009 at 3:02 PM, Vasily Averin wrote: > Bean wrote: >> On Wed, Nov 11, 2009 at 12:32 PM, Seth Goldberg >> wrote: >>> Hi, >>> >>>  Enhancing the TFTP & PXE boot capabilities of GRUB2 is extremely important >>> to our use of GRUB2, so if you're interested in doing this work, please

Re: Feature request: network devices

2009-11-10 Thread Vasily Averin
Bean wrote: > On Wed, Nov 11, 2009 at 3:02 PM, Vasily Averin wrote: >> Bean wrote: >>> On Wed, Nov 11, 2009 at 12:32 PM, Seth Goldberg >>> wrote: Hi, Enhancing the TFTP & PXE boot capabilities of GRUB2 is extremely important to our use of GRUB2, so if you're interested in do