Re: [PATCH] Fix Cygwin path handling

2010-04-26 Thread Christian Franke
Vladimir 'φ-coder/phcoder' Serbinenko wrote: Christian Franke wrote: + /* Include leading slash. */ + offset = 0; + break; Why do you make this change? It seems to make the behaviour of make_path_relative_to_its root inconsistent since E.g. /boot/grub - grub

Re: [PATCH] Fix Cygwin path handling

2010-04-26 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Christian Franke wrote: Vladimir 'φ-coder/phcoder' Serbinenko wrote: Christian Franke wrote: + /* Include leading slash. */ + offset = 0; + break; Why do you make this change? It seems to make the behaviour of make_path_relative_to_its root inconsistent since E.g.

Re: [PATCH] Fix Cygwin path handling

2010-04-26 Thread Christian Franke
Vladimir 'φ-coder/phcoder' Serbinenko wrote: I actually seen the '/' case and have incorrectly assumed it's always so. However there is still one case when you patch changes the behaviour: $ grub-mkrelpath / $ ./grub-mkrelpath / / Although: $ ./grub-mkrelpath /mnt/boot/ $ grub-mkrelpath