>From: Vladimir '?-coder/phcoder' Serbinenko
> On 12/29/2010 07:25 AM, ehem+g...@m5p.com wrote:
> >> From: Vladimir '?-coder/phcoder' Serbinenko
> >> On 12/26/2010 10:15 PM, ehem+g...@m5p.com wrote:
> >>
> >>> Quite simple, the disk slice scheme detection routines vary in the
> >>> quality o
Now with a ChangeLog entry. -V
=== modified file 'ChangeLog'
--- ChangeLog 2010-12-27 06:19:51 +
+++ ChangeLog 2010-12-30 07:39:45 +
@@ -1,3 +1,11 @@
+2010-12-30 Dave Vasilevsky
+
+ * grub-core/fs/hfsplus.c: Parent field of
+ grub_hfsplus_catkey_internal should be unsigne
When very high Catalog Node IDs are in use, comparing CNIDs via
subtraction may overflow. This causes files and folders to appear to be
missing in the btree. It's safer to just use comparison operations
rather than subtraction.
Also fixes the parent field in grub_hfsplus_catkey_internal, which is
Alas, AmigaOS has mostly passed beyond the veil, but one can still find
small bugs sometimes:
=== modified file 'grub-core/partmap/amiga.c'
--- grub-core/partmap/amiga.c 2010-03-26 14:44:13 +
+++ grub-core/partmap/amiga.c 2010-12-30 06:25:26 +
@@ -87,7 +87,7 @@
if (grub_disk_rea
Hi,
2010/12/27 Vladimir 'φ-coder/phcoder' Serbinenko :
> On 12/26/2010 10:15 PM, ehem+g...@m5p.com wrote:
>> Quite simple, the disk slice scheme detection routines vary in the
>> quality of their detection. In particular, the MSDOS-style detection is
>> *extremely* brittle. The only even mildly di
Quoting Vladimir 'φ-coder/phcoder' Serbinenko, who wrote the following on...:
My suggested fix is to move the calls to grub_machine_set_prefix()
and grub_set_root_dev before grub_load_modules(). A cursory
examination of these functions doesn't reveal any dependence on any
loadable modules,
> My suggested fix is to move the calls to grub_machine_set_prefix()
> and grub_set_root_dev before grub_load_modules(). A cursory
> examination of these functions doesn't reveal any dependence on any
> loadable modules, but I'm not 100% sure about that.
The dependence is subtle: set_prefix may
On 12/29/2010 07:25 AM, ehem+g...@m5p.com wrote:
>> From: Vladimir '?-coder/phcoder' Serbinenko
>> On 12/26/2010 10:15 PM, ehem+g...@m5p.com wrote:
>>
>>> Quite simple, the disk slice scheme detection routines vary in the
>>> quality of their detection. In particular, the MSDOS-style detectio
