extract_legacy_entries_source hoses system when menu.lst can't be opened

2012-01-27 Thread Seth Goldberg
Hi there, In grub_cmd_legacy_source, if the menu.lst file cannot opened in legacy_file(), grub_env_extractor_close() attempts to access memory at address 4, which could end up corrupting the entire menu. The easy fix is to check if the first call to grub_env_get_menu() returns NULL and ba

Re: [Patch] Robustly search for ZFS labels & uberblocks

2012-01-27 Thread Richard Laager
On Fri, 2012-01-27 at 14:04 -0500, Zachary Bedell wrote: > I've had to forward port the other changes necessary to support build on > Linux. Attached is the work I've done on this front. This includes the "allow spaces in zpools" patch I previously submitted to grub-devel. And, the changes in 10_

Re: [Patch] Robustly search for ZFS labels & uberblocks

2012-01-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 27.01.2012 20:04, Zachary Bedell wrote: Thanks for plodding through my mess. It looks like the changes are committed to trunk at this point, right? I'm trying to get a test together, but I've had to forward port the other changes necessary to support build on Linux. I think I have those

Re: [RFC] FIEMAP and disk sync issues

2012-01-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 27.01.2012 20:04, Phillip Susi wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 1/27/2012 8:28 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: Hello, all. When someone installs using blocklists (discouraged and unreliable), we use GRUB internal fs reader in order to determine core.im

Re: [RFC] FIEMAP and disk sync issues

2012-01-27 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 It looks like BLKFLSBUF also should do the trick. That appears to both tell the fs ( if one is mounted ) to sync, and flush the dirty block buffers like fsync() on the blockdev does. -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.17 (MingW32) Comm

Re: [Patch] Robustly search for ZFS labels & uberblocks

2012-01-27 Thread Zachary Bedell
Thanks for plodding through my mess. It looks like the changes are committed to trunk at this point, right? I'm trying to get a test together, but I've had to forward port the other changes necessary to support build on Linux. I think I have those changes done in a such a way as they won't co

Re: [RFC] FIEMAP and disk sync issues

2012-01-27 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 1/27/2012 8:28 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Hello, all. When someone installs using blocklists (discouraged > and unreliable), we use GRUB internal fs reader in order to > determine core.img blocklists. With Linux we call fsync

[RFC] FIEMAP and disk sync issues

2012-01-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Hello, all. When someone installs using blocklists (discouraged and unreliable), we use GRUB internal fs reader in order to determine core.img blocklists. With Linux we call fsync and an ioctl on partition in order to flush the cache. I also tried adding "sync" which didn't make any difference.