Re: New configuration variables for setting GRUB's colors in /etc/default/grub (Debian bug #608283)

2012-02-04 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 26.05.2011 14:34, Alexander Kurtz wrote: Hi, it seems there is a quite big demand for setting GRUB's colors directly via /etc/default/grub, see [1-8]. There seem to be no official GRUB_* variables for this purpose yet[9]. However, Arch Linux recommends[10] using GRUB_COLOR_NORMAL and GRUB_CO

Re: Bug#632048: segfault in grub-setup

2012-02-04 Thread Vladimir 'φ-coder/phcoder' Serbinenko
The problem with floppy part was fixed and the attempt to install on partionless disk was a user error. Closing On 06.09.2011 16:50, Stephane Chazelas wrote: 2011-09-06 09:18:57 +0100, Colin Watson: On Tue, Sep 06, 2011 at 08:39:24AM +0100, Stephane Chazelas wrote: I do get a segfault as well

Re: Purposing an Alternative Feature Request: Make Use of Whole-Disk UUIDs

2012-02-04 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Keep the list CC'ed. On 04.02.2012 15:08, Jake Thomas wrote: If one only imaged/cloned partitions rather than whole disks, the disks' UUIDs wouldn't change, however, individual partitions would wind up with identical UUIDs. The partition UUIDs can easily be made unique afterwards with tune2fs,

[MERGE] Add a --disable-zfs configure flag.

2012-02-04 Thread Mike Gilbert
I happen to have the ZFS libraries installed on my machine, but I don't want my boot loader to use them. It seems to be broken for me at the moment in any case. I'm new to bazaar and this is my first submission to this mailing list, so please let me know if I've done something incorrectly. # Bazaa

Re: [MERGE] Add a --disable-zfs configure flag.

2012-02-04 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 04.02.2012 20:56, Mike Gilbert wrote: I happen to have the ZFS libraries installed on my machine, but I don't want my boot loader to use them. It seems to be broken for me at the moment in any case. I'm new to bazaar and this is my first submission to this mailing list, so please let me know

Re: [MERGE] Add a --disable-zfs configure flag.

2012-02-04 Thread Mike Gilbert
On 02/04/2012 03:06 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 04.02.2012 20:56, Mike Gilbert wrote: >> I happen to have the ZFS libraries installed on my machine, but I don't >> want my boot loader to use them. It seems to be broken for me at the >> moment in any case. >> >> I'm new to

Re: [PATCH] Fix format-security compile warnings/errors

2012-02-04 Thread Richard Laager
You introduced another one of these in revision 3830. Patch attached. -- Richard Index: grub/grub-core/loader/i386/xnu.c === --- grub.orig/grub-core/loader/i386/xnu.c 2012-02-04 14:44:04.022918008 -0600 +++ grub/grub-core/loader/i386

Re: [MERGE] Add a --disable-zfs configure flag.

2012-02-04 Thread Richard Laager
Additionally in the case of libzfs specifically: A) There have been compatibility breakages in the past and it's not versioned. B) GRUB has an alternate method of working with ZFS (using the command-line tools). I support* the patch if modified to name the option --disable-libzfs instead

[PATCH] diskfilter: Treat an unrecognized RAID level as an error

2012-02-04 Thread Richard Laager
disk/diskfilter.c: In function 'grub_diskfilter_make_raid': disk/diskfilter.c:847:21: error: 'totsize' may be used uninitialized in this function [-Werror=uninitialized] Perhaps my patch should use assert() instead of return NULL? -- Richard diskfilter: Treat an unrecognized RAID level as an err

Re: [MERGE] Add a --disable-zfs configure flag.

2012-02-04 Thread Mike Gilbert
On Sat, Feb 4, 2012 at 4:41 PM, Richard Laager wrote: > Additionally in the case of libzfs specifically: >  A) There have been compatibility breakages in the past and it's not >    versioned. >  B) GRUB has an alternate method of working with ZFS (using the >    command-line tools). > > I support*

Re: [PATCH] diskfilter: Treat an unrecognized RAID level as an error

2012-02-04 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 04.02.2012 23:01, Richard Laager wrote: disk/diskfilter.c: In function 'grub_diskfilter_make_raid': disk/diskfilter.c:847:21: error: 'totsize' may be used uninitialized in this function [-Werror=uninitialized] Perhaps my patch should use assert() instead of return NULL? We don't use assert si

Re: Build break (uninitialized variable)

2012-02-04 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 03.02.2012 19:26, Grégoire Sutre wrote: The compiler complains about `totsize' being possibly uninitialized in grub-core/disk/diskfilter.c, function grub_diskfilter_make_raid(). I get this error with gcc 4.5.3 on NetBSD, and also with gcc 4.6.2 on Debian GNU/Linux. I'm not familiar with that

Re: [PATCH] Don't create grubenv on ZFS

2012-02-04 Thread Jordan Uggla
On Thu, Feb 2, 2012 at 3:16 AM, Richard Laager wrote: > GRUB can't write to ZFS.  Creating a grubenv file leads to a misleading > "sparse file not allowed" error on boot.  The attached patch for > grub-install skips the creation of a grubenv file on ZFS. I think that not writing /boot/grub/gruben

Re: [MERGE] Add a --disable-zfs configure flag.

2012-02-04 Thread Mike Gilbert
On 02/04/2012 03:46 PM, Mike Gilbert wrote: > I have the libzfs headers in /usr/include/libzfs, which is where the ZFS > on Linux build system puts them. My best guess is that it isn't finding > libzfs.h, but I haven't really dug in. > As it turns out, there are a few things going on here: 1. gr

Re: [PATCH] diskfilter: Treat an unrecognized RAID level as an error

2012-02-04 Thread Richard Laager
On Sat, 2012-02-04 at 23:30 +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 04.02.2012 23:01, Richard Laager wrote: > > disk/diskfilter.c: In function 'grub_diskfilter_make_raid': > > disk/diskfilter.c:847:21: error: 'totsize' may be used uninitialized in > > this function [-Werror=uniniti

Re: Build break (uninitialized variable)

2012-02-04 Thread Grégoire Sutre
On 02/04/2012 11:31 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 03.02.2012 19:26, Grégoire Sutre wrote: The compiler complains about `totsize' being possibly uninitialized in grub-core/disk/diskfilter.c, function grub_diskfilter_make_raid(). I get this error with gcc 4.5.3 on NetBSD, and

Re: [MERGE] Add a --disable-zfs configure flag.

2012-02-04 Thread Mike Gilbert
Here's a new bundle including a --without-libzfs flag, and a fix for my build issue. # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: flop...@gentoo.org-20120205010752-empg4oxbegj3fepe # target_branch: http://bzr.savannah.gnu.org/r/grub/trunk/grub/ # testament_sha1: 3de5f3713591cd8770

Re: [PATCH] Don't create grubenv on ZFS

2012-02-04 Thread Richard Laager
You make good points. I don't have a problem with the idea that save_env should throw an error when it can't actually *save* the grubenv. So a better way to look at my problem is to say, "I don't want my grub.cfg to call save_env by default." This then becomes an downstream Ubuntu bug, because my

Re: [MERGE] Add a --disable-zfs configure flag.

2012-02-04 Thread Darik Horn
On Sat, Feb 4, 2012 at 16:36, Mike Gilbert wrote: > > 1. grub's configure is failing to detect libnvpair due to some breakage > upstream. See https://github.com/zfsonlinux/zfs/issues/560 . > Please try the attached patch, which should fix this build failure on Gentoo. Remember to run ./autogen.sh

Re: [MERGE] Add a --disable-zfs configure flag.

2012-02-04 Thread Mike Gilbert
On 02/04/2012 10:40 PM, Darik Horn wrote: > On Sat, Feb 4, 2012 at 16:36, Mike Gilbert wrote: >> >> 1. grub's configure is failing to detect libnvpair due to some breakage >> upstream. See https://github.com/zfsonlinux/zfs/issues/560 . >> > > Please try the attached patch, which should fix this b