Frozen

2012-02-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Hello, all. As of now trunk is officially frozen. Now the feature patches should be committed to experimental until 2.00 is released. Exceptions are still possible but need to be discussed separately. Following actions are allowed in trunk: - Bugfixes as long as they are unlikely to add more bu

Segfault in grub_find_root_devices_from_btrfs

2012-02-27 Thread Mike Gilbert
grub-probe is segfaulting in grub_find_root_devices_from_btrfs. Back trace attached. The variable "j" is being used as an array offset. However, j is never initialized or set to any value. Starting program: /home/floppym/src/grub/build1/grub-probe --target=device / [Thread debugging using libthrea

[PATCH] Add submenu support to 10_linux (grub-mkconfig)

2012-02-27 Thread Jordan Uggla
Below is a patch for adding submenu support to 10_linux (grub-mkconfig). This is *not* the patch which Ubuntu has been carying for submenu support and so I'd especially like feedback from Ubuntu folks. With GRUB_ENABLE_SUBMENUS=true in /etc/default/grub this patch will create a simple primary menu

Re: Freeze on 27 February

2012-02-27 Thread Richard Laager
On Mon, 2012-02-27 at 19:20 +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > I've rewritten this code. I've also committed most of your changes > except the one adding the tree scanning when we already have one Thanks. I'll catch up on this after my vacation and submit whatever updated patch

Re: Freeze on 27 February

2012-02-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 27.02.2012 07:01, Richard Laager wrote: On Mon, 2012-02-27 at 01:00 +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: The allowed characters are: [a-zA-Z0-9_.: -] This isn't a good enough argument. One could purposedly create a pool named `rm -rf /*` even though it's incorrect. By "allo

Re: Freeze on 27 February

2012-02-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 27.02.2012 07:04, Richard Laager wrote: On Mon, 2012-02-27 at 00:01 -0600, Richard Laager wrote: I haven't verified that the kernel itself refuses to create/load such a pool. In any case, what is the threat here? If someone hand-crafts such a pool, they still have to get the administrator to

Re: Freeze on 27 February

2012-02-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 27.02.2012 07:58, Richard Laager wrote: On Thu, 2012-02-23 at 07:34 +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: zfs-poolname-spaces.patch ... @@ -420,6 +419,9 @@ if (sscanf (sep, "%s %s", entry.fstype, entry.device) != 2) continue; + unescape (entry.fstype); +