default menuentry matching similar entries is broken

2012-03-02 Thread Seth Goldberg
Hi, This code in menu.c::menuentry_eq() looks wrong: { const char *ptr1, *ptr2; ptr1 = title; ptr2 = spec; while (1) { if (*ptr2 == '>' && ptr2[1] != '>' && *ptr1 == 0) return 1; if (*ptr2 == '>' && ptr2[1] != '>') return 0; if (*ptr2 == '>')

Re: [PATCH] Fix unused label/function warnings on NetBSD

2012-03-02 Thread Grégoire Sutre
On 03/02/2012 11:39 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 01.03.2012 17:25, Grégoire Sutre wrote: The attached patch fixes the following warnings when building GRUB on NetBSD (and probably other BSDs): util/getroot.c: In function 'grub_make_system_path_relative_to_its_root': util/

Re: [PATCH] Fix unused label/function warnings on NetBSD

2012-03-02 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 01.03.2012 17:25, Grégoire Sutre wrote: The attached patch fixes the following warnings when building GRUB on NetBSD (and probably other BSDs): util/getroot.c: In function 'grub_make_system_path_relative_to_its_root': util/getroot.c:2711:2: error: label 'parsedir' defined but not used util/ge