Re: [PATCH] Support Openfirmware disks with non-512B sectors

2013-01-22 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 22.01.2013 18:44, Paulo Flabiano Smorigo/Brazil/IBM wrote: > + grub_ieee1275_open (device, &dev_ihandle); Please don't open another handle. This can cause lockdown on some platforms. Use the already available framework. -- Regards Vladimir 'φ-coder/phcoder' Serbinenko signature.asc Descr

Re: [PATCH] Support Openfirmware disks with non-512B sectors

2013-01-22 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 22.01.2013 20:39, Seth Goldberg wrote: > > > Quoting Andrey Borzenkov, who wrote the following on Tue, 22 Jan 2013: > >> В Tue, 22 Jan 2013 11:04:19 -0800 (PST) >> Seth Goldberg пишет: >> >>> Hi, >>> >>>Why is this limited to OpenFirmware only? Can you generate a >>> patch that >>> sup

Re: [PATCH] Support Openfirmware disks with non-512B sectors

2013-01-22 Thread Seth Goldberg
Quoting Andrey Borzenkov, who wrote the following on Tue, 22 Jan 2013: В Tue, 22 Jan 2013 11:04:19 -0800 (PST) Seth Goldberg пишет: Hi, Why is this limited to OpenFirmware only? Can you generate a patch that supports 4KN disks on ALL platforms? It already supports 4K sector internal

Re: [PATCH] Support Openfirmware disks with non-512B sectors

2013-01-22 Thread Andrey Borzenkov
В Tue, 22 Jan 2013 11:04:19 -0800 (PST) Seth Goldberg пишет: > Hi, > >Why is this limited to OpenFirmware only? Can you generate a patch that > supports 4KN disks on ALL platforms? > It already supports 4K sector internally and queries disk sector size for SCSI, ATA and EFI (at least). B

Re: [PATCH] Support Openfirmware disks with non-512B sectors

2013-01-22 Thread Paulo Flabiano Smorigo/Brazil/IBM
Hi, You need a different approach for each platform. Afaik, grub already have support for some platforms: http://bzr.savannah.gnu.org/lh/grub/trunk/grub/revision/3325?start_revid=4682 Regards, -- Paulo Flabiano Smorigo Software Engineer Linux Technology Center - IBM Systems & Technology Gro

Re: [PATCH] Support Openfirmware disks with non-512B sectors

2013-01-22 Thread Seth Goldberg
Hi, Why is this limited to OpenFirmware only? Can you generate a patch that supports 4KN disks on ALL platforms? Thanks, --S Quoting Paulo Flabiano Smorigo/Brazil/IBM, who wrote the following on Tue,...: Hi all, This patch adds non-512B sectors disks support for Openfirmware (ieee1275

[PATCH] Display the sector size

2013-01-22 Thread Paulo Flabiano Smorigo/Brazil/IBM
Hi all, What about show the disk sector size with the disk info? -- Paulo Flabiano Smorigo Software Engineer Linux Technology Center - IBM Systems & Technology Group === modified file 'ChangeLog' --- ChangeLog 2013-01-22 17:54:34 + +++ ChangeLog 2013-01-22 17:59:00 + @@ -1,5 +1,10 @@ 20

[PATCH] Support Openfirmware disks with non-512B sectors

2013-01-22 Thread Paulo Flabiano Smorigo/Brazil/IBM
Hi all, This patch adds non-512B sectors disks support for Openfirmware (ieee1275). -- Paulo Flabiano Smorigo Software Engineer Linux Technology Center - IBM Systems & Technology Group === modified file 'ChangeLog' --- ChangeLog 2013-01-22 14:28:32 + +++ ChangeLog 2013-01-22 17:35:51 + @

Re: Command documentation policy

2013-01-22 Thread Colin Watson
On Tue, Jan 22, 2013 at 05:12:18PM +, Colin Watson wrote: > On Tue, Jan 22, 2013 at 05:08:51PM +0400, Andrey Borzenkov wrote: > > Quit a number of commands are not documented. Is it intentional > > (because they are not considered "user level API")? Should > > documentation for them go into gru

Re: Command documentation policy

2013-01-22 Thread Colin Watson
On Tue, Jan 22, 2013 at 05:08:51PM +0400, Andrey Borzenkov wrote: > Quit a number of commands are not documented. Is it intentional > (because they are not considered "user level API")? Should > documentation for them go into grub or grub-dev? I spent some time documenting the list of commands a w

[PATCH] change misleading comment about device.map in grub-install

2013-01-22 Thread Andrey Borzenkov
grub-install is not supposed to create device.map; change comment to avoid confusion. It was already considered a bug by users. Signed-off-by: Andrey Borzenkov --- ChangeLog|5 + util/grub-install.in |2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/Ch

Command documentation policy

2013-01-22 Thread Andrey Borzenkov
Quit a number of commands are not documented. Is it intentional (because they are not considered "user level API")? Should documentation for them go into grub or grub-dev? ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listi

Re: [PATCH] Document menuentry --id option

2013-01-22 Thread Andrey Borzenkov
В Mon, 21 Jan 2013 20:48:51 +0100 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 21.01.2013 15:44, Andrey Borzenkov wrote: > > > В Sun, 20 Jan 2013 23:51:46 +0100 > > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > > >>> @deffn Command menuentry @var{title} @ > >>> [@option{--class=clas