Re: [PATCH] Use _W64 to detect MinGW W64-32 instead of _FILE_OFFSET_BITS

2014-01-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 14.01.2014 04:05, Andrey Borzenkov wrote: +/* 32 bit on Mingw-w64 already redefines them if _FILE_OFFSET_BITS=64 */ Do you mean 64-bit ? signature.asc Description: OpenPGP digital signature ___ Grub-devel mailing list Grub-devel@gnu.org

Re: [PATCH] reintroduce BUILD_LDFLAGS for the cross-compile case

2014-01-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Go ahead. On 12.01.2014 13:11, Andrey Borzenkov wrote: This allows providing separate LDFLAGS for build and host environment, which are not necessary the same for cross-compile case. In particular, it allows building host programs statically to not depend on presence of libraries at run-time

Re: [PATCH] Ignore EPERM when modifying kern.geom.debugflags

2014-01-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
go ahead On 17.01.2014 03:55, Colin Watson wrote: Many tests fail when run as a non-root user on FreeBSD. The failures all amount to an inability to open files using grub_util_fd_open, because we cannot set the kern.geom.debugflags sysctl. This sysctl is indeed important to allow us to do

Re: [PATCH] Use _W64 to detect MinGW W64-32 instead of _FILE_OFFSET_BITS

2014-01-18 Thread Andrey Borzenkov
В Sat, 18 Jan 2014 16:22:21 +0100 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет: On 14.01.2014 04:05, Andrey Borzenkov wrote: +/* 32 bit on Mingw-w64 already redefines them if _FILE_OFFSET_BITS=64 */ Do you mean 64-bit ? No, I mean exactly 32 bit. 'Mingw w64 is project

Re: [PATCH] Use _W64 to detect MinGW W64-32 instead of _FILE_OFFSET_BITS

2014-01-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 18.01.2014 16:53, Andrey Borzenkov wrote: В Sat, 18 Jan 2014 16:22:21 +0100 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет: On 14.01.2014 04:05, Andrey Borzenkov wrote: +/* 32 bit on Mingw-w64 already redefines them if _FILE_OFFSET_BITS=64 */ Do you mean 64-bit ? No, I

[PATCH] Improve DejaVuSans detection

2014-01-18 Thread Andrey Borzenkov
Look also in /usr/share/fonts/truetype, it is installed in this path on openSUSE. Prefer DejaVuSansMono if found, on openSUSE DejaVuSans is proportional font. Add detected path name to summary output. --- configure.ac | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff

[PATCH v2] fix Mingw W64-32 cross compile failure due to printf redefinition in libintl.h

2014-01-18 Thread Andrey Borzenkov
In file included from util/misc.c:36:0: ./include/grub/emu/misc.h:56:1: error: 'libintl_printf' is an unrecognized format function type [-Werror=format=] char * EXPORT_FUNC(xasprintf) (const char *fmt, ...) __attribute__ ((format (printf, 1, 2))) WARN_UNUSED_RESULT; ^

[PATCH] add BUILD_EXEEXT support to fix make clean on Windows

2014-01-18 Thread Andrey Borzenkov
Add $(BUILD_EXEEXT) to ensure files are removed. Also add CLEANFILES where appropriate. --- Makefile.am | 16 Makefile.util.def | 2 +- configure.ac | 21 - grub-core/Makefile.am | 14 -- 4 files changed, 33 insertions(+),

Re: [PATCH v2] fix Mingw W64-32 cross compile failure due to printf redefinition in libintl.h

2014-01-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 18.01.2014 17:09, Andrey Borzenkov wrote: In file included from util/misc.c:36:0: ./include/grub/emu/misc.h:56:1: error: 'libintl_printf' is an unrecognized format function type [-Werror=format=] char * EXPORT_FUNC(xasprintf) (const char *fmt, ...) __attribute__ ((format (printf, 1,

Re: [PATCH] Improve DejaVuSans detection

2014-01-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 18.01.2014 16:58, Andrey Borzenkov wrote: Look also in /usr/share/fonts/truetype, it is installed in this path on openSUSE. Prefer DejaVuSansMono if found, on openSUSE DejaVuSans is proportional font. It's not right solution. Proportional fonts must be preffered for themes. Only terminal

[PATCH] add GRUB_WINDOWS_DLLS to make windowsdir to allow shipping runtime files

2014-01-18 Thread Andrey Borzenkov
Not all toolkits provide static libraries. This patch enables creation of self contained distribution that does not require pre-existing runtime libraries. Intended usage is export GRUB_EXTRA_DLLS=/path/to/liblzma.dll /path/to/libintl.dll make make windowszip As those libraries and locations are

[PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES

2014-01-18 Thread Andrey Borzenkov
MinGW native nm does not support ELF binaries. While on it, pass detected nm arguments instead of hardcoding them. --- grub-core/Makefile.am | 6 +++--- grub-core/genemuinit.sh | 9 + grub-core/genemuinitheader.sh | 9 + 3 files changed, 13 insertions(+), 11

Re: [PATCH] add BUILD_EXEEXT support to fix make clean on Windows

2014-01-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Go ahead. On 18.01.2014 17:20, Andrey Borzenkov wrote: Add $(BUILD_EXEEXT) to ensure files are removed. Also add CLEANFILES where appropriate. --- Makefile.am | 16 Makefile.util.def | 2 +- configure.ac | 21 -

Re: [PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES

2014-01-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 18.01.2014 17:27, Andrey Borzenkov wrote: While on it, pass detected nm arguments instead of hardcoding them. please make this part a separate patch. This would indicate that you support non-portable nm output which in this branch isn't the case. Why do you need it in the first place?

Re: [PATCH] Improve DejaVuSans detection

2014-01-18 Thread Andrey Borzenkov
В Sat, 18 Jan 2014 17:26:16 +0100 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет: On 18.01.2014 16:58, Andrey Borzenkov wrote: Look also in /usr/share/fonts/truetype, it is installed in this path on openSUSE. Prefer DejaVuSansMono if found, on openSUSE DejaVuSans is

Re: [PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES

2014-01-18 Thread Andrey Borzenkov
В Sat, 18 Jan 2014 17:55:38 +0100 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет: On 18.01.2014 17:27, Andrey Borzenkov wrote: While on it, pass detected nm arguments instead of hardcoding them. please make this part a separate patch. is it OK to commit without this part?

Re: conflicting types for 'grub_list_push' on MinGW (include loop)

2014-01-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 15.01.2014 19:14, Andrey Borzenkov wrote: + * Copyright (C) 2014 Free Software Foundation, Inc. please preserve copyright years when copying code around (just copying whole string and adding 2104 is fine) Otherwise, go ahead. signature.asc Description: OpenPGP digital signature

Re: conflicting types for 'grub_list_push' on MinGW (include loop)

2014-01-18 Thread SevenBits
On Jan 18, 2014, at 12:12 PM, Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com wrote: On 15.01.2014 19:14, Andrey Borzenkov wrote: + * Copyright (C) 2014 Free Software Foundation, Inc. please preserve copyright years when copying code around (just copying whole string and adding

Re: [PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES

2014-01-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 18.01.2014 18:12, Andrey Borzenkov wrote: В Sat, 18 Jan 2014 17:55:38 +0100 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет: On 18.01.2014 17:27, Andrey Borzenkov wrote: While on it, pass detected nm arguments instead of hardcoding them. please make this part a separate

Re: [PATCH] fix removal of {cpu,machine} links on mingw/msys

2014-01-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 28.12.2013 10:58, Andrey Borzenkov wrote: At least on Windows 2003 using ln -s dir1 dir2 in msys shell succeeds, but results in what looks like hard link. Subsequent rm -f dir2 (e.g. during second config.status invocation) fails. Check that we also can remove link to directory. Make it

Re: [PATCH] fix removal of {cpu,machine} links on mingw/msys

2014-01-18 Thread Andrey Borzenkov
В Sat, 18 Jan 2014 19:14:43 +0100 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет: On 28.12.2013 10:58, Andrey Borzenkov wrote: At least on Windows 2003 using ln -s dir1 dir2 in msys shell succeeds, but results in what looks like hard link. Subsequent rm -f dir2 (e.g. during

Re: [PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES

2014-01-18 Thread Andrey Borzenkov
В Sat, 18 Jan 2014 19:08:35 +0100 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет: On 18.01.2014 18:12, Andrey Borzenkov wrote: В Sat, 18 Jan 2014 17:55:38 +0100 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет: On 18.01.2014 17:27, Andrey Borzenkov wrote:

Re: [PATCH] fix removal of {cpu,machine} links on mingw/msys

2014-01-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 18.01.2014 19:32, Andrey Borzenkov wrote: В Sat, 18 Jan 2014 19:14:43 +0100 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет: On 28.12.2013 10:58, Andrey Borzenkov wrote: At least on Windows 2003 using ln -s dir1 dir2 in msys shell succeeds, but results in what looks like

Re: [PATCH v2] fix Mingw W64-32 cross compile failure due to printf redefinition in libintl.h

2014-01-18 Thread Andrey Borzenkov
В Sat, 18 Jan 2014 17:24:53 +0100 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет: On 18.01.2014 17:09, Andrey Borzenkov wrote: In file included from util/misc.c:36:0: ./include/grub/emu/misc.h:56:1: error: 'libintl_printf' is an unrecognized format function type

Re: [PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES

2014-01-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 18.01.2014 19:36, Andrey Borzenkov wrote: grub_emu_init.c: grub_emu_init.h genemuinit.sh $(MOD_FILES) Forgot to update this one? Otherwise go ahead. signature.asc Description: OpenPGP digital signature ___ Grub-devel mailing list

Re: [PATCH v2] fix Mingw W64-32 cross compile failure due to printf redefinition in libintl.h

2014-01-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 18.01.2014 20:02, Andrey Borzenkov wrote: +fw.write (f.read ().replace ((printf,f,a), (__printf__,f,a)).replace ((printf,f,a), (__printf__,f,a))) Why replace twice? signature.asc Description: OpenPGP digital signature ___ Grub-devel

Re: [PATCH v2] fix Mingw W64-32 cross compile failure due to printf redefinition in libintl.h

2014-01-18 Thread Andrey Borzenkov
В Sat, 18 Jan 2014 20:07:31 +0100 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет: On 18.01.2014 20:02, Andrey Borzenkov wrote: +fw.write (f.read ().replace ((printf,f,a), (__printf__,f,a)).replace ((printf,f,a), (__printf__,f,a))) Why replace twice? Somehow I

Re: [PATCH] add GRUB_WINDOWS_DLLS to make windowsdir to allow shipping runtime files

2014-01-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 18.01.2014 17:26, Andrey Borzenkov wrote: export GRUB_EXTRA_DLLS=/path/to/liblzma.dll /path/to/libintl.dll make make windowszip Perhaps a better name to indicate that you could use it to add any extra files to zip. Perhaps GRUB_WINDOWS_EXTRA_DIST ? signature.asc Description: OpenPGP

Re: [PATCH] add GRUB_WINDOWS_DLLS to make windowsdir to allow shipping runtime files

2014-01-18 Thread Andrey Borzenkov
В Sun, 19 Jan 2014 02:23:41 +0100 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет: On 18.01.2014 17:26, Andrey Borzenkov wrote: export GRUB_EXTRA_DLLS=/path/to/liblzma.dll /path/to/libintl.dll make make windowszip Perhaps a better name to indicate that you could use it to