Re: grub-mkrescue problems in argp_parse

2015-05-07 Thread Thomas Schmitt
Hi, > Folks, I really suggest to bite the bullet and switch to argp. I already gave in to your reasoning for the better CLI. :)) But since Vladimir is not yet annoyed enough by the consequences of the grub-mkrescue CLI, i provide my part of our cooperation. (I am with Vladimir that grub-mkrescu

Re: grub-mkrescue problems in argp_parse

2015-05-07 Thread Thomas Schmitt
Hi, > Can we have --grub* space? No hard collision to see in the man pages of xorriso and xorrisofs. Except the word "grub" with command -boot_image, there are only some--grub2-* options of -as mkisofs: --grub2-boot-info --grub2-mbr --grub2-sparc-core All three are supposed to be under co

Re: [edk2] [PATCH 2/2] efinet: fix lost packets due to active MNP instances

2015-05-07 Thread Andrei Borzenkov
В Wed, 29 Apr 2015 15:47:44 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 25.04.2015 16:12, Andrei Borzenkov wrote: > > --- > > grub-core/net/drivers/efi/efinet.c | 101 > > - > > 1 file changed, 99 insertions(+), 2 deletions(-) > > > > diff --git

Re: grub-mkrescue problems in argp_parse

2015-05-07 Thread Andrei Borzenkov
В Thu, 07 May 2015 16:40:29 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > Used in old mkisofs. > > "Do not add trailing dot to ISO file names without dot." > > An alias is available: -omit-period > > > Or user can use --d > >> In future we can make a rule to add only options starting wi

Re: [PATCH 2/5] i386/relocator: Remove unused extern grub_relocator64_rip_addr

2015-05-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Committed, thanks. signature.asc Description: OpenPGP digital signature ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: passing options to grub in xen,openfirmware and efi

2015-05-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 07.05.2015 17:03, Andrei Borzenkov wrote: > On Thu, May 7, 2015 at 5:59 PM, Vladimir 'φ-coder/phcoder' Serbinenko > wrote: >> On 07.05.2015 16:54, Olaf Hering wrote: >>> On Thu, May 07, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >>> > Sigh.. > There are likely ways to find out wh

Re: passing options to grub in xen,openfirmware and efi

2015-05-07 Thread Andrei Borzenkov
On Thu, May 7, 2015 at 5:59 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 07.05.2015 16:54, Olaf Hering wrote: >> On Thu, May 07, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> >>> Sigh.. There are likely ways to find out where grub was loaded from even on a PC, and use tha

Re: DNS endianness

2015-05-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
It's purely code aesthetics but go ahead. Andrei Borzenkov wrote: > This does not sound right ... > > static grub_err_t > recv_hook (grub_net_udp_socket_t sock __attribute__ ((unused)), >struct grub_net_buff *nb, >void *data_) > { > ... > head = (struct dns_header *) nb->

Re: passing options to grub in xen,openfirmware and efi

2015-05-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 07.05.2015 16:54, Olaf Hering wrote: > On Thu, May 07, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > >> >>> Sigh.. >>> There are likely ways to find out where grub was loaded from even on a >>> PC, and use that as initial root=. In a PV guest no such thing exists >>> because itself grub is the

Re: [PATCH v2] F2FS support

2015-05-07 Thread Andrei Borzenkov
On Thu, May 7, 2015 at 5:51 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > >> grub_uint8_t *addr; >> >> byte = nr >> 3; >> #ifdef WORDS_BIGENDIAN > #ifdef GRUB_CPU_WORDS_BIGENDIAN actually It is not needed at all. on-disk format is fixed and little endian. Sorry for confusion. __

Re: passing options to grub in xen,openfirmware and efi

2015-05-07 Thread Olaf Hering
On Thu, May 07, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > > > Sigh.. > > There are likely ways to find out where grub was loaded from even on a > > PC, and use that as initial root=. In a PV guest no such thing exists > > because itself grub is the firmware. > grub-install already takes this

Re: [PATCH 1/2] efidisk: move device path helpers in core for efinet

2015-05-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Go ahead On 19.04.2015 10:01, Andrei Borzenkov wrote: > --- > grub-core/disk/efi/efidisk.c | 61 > > grub-core/kern/efi/efi.c | 41 + > include/grub/efi/efi.h | 4 +++ > 3 files changed, 55 insertions(+), 51 delet

Re: [PATCH v2] F2FS support

2015-05-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
> grub_uint8_t *addr; > > byte = nr >> 3; > #ifdef WORDS_BIGENDIAN #ifdef GRUB_CPU_WORDS_BIGENDIAN actually Also in general it's very good idea to check on big-endian machines. We don't add __ prefix to function names. signature.asc Description: OpenPGP digital signature

Re: passing options to grub in xen,openfirmware and efi

2015-05-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
> Sigh.. > There are likely ways to find out where grub was loaded from even on a > PC, and use that as initial root=. In a PV guest no such thing exists > because itself grub is the firmware. grub-install already takes this into account. > In OF I can imaging that it might > be useful to point g

Re: grub-mkrescue problems in argp_parse

2015-05-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
> Used in old mkisofs. > "Do not add trailing dot to ISO file names without dot." > An alias is available: -omit-period > Or user can use --d >> In future we can make a rule to add only options starting with --. > > This will not really create clarity because i already added > options with "--" t

Re: Using memdisk with grub2 and a gzip-compressed ISO

2015-05-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Go ahead On 29.04.2015 19:45, Andrei Borzenkov wrote: > В Thu, 23 Apr 2015 10:23:09 -0400 > David Shaw пишет: > >> >> When booting the box with grub2 2.02, it does not work. The error is: >> >> Ramdisk at 0x37979000, length 0x0033b290 >> gzip image: decompressed addr 0xbfff7000, len 0x8f

Re: [PATCH 4/5] arm64: Add multiboot support file

2015-05-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 18.12.2014 19:12, Fu Wei wrote: > grub-core/loader/arm64/multiboot.c > include/grub/arm64/multiboot.h > > Add commands register code and hearder file into > grub-core/loader/arm64/linux.c > > - This multiboot support is built into linux module for aarch64. > > - The implementation fo

Re: [PATCH 3/5] arm64: Remove "loaded" checking in the grub_cmd_devicetree of linux.c

2015-05-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 18.12.2014 19:06, Fu Wei wrote: >Reason: (1)we don't need the check, actually >(2)it is a prerequisite for multiboot support > That one is problematic. Normally execution of any kernel-loading commands like linux resets the boot context. Exceptions are drivemap, sendkey,

Re: [PATCH 2/5] arm64: Move some #define from

2015-05-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 18.12.2014 19:04, Fu Wei wrote: > grub-core/loader/arm64/linux.c to include/grub/arm64/linux.h Reason: > (1)make code more orderly (2)these #define can be used by other files which > includs include/grub/arm64/linux.h > (1): We keep defines in C file if they're used only in one file. B

Re: Attempting to install GRUB to a disk with multiple partition labels or both partition label and filesystem.

2015-05-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 03.05.2015 10:21, Andrei Borzenkov wrote: > Could someone explain why this message is output here? It is absolutely > not what condition checks for > > if (ctx.container > && grub_strcmp (ctx.container->partmap->name, "msdos") == 0 > && ctx.dest_partmap > && (ctx.con

Re: Future of installing GRUB to LVM volumes (and loop devices)

2015-05-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
> Nevertheless, let's get good old > > grub-install --boot-directory=... /dev/... > > fixed, please. It did work previously. How do we proceed? > grub tools assume that notion of what's "physical" remains unchanged between install and boot unless specified otherwise in device.map. This assu

Re: [PATCH 3/5] zfs com.delphix:hole_birth feature support

2015-05-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Thank you Toomas for patch and Andrey for reviews. On 03.05.2015 17:15, Andrei Borzenkov wrote: > В Sun, 19 Apr 2015 17:57:04 +0300 > Toomas Soome пишет: > >> >>> On 19.04.2015, at 17:51, Andrei Borzenkov wrote: >>> >>> В Sun, 19 Apr 2015 17:40:16 +0300 >>> Toomas Soome пишет: >>> the

Re: [PATCH] zfs module update

2015-05-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 14.04.2015 06:34, Andrei Borzenkov wrote: > В Tue, 14 Apr 2015 02:17:43 +0300 > Toomas Soome пишет: > >> hi! >> >> this is the major update to grub2 zfs module; the work is based on Oracle >> code drops from Solaris 11, and Illumos. > > IANAL but I suspect such changes require at least submi