Re: multiboot_mmap_entry.zero isn't zero

2016-02-14 Thread Wink Saville
I'm using multiboot2 and I see a zero field in grub/include/multiboot2.h: struct multiboot_mmap_entry { multiboot_uint64_t addr; multiboot_uint64_t len; #define MULTIBOOT_MEMORY_AVAILABLE 1 #define MULTIBOOT_MEMORY_RESERVED 2 #define MULTIBOOT_MEMORY_ACPI_RECLAIMABLE 3 #define MULTIBOOT_

Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg

2016-02-14 Thread Shea Levy
This patch uses grub_file_open, but the android bootimg is a disk, not a file. You mentioned something about file_offset_open, but that also expects an input file, not a disk. Should I modify your patch with my code I wrote to create a grub_file_t from an android_bootimg disk device, or is ther

Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg

2016-02-14 Thread Vladimir 'phcoder' Serbinenko
Le dim. 14 févr. 2016 14:21, Shea Levy a écrit : > This patch uses grub_file_open, but the android bootimg is a disk, not > a file. You mentioned something about file_offset_open, but that also > expects an input file, not a disk. Should I modify your patch with my > code I wrote to create a grub

Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg

2016-02-14 Thread Andrei Borzenkov
14.02.2016 16:26, Vladimir 'phcoder' Serbinenko пишет: > Le dim. 14 févr. 2016 14:21, Shea Levy a écrit : > >> This patch uses grub_file_open, but the android bootimg is a disk, not >> a file. You mentioned something about file_offset_open, but that also >> expects an input file, not a disk. Shou

Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg

2016-02-14 Thread Seth Goldberg
> On Feb 14, 2016, at 5:26 AM, Vladimir 'phcoder' Serbinenko > wrote: > > > > Le dim. 14 févr. 2016 14:21, Shea Levy a écrit : >> This patch uses grub_file_open, but the android bootimg is a disk, not >> a file. You mentioned something about file_offset_open, but that also >> expects an inp

Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg

2016-02-14 Thread Andrei Borzenkov
14.02.2016 23:58, Seth Goldberg пишет: > > >> On Feb 14, 2016, at 5:26 AM, Vladimir 'phcoder' Serbinenko >> wrote: >> >> >> >> Le dim. 14 févr. 2016 14:21, Shea Levy a écrit >> : >>> This patch uses grub_file_open, but the android bootimg is a >>> disk, not a file. You mentioned something ab

Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg

2016-02-14 Thread Seth Goldberg
> On Feb 14, 2016, at 7:41 PM, Andrei Borzenkov wrote: > > 14.02.2016 23:58, Seth Goldberg пишет: >> >> >>> On Feb 14, 2016, at 5:26 AM, Vladimir 'phcoder' Serbinenko >>> wrote: >>> >>> >>> >>> Le dim. 14 févr. 2016 14:21, Shea Levy a écrit >>> : This patch uses grub_file_open, but

Re: [PATCH 10/14] dns: poll card between each dns request

2016-02-14 Thread Andrei Borzenkov
On Thu, Feb 11, 2016 at 12:21 AM, Josef Bacik wrote: > If we have dns servers that we prefer to get records from we'll send a > packet and immediately check data.naddresses to see if we got a response. If > we > didn't we'll then send a request for an A record, and _then_ we'll poll the > c