[PATCH] fix attempt to seek outside of the file error when parsing xen ELF notes

2016-03-02 Thread Michael Chang
The kernel bzImage payload length appears to be incorrectly minus by 4 when trying to grub_file_offset_open for the uncompressed vmlinux image. If gzip used as compressor it will lead to the file->size read from offset of crc32 instead of the uncompressed image size. [1] http://www.onicos.com/staf

Re: [PATCH v5 2/2] Add a module for retrieving SMBIOS information

2016-03-02 Thread David Michael
On Wed, Mar 2, 2016 at 2:08 PM, Andrei Borzenkov wrote: > Two nitpicks otherwise looks good. Thanks! Thanks for reviewing these again. I agree with your suggestions, but do they warrant another updated patch, or can those changes just be squashed onto this commit? Also, since sending this, Leif

RE: [PATCH v2 3/3] disk: read into cache directly

2016-03-02 Thread Elliott, Robert (Persistent Memory)
> -Original Message- > From: grub-devel-bounces+elliott=hp@gnu.org [mailto:grub-devel- > bounces+elliott=hp@gnu.org] On Behalf Of Leif Lindholm > Sent: Tuesday, March 01, 2016 6:14 PM > To: grub-devel@gnu.org > Subject: [PATCH v2 3/3] disk: read into cache directly > > From: Andr

Re: [2.02] Re: [f2fs-dev] [PATCH v7] F2FS support

2016-03-02 Thread Michael Zimmermann
I found a bug in the 'grub_f2fs_read_file' function. It fails when the file position is not 0. to fix it: - grub_memcpy (buf + pos, inline_addr + pos, len); + grub_memcpy (buf, inline_addr + pos, len); Michael On Tue, Mar 1, 2016 at 8:52 PM, Andrei Borzenkov wrote: > ACK from my side

Re: Bugs and tasks for 2.02[~rc1]

2016-03-02 Thread Daniel Kiper
Hey, On Wed, Mar 02, 2016 at 03:01:03PM +, Vladimir 'phcoder' Serbinenko wrote: > Hello, all. I went through the list of bugs and created a shortlist of bugs > that need to be looked at for 2.02. I have marked them with plan_release_id > set to 2.02. > Statistics: [1] > Search (with loads of f

[2.02] Re: [PATCH v5 1/2] Define the SMBIOS3 entry point structure on EFI

2016-03-02 Thread Andrei Borzenkov
29.02.2016 15:36, David Michael пишет: > On Sat, Feb 20, 2016 at 2:12 PM, David Michael wrote: >> This adds the GUID and includes it in the lsefisystab module. > > Pinging to check if these two can make it into 2.02. Fine from my side. > > Side note: I was trying a CoreOS snapshot the other d

[GRUB2 PATCH v3 4/4] multiboot2: Add support for relocatable images

2016-03-02 Thread Daniel Kiper
Currently multiboot2 protocol loads image exactly at address specified in ELF or multiboot2 header. This solution works quite well on legacy BIOS platforms. It is possible because memory regions are placed at predictable addresses (though I was not able to find any spec which says that it is strong

[GRUB2 PATCH v3 1/4] i386/relocator: Add grub_relocator64_efi relocator

2016-03-02 Thread Daniel Kiper
Add grub_relocator64_efi relocator. It will be used on EFI 64-bit platforms when multiboot2 compatible image requests MULTIBOOT_TAG_TYPE_EFI_BS. Relocator will set lower parts of %rax and %rbx accordingly to multiboot2 specification. On the other hand processor mode, just before jumping into loaded

[GRUB2 PATCH v3 0/4] multiboot2: Add two extensions

2016-03-02 Thread Daniel Kiper
Hi, This patch series: - enables EFI boot services usage in loaded images by multiboot2 protocol, - add support for multiboot2 protocol compatible relocatable images. Earlier versions of this patch series are extensively tested and used internally at least in Oracle. It should be ment

[GRUB2 PATCH v3 3/4] multiboot2: Do not pass memory maps to image if EFI boot services are enabled

2016-03-02 Thread Daniel Kiper
Do not pass memory maps to image if it asked for EFI boot services. Main reason for not providing maps is because they will likely be invalid. We do a few allocations after filling them, e.g. for relocator needs. Usually we do not care as we would already finish boot services. If we keep boot servi

[GRUB2 PATCH v3 2/4] multiboot2: Add tags used to pass ImageHandle to loaded image

2016-03-02 Thread Daniel Kiper
Add tags used to pass ImageHandle to loaded image if requested. It is used by at least ExitBootServices() function. Signed-off-by: Daniel Kiper --- v3 - suggestions/fixes: - mbi EFI related stuff size calculation should depend on target architecture (suggested by Konrad Rzeszutek Wil

Re: [PATCH v5 2/2] Add a module for retrieving SMBIOS information

2016-03-02 Thread Andrei Borzenkov
Two nitpicks otherwise looks good. Thanks! 20.02.2016 22:12, David Michael пишет: ... > diff --git a/grub-core/commands/smbios.c b/grub-core/commands/smbios.c > new file mode 100644 > index 000..80a01a3 > --- /dev/null > +++ b/grub-core/commands/smbios.c > @@ -0,0 +1,364 @@ > +/* smbios.c - r

Load arm-efi from within U-Boot

2016-03-02 Thread Andrei Borzenkov
Interesting idea. It seems to be actually used by openSUSE ARM maintainers. http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/253414 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v4 10/11] xen: modify page table construction

2016-03-02 Thread Daniel Kiper
On Wed, Mar 02, 2016 at 04:43:07PM +0100, Juergen Gross wrote: > On 02/03/16 10:12, Daniel Kiper wrote: > > On Mon, Feb 29, 2016 at 01:19:27PM +0100, Juergen Gross wrote: > >> On 29/02/16 10:13, Juergen Gross wrote: > >>> On 25/02/16 19:33, Andrei Borzenkov wrote: > 22.02.2016 16:14, Juergen G

Re: [PATCH v4 10/11] xen: modify page table construction

2016-03-02 Thread Juergen Gross
On 02/03/16 10:12, Daniel Kiper wrote: > On Mon, Feb 29, 2016 at 01:19:27PM +0100, Juergen Gross wrote: >> On 29/02/16 10:13, Juergen Gross wrote: >>> On 25/02/16 19:33, Andrei Borzenkov wrote: 22.02.2016 16:14, Juergen Gross пишет: > On 22/02/16 13:48, Daniel Kiper wrote: >> On Mon, F

Re: 2.02~beta3 release

2016-03-02 Thread Vladimir 'phcoder' Serbinenko
> > onsider files > > http://alpha.gnu.org/gnu/grub/grub-2.02~beta3.tar.xz > > and signature at > > http://alpha.gnu.org/gnu/grub/grub-2.02~beta3.tar.xz.sig > > Thanks, this is a great step. What is the timeline we're planning to > follow? > > I started a separate thread to collect pending tasks.

Bugs and tasks for 2.02[~rc1]

2016-03-02 Thread Vladimir 'phcoder' Serbinenko
Hello, all. I went through the list of bugs and created a shortlist of bugs that need to be looked at for 2.02. I have marked them with plan_release_id set to 2.02. Statistics: [1] Search (with loads of false positives unfortunately): [2] Not every bug there is a release blocker, for some of them i

Re: [PATCH v2 2/3] efidisk: implement alignment-respecting malloc function

2016-03-02 Thread Leif Lindholm
On Wed, Mar 02, 2016 at 06:46:52AM +0300, Andrei Borzenkov wrote: > 02.03.2016 03:14, Leif Lindholm пишет: > > Implement a driver-specific malloc function that allocates a buffer > > with the alignment specified by grub_efi_block_io_media structure. > > --- > > grub-core/disk/efi/efidisk.c | 8 +++

Re: 2.02~beta3 release

2016-03-02 Thread Vladimir 'phcoder' Serbinenko
Fixed. Thank you for reporting Le Tue, Mar 1, 2016 à 11:14 AM, Vladimir 'phcoder' Serbinenko < phco...@gmail.com> a écrit : > My mistake. I'm going to fix it > > Le mar. 1 mars 2016 20:10, Andrei Borzenkov a > écrit : > >> 29.02.2016 11:16, Vladimir 'phcoder' Serbinenko пишет: >> > On Sunday, Fe

Re: [PATCH v2 3/3] disk: read into cache directly

2016-03-02 Thread Vladimir 'phcoder' Serbinenko
Le Wed, Mar 2, 2016 à 4:46 AM, Andrei Borzenkov a écrit : > 02.03.2016 03:22, Vladimir 'phcoder' Serbinenko пишет: > > Is there any way this patch reclaims unused memory in case of partial > cache > > eviction? > > Not yet, I wanted to make sure base looks sane first. Are there any > cases of par

Re: [PATCH v6 09/11] xen: add capability to load initrd outside of initial mapping

2016-03-02 Thread Daniel Kiper
On Wed, Mar 02, 2016 at 09:14:23AM +0100, Juergen Gross wrote: > On 02/03/16 08:56, Daniel Kiper wrote: > > On Tue, Mar 01, 2016 at 08:55:09AM +0100, Juergen Gross wrote: > >> Modern pvops linux kernels support an initrd not covered by the initial > >> mapping. This capability is flagged by an elf-

Re: [PATCH v4 10/11] xen: modify page table construction

2016-03-02 Thread Daniel Kiper
On Mon, Feb 29, 2016 at 01:19:27PM +0100, Juergen Gross wrote: > On 29/02/16 10:13, Juergen Gross wrote: > > On 25/02/16 19:33, Andrei Borzenkov wrote: > >> 22.02.2016 16:14, Juergen Gross пишет: > >>> On 22/02/16 13:48, Daniel Kiper wrote: > On Mon, Feb 22, 2016 at 01:30:30PM +0100, Juergen G

Re: [PATCH v6 09/11] xen: add capability to load initrd outside of initial mapping

2016-03-02 Thread Juergen Gross
On 02/03/16 08:56, Daniel Kiper wrote: > On Tue, Mar 01, 2016 at 08:55:09AM +0100, Juergen Gross wrote: >> Modern pvops linux kernels support an initrd not covered by the initial >> mapping. This capability is flagged by an elf-note. >> >> In case the elf-note is set by the kernel don't place the i