Re: [PATCH v2] grub-file: fix segmentation fault

2016-11-22 Thread Michael Chang
On Tue, Nov 22, 2016 at 09:39:43PM +0300, Andrei Borzenkov wrote: > 22.11.2016 10:10, Michael Chang пишет: > > What about attached patch? It does not increase size of kernel. Just some nitpicks in comments and a potential leak in fail path (See below), otherwise LGTM. > > I am not thrilled as i

Re: [PATCH] disk/mdraid1x: Fix >2TB RAID detection with BIOS

2016-11-22 Thread Robert LeBlanc
Andrei, I sent a VM that displays the problem. It bounced from the listserv (I kind of expected that), but should have been sent to your email directly as well. For my own curiosity are you against the patch I submitted? I understand that you are trying to figure out why the sectors can't be acce

Re: [PATCH v2] grub-file: fix segmentation fault

2016-11-22 Thread Andrei Borzenkov
22.11.2016 10:10, Michael Chang пишет: > On Fri, Nov 18, 2016 at 11:50:25AM +0300, Andrei Borzenkov wrote: >> Hmm ... I must admit I am confused how we can get NULL here. Filters >> are called after primary file->name is set and each filter copies >> previous struct file, which means returned file

Re: [2.02][PATCH] bootp: export server IP as environment variable

2016-11-22 Thread Daniel Kiper
On Tue, Nov 22, 2016 at 08:21:12PM +0300, Andrei Borzenkov wrote: > 22.11.2016 01:02, Daniel Kiper ??: > > On Mon, Nov 21, 2016 at 10:52:24PM +0300, Andrei Borzenkov wrote: > >> 21.11.2016 16:09, Daniel Kiper ??: > >>> On Fri, Nov 18, 2016 at 09:11:47PM +0300, Andrei Borzenkov wrote

Re: powerpc-ieee1275 and grub-mkfont dependency

2016-11-22 Thread Daniel Kiper
On Tue, Nov 22, 2016 at 08:37:56PM +0300, Andrei Borzenkov wrote: > 22.11.2016 12:00, Daniel Kiper ??: > > On Tue, Nov 15, 2016 at 11:44:16AM +0100, Daniel Kiper wrote: > >> On Tue, Nov 15, 2016 at 06:45:58AM +0300, Andrei Borzenkov wrote: > >>> 15.11.2016 01:13, Aaro Koskinen ??: >

Re: powerpc-ieee1275 and grub-mkfont dependency

2016-11-22 Thread Andrei Borzenkov
22.11.2016 12:00, Daniel Kiper пишет: > On Tue, Nov 15, 2016 at 11:44:16AM +0100, Daniel Kiper wrote: >> On Tue, Nov 15, 2016 at 06:45:58AM +0300, Andrei Borzenkov wrote: >>> 15.11.2016 01:13, Aaro Koskinen ??: Hi, On Thu, Nov 10, 2016 at 04:53:23PM +0300, Andrei Borzenkov wr

Re: [2.02][PATCH] bootp: export server IP as environment variable

2016-11-22 Thread Andrei Borzenkov
22.11.2016 01:02, Daniel Kiper пишет: > On Mon, Nov 21, 2016 at 10:52:24PM +0300, Andrei Borzenkov wrote: >> 21.11.2016 16:09, Daniel Kiper ??: >>> On Fri, Nov 18, 2016 at 09:11:47PM +0300, Andrei Borzenkov wrote: 17.11.2016 22:02, Daniel Kiper ??: > On Fri, Mar 18, 2016 at

Re: [PATCH 2/2] ofnet: implement a receive buffer

2016-11-22 Thread Stanislav Kholmanskikh
On 11/22/2016 12:48 AM, Daniel Kiper wrote: > On Fri, Nov 18, 2016 at 04:29:24PM +0300, Stanislav Kholmanskikh wrote: >> On 11/16/2016 01:34 AM, Daniel Kiper wrote: >>> On Tue, Apr 12, 2016 at 03:39:56PM +0300, Stanislav Kholmanskikh wrote: get_card_packet() from ofnet.c allocates a netbuff

Re: [PATCH v2] bootp: add native DHCPv4 support

2016-11-22 Thread Daniel Kiper
On Fri, Nov 18, 2016 at 08:51:43PM +0300, Andrei Borzenkov wrote: > 17.11.2016 22:06, Daniel Kiper ??: > > On Wed, Apr 27, 2016 at 04:34:19PM +0100, Mark Rutland wrote: > >> Hi, > >> > >> On Tue, Mar 22, 2016 at 09:26:20PM +0300, Andrei Borzenkov wrote: > >>> This patch adds support for nat

Re: powerpc-ieee1275 and grub-mkfont dependency

2016-11-22 Thread Daniel Kiper
On Tue, Nov 15, 2016 at 11:44:16AM +0100, Daniel Kiper wrote: > On Tue, Nov 15, 2016 at 06:45:58AM +0300, Andrei Borzenkov wrote: > > 15.11.2016 01:13, Aaro Koskinen ??: > > > Hi, > > > > > > On Thu, Nov 10, 2016 at 04:53:23PM +0300, Andrei Borzenkov wrote: > > >> I do not like it, sorry. I

Re: [PATCH] verify: search keyid in hashed signature subpackets (repost)

2016-11-22 Thread Daniel Kiper
On Mon, Nov 21, 2016 at 11:31:26PM +0100, Ignat Korchagin wrote: > On Mon, Nov 21, 2016 at 6:56 PM, Jon McCune wrote: > > On Mon, Nov 21, 2016 at 6:45 AM, Daniel Kiper wrote: > >> > >> On Fri, Nov 18, 2016 at 12:00:08PM +, Ignat Korchagin wrote: > >> > Reposting this, as requested by Daniel a

Re: [PATCH] verify: search keyid in hashed signature subpackets (repost)

2016-11-22 Thread Daniel Kiper
On Mon, Nov 21, 2016 at 11:25:30PM +0100, Ignat Korchagin wrote: > On Mon, Nov 21, 2016 at 3:45 PM, Daniel Kiper wrote: > > On Fri, Nov 18, 2016 at 12:00:08PM +, Ignat Korchagin wrote: > >> Reposting this, as requested by Daniel and rebasing on current tree. > >> > >> Currently GRUB2 verify lo