Re: [PATCH] btrfs: avoid "used uninitialized" error with GCC7

2017-04-03 Thread Vladimir 'phcoder' Serbinenko
On Fri, Mar 31, 2017, 06:43 Andrei Borzenkov wrote: > sblock was local and so considered new variable on every loop > iteration. > > While on it, dynamically allocate buffer to reduce stack usage. > Looks good. Did you check all instances sizeof, so we don't have sizeof of pointer? Did you check

Re: [PATCH] i386, x86_64, ppc: fix switch fallthrough cases with GCC7

2017-04-03 Thread Vladimir 'phcoder' Serbinenko
Go ahead On Fri, Mar 31, 2017, 06:41 Andrei Borzenkov wrote: > In util/getroot and efidisk slightly modify exitsing comment to mostly > retain it but still make GCC7 compliant with respect to fall through > annotation. > > In grub-core/lib/xzembed/xz_dec_lzma2.c it adds same comments as > upstre

Re: Please add better line editing

2017-04-03 Thread Vladimir 'phcoder' Serbinenko
On Sun, Apr 2, 2017, 19:48 Michael Zimmermann wrote: > are you booting grub in BIOS or UEFI mode? GRUB in BIOS mode is > usually pretty slow because it constantly has to switch between real > and protected mode. Not an issue. > In UEFI, GRUB is running at full speed. > Doesn't matter. Most comm

Re: [wea...@debian.org: Bug#858832: calls efibootmgr with invalid options]

2017-04-03 Thread Steve McIntyre
On Tue, Mar 28, 2017 at 08:59:30PM +0300, Andrei Borzenkov wrote: >28.03.2017 09:34, Peter Palfrader пишет: >> } /dev/md2953M 176K 953M 1% /boot/efi > >Sorry, that's not going to work. Even assuming that grub can map from >Linux MD to underlying physical device + partition (as that is w

Patch to support ESP redundancy [was: Re: [wea...@debian.org: Bug#858832: calls efibootmgr with invalid options]]

2017-04-03 Thread Francesco Poli
On Tue, 28 Mar 2017 20:59:30 +0300 Andrei Borzenkov wrote: [...] > The (IMHO) correct way to handle ESP redundancy is to call "grub-install > /path/to/first/ESP /path/to/second/ESP". I have half-finished patch > allowing this, but it will need distributions cooperation to actually be > useful. He