Re: [PATCH 1/7] Cryptomount support LUKS detached header

On 14/03/18 13:05, Daniel Kiper wrote: > On Wed, Mar 14, 2018 at 09:44:58AM +, John Lane wrote: >> From: John Lane > > I have just skimmed through the series. First of all, most if not > all patches beg for full blown commit messages. Just vague statements > in the subject are insufficient fo

[PATCH] ieee1275: NULL pointer dereference in grub_machine_get_bootlocation

Read from NULL pointer canon in function grub_machine_get_bootlocation. Function grub_ieee1275_canonicalise_devname may return NULL. Signed-off-by: Eric Snowberg --- grub-core/kern/ieee1275/init.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/grub-core/kern/ieee1275/i

Re: [PATCH] os-prober: Fix translating device to mach format

Hello, Daniel Kiper, on mer. 14 mars 2018 13:58:51 +0100, wrote: > On Sun, Mar 11, 2018 at 09:58:20PM +0100, Samuel Thibault wrote: > > "hostdisk//dev/sda,msdos1", i.e. not something we can translate. We can > > Are you sure that this happens upstream? It happens with plain build from git yes.

[PATCHv2] os-prober: Fix translating device to mach format

grub-probe --device /dev/sda --target=drive would currently print on Linux x86 "hostdisk//dev/sda,msdos1", i.e. not something we can translate easily. We can instead use compatibility_hint which have more well-defined format (hd0,1) Signed-off-by: Samuel Thibault --- new in v2: Fix typo and b

Re: [PATCH 1/7] Cryptomount support LUKS detached header

On Wed, Mar 14, 2018 at 09:44:58AM +, John Lane wrote: > From: John Lane I have just skimmed through the series. First of all, most if not all patches beg for full blown commit messages. Just vague statements in the subject are insufficient for me. And please add patch 0 which introduces the

Re: [PATCH] os-prober: Fix translating device to mach format

On Sun, Mar 11, 2018 at 09:58:20PM +0100, Samuel Thibault wrote: > grub-probe would currently would currently print e.g. s/would currently would currently/would currently/? > "hostdisk//dev/sda,msdos1", i.e. not something we can translate. We can Are you sure that this happens upstream? On whic

Re: Grub website issues

Hi Samuel, On Sun, Mar 11, 2018 at 09:56:57PM +0100, Samuel Thibault wrote: > Hello, > > There are a few issues on the grub website on > https://www.gnu.org/software/grub/grub-development.html > > The page says it is maintained by Bruce Dubbs > but he told me he doesn't have access to the site an

Re: [PATCH V2] ieee1275: split up grub_machine_get_bootlocation

On Thu, Mar 08, 2018 at 08:42:22PM -0800, Eric Snowberg wrote: > Split up some of the functionality in grub_machine_get_bootlocation into > grub_ieee1275_get_boot_dev. This will allow for code reuse in a follow on > patch. > > Signed-off-by: Eric Snowberg Reviewed and applied. Please next time i

Is the IP-stuff is available in the GRUB2 in EFI mode only ?

Is the IP-stuff is available in the GRUB2 in EFI mode only ?13.03.2018, 16:12, "Ruslan R. Laishev" :Hi There! I developing a my own custom module to be used in the GRUB2 ...This module is use UDP to talk with a remote server. So I have checked grub-core/net and try to use a next initialization sequ

[PATCH 3/7] cryptomount luks allow multiple passphrase attempts

From: John Lane --- grub-core/disk/luks.c | 278 ++ 1 file changed, 143 insertions(+), 135 deletions(-) diff --git a/grub-core/disk/luks.c b/grub-core/disk/luks.c index 588236888..11e437edb 100644 --- a/grub-core/disk/luks.c +++ b/grub-core/disk/l

[PATCH 4/7] Cryptomount support plain dm-crypt

From: John Lane Patch modified to take into account a change to context brought about by c93d3e694713b8230fa2cf88414fabe005b56782 grub-core/disk/cryptodisk.c 142c142 --- grub-core/disk/cryptodisk.c | 298 +++- grub-core/disk/l

[PATCH 7/7] Add support for using a whole device as a keyfile

From: Paul Gideon Dann --- grub-core/disk/cryptodisk.c | 86 +++-- 1 file changed, 68 insertions(+), 18 deletions(-) diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c index 6fc2c23aa..a8937e5e3 100644 --- a/grub-core/disk/cryptodisk.c

[PATCH 5/7] Cryptomount support for hyphens in UUID

From: John Lane --- grub-core/disk/cryptodisk.c | 20 +--- grub-core/disk/luks.c | 26 -- include/grub/cryptodisk.h | 2 ++ 3 files changed, 27 insertions(+), 21 deletions(-) diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c

[PATCH 1/7] Cryptomount support LUKS detached header

From: John Lane --- grub-core/disk/cryptodisk.c | 22 ++ grub-core/disk/geli.c | 7 +-- grub-core/disk/luks.c | 45 + include/grub/cryptodisk.h | 5 +++-- 4 files changed, 63 insertions(+), 16 deletions(-) diff

[PATCH 6/7] Retain constness of parameters.

From: Denis Kasak --- grub-core/disk/cryptodisk.c | 2 +- include/grub/cryptodisk.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c index c442d3a34..6fc2c23aa 100644 --- a/grub-core/disk/cryptodisk.c +++ b/grub-co

[PATCH 2/7] Cryptomount support key files

From: John Lane --- grub-core/disk/cryptodisk.c | 46 - grub-core/disk/geli.c | 4 +++- grub-core/disk/luks.c | 44 +-- include/grub/cryptodisk.h | 5 - 4 files changed, 82 insertions(+), 17 d

Re: Support for detached LUKS header

> Could anyone give their approval for merging? > May I ask you or the original author to rebase the patches > on the latest master? Then I will take a look. And please > do not forget to CC me. > Daniel Daniel I am the original author of the aforementioned patches. I have reapplied my patches