Re: [PATCH] module-verifier: make it possible to run checkers on grub-module-verifierxx.c

2018-09-03 Thread Daniel Kiper
On Thu, Aug 02, 2018 at 10:36:33AM -0400, Peter Jones wrote: > This makes it so you can treat grub-module-verifierxx.c as a file you can > build directly, so syntax checkers like vim's "syntastic" plugin, which uses > "gcc -x c -fsyntax-only" to build it, will work. > > One still has to do

Re: [PATCH] Fix an 8 year old typo.

2018-09-03 Thread Daniel Kiper
On Wed, Aug 01, 2018 at 12:28:43PM -0400, Peter Jones wrote: > Signed-off-by: Peter Jones Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] grub-module-verifier: report the filename or modname in errors.

2018-09-03 Thread Daniel Kiper
On Wed, Aug 01, 2018 at 12:23:03PM -0400, Peter Jones wrote: > Make it so that when grub-module-verifier complains of an issue, it tells you > which module the issue was with. > > Signed-off-by: Peter Jones Reviewed-by: Daniel Kiper Daniel ___

Re: [PATCH 1/9] btrfs: Add support for reading a filesystem with a RAID 5 or RAID 6 profile.

2018-09-03 Thread Daniel Kiper
On Wed, Jul 18, 2018 at 08:24:50AM +0200, Goffredo Baroncelli wrote: > On 07/12/2018 03:46 PM, Daniel Kiper wrote: > > On Tue, Jun 19, 2018 at 07:39:48PM +0200, Goffredo Baroncelli wrote: > >> Signed-off-by: Goffredo Baroncelli > >> --- > >> grub-core/fs/btrfs.c | 70

Re: [PATCH 7/9] btrfs: Add support for recovery for a RAID 5 btrfs profiles.

2018-09-03 Thread Daniel Kiper
On Mon, Jun 18, 2018 at 08:12:22PM +0200, Goffredo Baroncelli wrote: > On 06/14/2018 09:05 PM, Goffredo Baroncelli wrote: > >>> + > >>> +cleanup: > >> Space before the label please. > >> I have asked about earlier. > > The line before the label is already a space; Am I missing something > > I

[PATCH v2] ofnet: Initialize structs in bootpath parser

2018-09-03 Thread Julian Andres Klode
Code later on checks if variables inside the struct are 0 to see if they have been set, like if there were addresses in the bootpath. The variables were not initialized however, so the check might succeed with uninitialized data, and a new interface with random addresses and the same name is