Re: [PATCH] Fix bad test on GRUB_DISABLE_SUBMENU.

2019-09-19 Thread Javier Martinez Canillas
Hello Daniel, On 9/18/19 2:53 PM, Daniel Kiper wrote: > On Tue, Sep 17, 2019 at 05:52:10PM +0200, Javier Martinez Canillas wrote: >> From: Prarit Bhargava >> >> The file /etc/grub.d/10_linux does >> >> if [ "x$is_top_level" = xtrue ] && [ "x${GRUB_DISABLE_SUBMENU}" != xy ]; then >> >> when it sho

Re: [PATCH] Add GRUB_DISABLE_UUID.

2019-09-19 Thread Javier Martinez Canillas
Hello Daniel, On 9/18/19 2:39 PM, Daniel Kiper wrote: > Adding Nicholas... > > On Tue, Sep 17, 2019 at 05:48:45PM +0200, Javier Martinez Canillas wrote: >> From: Peter Jones >> >> This will cause "search --fs-uuid --set=root ..." not to be generated by >> grub2-mkconfig, and instead simply attem

Re: [PATCH] Add %X option to printf functions.

2019-09-19 Thread Javier Martinez Canillas
Hello Daniel, Thanks for the quick feedback. On 9/18/19 3:00 PM, Daniel Kiper wrote: > On Tue, Sep 17, 2019 at 05:54:44PM +0200, Javier Martinez Canillas wrote: >> From: Paulo Flabiano Smorigo >> >> Signed-off-by: Paulo Flabiano Smorigo >> Signed-off-by: Javier Martinez Canillas > > May I ask

Re: [PATCH] grub-install: Define default platform for RISC-V

2019-09-19 Thread Alexander Graf
I guess that one must have slipped through the cracks :) Reviewed-by: Alexander Graf Alex On 19.09.19 12:06, Daniel Kiper wrote: Adding Alex... In general "Reviewed-by: Daniel Kiper " but I would to hear Alex's opinion here too... Daniel On Thu, Aug 15, 2019 at 04:55:13PM +0200, Andreas S

Re: [PATCH] grub-install: Define default platform for RISC-V

2019-09-19 Thread Daniel Kiper
Adding Alex... In general "Reviewed-by: Daniel Kiper " but I would to hear Alex's opinion here too... Daniel On Thu, Aug 15, 2019 at 04:55:13PM +0200, Andreas Schwab wrote: > Signed-off-by: Andreas Schwab > --- > util/grub-install.c | 8 > 1 file changed, 8 insertions(+) > > diff --gi

Re: [PATCH] grub-mkconfig: Fix typo in --help output

2019-09-19 Thread Daniel Kiper
On Fri, Aug 23, 2019 at 12:00:30PM +0100, Colin Watson wrote: > The short form of "--version" that grub-mkconfig accepts is "-V", not > "-v". > > Fixes Debian bug #935504. > > Signed-off-by: Colin Watson Reviewed-by: Daniel Kiper Daniel ___ Grub-deve

Re: [PATCH v2] riscv64-emu: add __clzdi2 symbol

2019-09-19 Thread Daniel Kiper
On Thu, Sep 19, 2019 at 09:39:04AM +0200, Andreas Schwab wrote: > This is needed for the zstd module. > > Signed-off-by: Andreas Schwab Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/list

Re: [PATCH] riscv64-emu: add __clzdi2 symbol

2019-09-19 Thread Andreas Schwab
On Sep 18 2019, Daniel Kiper wrote: > Hmmm... Is __clzdi2() declaration correct? It doesn't really matter, since nobody is using the prototype. It's only used for generating the symbol list. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE

[PATCH v2] riscv64-emu: add __clzdi2 symbol

2019-09-19 Thread Andreas Schwab
This is needed for the zstd module. Signed-off-by: Andreas Schwab --- configure.ac | 2 +- include/grub/compiler-rt-emu.h | 5 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index e07ba4b56..7d74eba66 100644 --- a/configure.ac ++