Re: [PATCH] Make grub_strtoul() "end" pointer have the right const params.

2020-02-18 Thread Nicholas Vinson
On 2/18/20 19:32, Peter Jones wrote: On Tue, Feb 04, 2020 at 08:04:30PM -0500, Nicholas Vinson wrote: On 2/4/20 16:02, Peter Jones wrote: grub_strtoul() and grub_strtoull() don't make the /pointer/ to "end" be const like normal implementations do, and as a result, at many places in

Re: [PATCH] Make grub_strtoul() "end" pointer have the right const params.

2020-02-18 Thread Peter Jones
On Tue, Feb 04, 2020 at 08:04:30PM -0500, Nicholas Vinson wrote: > On 2/4/20 16:02, Peter Jones wrote: > > grub_strtoul() and grub_strtoull() don't make the /pointer/ to "end" be > > const like normal implementations do, and as a result, at many places in > > grub_strtoul() and grub_strtoull()

[PATCH] ZFS/other CoW FS save_env support

2020-02-18 Thread Paul Dagnelie
Hey all, I previously discussed my concept for this patch in my email https://lists.gnu.org/archive/html/grub-devel/2020-01/msg4.html . I'm pleased to announce that I've gotten it into a working state and it is ready to review. There are a number of changes here, which I will break down

Re: [PATCH] verifiers: fix calling uninitialized function pointer

2020-02-18 Thread Daniel Kiper
On Tue, Feb 18, 2020 at 12:44:30PM +0100, Javier Martinez Canillas wrote: > On 2/18/20 11:08 AM, Michael Chang wrote: > > The necessary check for null before use of function ver->close is not > > taking place in the failure path. This patch simply adds the missing > > check and fixes the problem

Re: [PATCH] normal: Move common datetime functions out of the normal module

2020-02-18 Thread Daniel Kiper
On Fri, Feb 14, 2020 at 12:44:14PM +0100, Javier Martinez Canillas wrote: > The common datetime helper functions are currently included in the normal > module, but this makes any other module that calls these functions to have > a dependency with the normal module only for this reason. > > Since

Re: [PATCH] verifiers: fix calling uninitialized function pointer

2020-02-18 Thread Javier Martinez Canillas
On 2/18/20 11:08 AM, Michael Chang wrote: > The necessary check for null before use of function ver->close is not > taking place in the failure path. This patch simply adds the missing > check and fixes the problem that grub hangs indefinitely after booting > rogue image without valid signature if

[PATCH] verifiers: fix calling uninitialized function pointer

2020-02-18 Thread Michael Chang
The necessary check for null before use of function ver->close is not taking place in the failure path. This patch simply adds the missing check and fixes the problem that grub hangs indefinitely after booting rogue image without valid signature if secure boot turned on. Now it displays like this