[PATCH] cmdline: pass kernel command line as verbatim

2020-04-03 Thread Michael Chang
The command line has been processed by grub shell, then the result is expected to be passed to kernel command line as verbatim according to the grub manual [1][2]. This patch fixes excessive escape character (ie backslash) added to the output of command line and the problem is making it impossible

Re: [PATCHv2][ 1/6] cryptodisk: luks: unify grub_cryptodisk_dev function names

2020-04-03 Thread Denis 'GNUtoo' Carikli
On Fri, 3 Apr 2020 18:02:41 +0200 Daniel Kiper wrote: > Sorry, this is not 2.06 material for me. It's not a big issue for my use cases. In the worst case I can just backport the patches in the 2.06 packages and/or rely on -git packages until the next release. In the other hand, I want to avoid

Re: [PATCH 00/10] Another set of patches from Fedora

2020-04-03 Thread Daniel Kiper
On Fri, Apr 03, 2020 at 09:34:34PM +0200, Daniel Kiper wrote: > On Fri, Mar 13, 2020 at 08:06:32PM +0100, Javier Martinez Canillas wrote: > > Hello, > > > > This is another set of somewhat small patches that we have been carrying in > > the > > Fedora package. I found that some of them have alread

Re: [PATCH 00/10] Another set of patches from Fedora

2020-04-03 Thread Daniel Kiper
On Fri, Mar 13, 2020 at 08:06:32PM +0100, Javier Martinez Canillas wrote: > Hello, > > This is another set of somewhat small patches that we have been carrying in > the > Fedora package. I found that some of them have already been posted to the > list, > so for those patches I tried to address th

Re: [PATCH 10/10] module-verifier: make it possible to run checkers on grub-module-verifierxx.c

2020-04-03 Thread Daniel Kiper
On Fri, Mar 13, 2020 at 08:17:17PM +0100, Javier Martinez Canillas wrote: > From: Peter Jones > > This makes it so you can treat grub-module-verifierxx.c as a file you can > build directly, so syntax checkers like vim's "syntastic" plugin, which uses > "gcc -x c -fsyntax-only" to build it, will wo

Re: [PATCH 09/10] kern: Make it possible to subtract conditions from debug=

2020-04-03 Thread Daniel Kiper
On Fri, Mar 13, 2020 at 08:16:59PM +0100, Javier Martinez Canillas wrote: > From: Peter Jones > > This makes it so you can do set debug to "all,-scripting,-lexer" and get the > obvious outcome. Any negation present will take preference over that > conditional, so "all,-scripting,scripting" is the

Re: does grub2 support proxy dhcp?

2020-04-03 Thread Thomas Frauendorfer
On Thu, Apr 2, 2020 at 7:39 PM Daniel Kiper wrote: > > On Wed, Apr 01, 2020 at 11:08:07PM +0200, Thomas Frauendorfer wrote: > > Hi Olaf, > > > > Current Grub does not handle proxy DHCP correctly. > > There is a patch to add support for proxy DHCP in the mailing list > > archives, but it was never

Re: [PATCH 08/10] templates: Output a menu entry for firmware setup on UEFI FastBoot systems

2020-04-03 Thread Dimitri John Ledkov
There should be a slightly more recent version of the patch which changes the label to "UEFI Firmware Settings" which more consistent with vendor Bios documentation, GUI tools, systemctl, and Windows 10. We are currently trying to have that label consistently everywhere in Ubuntu. I was thinking t

Re: [PATCH 08/10] templates: Output a menu entry for firmware setup on UEFI FastBoot systems

2020-04-03 Thread Daniel Kiper
On Fri, Mar 13, 2020 at 08:15:53PM +0100, Javier Martinez Canillas wrote: > From: Steve Langasek > > If fastboot is enabled in the BIOS then often it is not possible to > enter the firmware setup menu, add a menu entry for this. > > hdegoede: Cherry picked the Ubuntu patch from: > https://git.laun

Re: [PATCH 07/10] kern/term: Accept ESC, F4 and holding SHIFT as user interrupt keys

2020-04-03 Thread Daniel Kiper
On Fri, Mar 13, 2020 at 08:15:02PM +0100, Javier Martinez Canillas wrote: > From: Hans de Goede > > On some devices the ESC key is the hotkey to enter the BIOS/EFI setup > screen, making it really hard to time pressing it right. Besides that > ESC is also pretty hard to discover for a user who doe

Re: [PATCH 06/10] kern/term: Make grub_getkeystatus helper funtion available everywhere

2020-04-03 Thread Daniel Kiper
On Fri, Mar 13, 2020 at 08:14:41PM +0100, Javier Martinez Canillas wrote: > From: Hans de Goede > > Move the grub_getkeystatus helper function from > grub-core/commands/keystatus.c to grub-core/kern/term.c > and export it so that it can be used outside of the > keystatus command code too. > > Sign

Re: [PATCH 05/10] efi/console: Implement getkeystatus() support

2020-04-03 Thread Daniel Kiper
On Fri, Mar 13, 2020 at 08:14:05PM +0100, Javier Martinez Canillas wrote: > From: Hans de Goede > > Implement getkeystatus() support. This commit misses explanation why this patch is needed. > Note that if a non-modifier key gets pressed and repeated calls to > getkeystatus() are made then it wi

Re: [PATCH 01/10] i386: Make pmtimer tsc calibration not take 51 seconds to fail

2020-04-03 Thread Daniel Kiper
On Fri, Mar 13, 2020 at 08:06:33PM +0100, Javier Martinez Canillas wrote: > From: Peter Jones > > On my laptop running at 2.4GHz, if I run a VM where tsc calibration > using pmtimer will fail presuming a broken pmtimer, it takes ~51 seconds > to do so (as measured with the stopwatch on my phone),

Re: [PATCHv2][ 1/6] cryptodisk: luks: unify grub_cryptodisk_dev function names

2020-04-03 Thread Daniel Kiper
On Tue, Mar 17, 2020 at 09:10:02AM +0100, Denis 'GNUtoo' Carikli wrote: > I'm sorry to have taken so long. > > I ended up being sidetracked with other functionalities I wanted to add > as well along the way, which I'll probably address another time. No problem... > I also forgot to use --compose

Re: [PATCH v1] http: return error on unhandled HTTP error responses

2020-04-03 Thread Daniel Kiper
On Thu, Mar 26, 2020 at 08:36:47PM +0100, Daniel Kiper wrote: > On Wed, Mar 25, 2020 at 08:30:38PM +0100, Olaf Hering wrote: > > Am Wed, 25 Mar 2020 19:55:47 +0100 > > schrieb Daniel Kiper : > > > > > Should not we do the same for 404, file not found, a few lines above? > > > > Maybe. For some reas

Re: does grub2 support proxy dhcp?

2020-04-03 Thread Daniel Kiper
On Thu, Apr 02, 2020 at 08:40:28PM +0200, Olaf Hering wrote: > Am Thu, 2 Apr 2020 19:39:49 +0200 > schrieb Daniel Kiper : > > > I use such configuration an UEFI platform and it works without any > > issue. However, pxelinux.0 above suggests that you are playing with > > legacy BIOS PC platform. > >

Re: [PATCH v2 1/4] configure: Drop unneeded TARGET_CFLAGS expansion

2020-04-03 Thread John Paul Adrian Glaubitz
On 4/3/20 2:45 PM, Daniel Kiper wrote: > diff --git a/configure.ac b/configure.ac > index 88c0adbae..b2576b013 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -77,7 +77,7 @@ grub_TRANSFORM([grub-file]) > > # Optimization flag. Allow user to override. > if test "x$TARGET_CFLAGS" = x; then

[PATCH v2 0/4] Various build and doc fixes

2020-04-03 Thread Daniel Kiper
Hey, As in subject... Please review... Daniel INSTALL | 51 +++ autogen.sh | 2 +- configure.ac | 16 +++- 3 files changed, 39 insertions(+), 30 deletions(-) Daniel Kiper (4): configure: Drop unneeded TARGET_CFLAGS expan

[PATCH v2 2/4] configure: Enforce gnu99 C language standard

2020-04-03 Thread Daniel Kiper
Commit d5a32255d (misc: Make grub_strtol() "end" pointers have safer const qualifiers) introduced "restrict" keyword into some functions definitions. This keyword was introduced in C99 standard. However, some compilers by default may use C89 or something different. This behavior leads to the breaka

[PATCH v2 4/4] autogen: Replace -iname with -ipath in find command

2020-04-03 Thread Daniel Kiper
..because -iname cannot be used to match paths. Signed-off-by: Daniel Kiper --- autogen.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/autogen.sh b/autogen.sh index ef43270fc..31b0ced7e 100755 --- a/autogen.sh +++ b/autogen.sh @@ -13,7 +13,7 @@ fi export LC_COLLATE=C un

[PATCH v2 1/4] configure: Drop unneeded TARGET_CFLAGS expansion

2020-04-03 Thread Daniel Kiper
Signed-off-by: Daniel Kiper --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 88c0adbae..b2576b013 100644 --- a/configure.ac +++ b/configure.ac @@ -77,7 +77,7 @@ grub_TRANSFORM([grub-file]) # Optimization flag. Allow user to

[PATCH v2 3/4] INSTALL/configure: Update install doc and configure comment

2020-04-03 Thread Daniel Kiper
..to reflect the GRUB build reality in them. Additionally, fix ./configure command example formatting in INSTALL file. Signed-off-by: Daniel Kiper --- INSTALL | 51 +++ configure.ac | 10 ++ 2 files changed, 33 insertions(+), 28 delet

[PATCH] multiboot2: enable quirk-modules-after-kernel

2020-04-03 Thread Zide Chen
In multiboot2, currently there is no way to control where to load the modules. In case of user wants to reserve low address for particular usage, this quirk is useful to load the modules to higher address. This patch makes the quirk to multiboot2 by: - remove "ifndef GRUB_USE_MULTIBOOT2" that is