On Wed, 13 May 2020 23:11:03 +0200
Hans Ulrich Niedermann wrote:
> On Wed, 13 May 2020 18:21:11 +0200
> Daniel Kiper wrote:
>
> > On Fri, May 08, 2020 at 06:50:47AM +0200, Hans Ulrich Niedermann
> > wrote:
> > > Add .gitignore file and remove the obsolete .bzrignore file.
> > >
> > > The doc/
On Wed, 13 May 2020 18:24:28 +0200
Daniel Kiper wrote:
> On Fri, May 08, 2020 at 06:50:48AM +0200, Hans Ulrich Niedermann
> wrote:
> > The example kernel has assembly language boot code for both
> > i386 and mips, but the mips assembly code used to be built
> > unconditionally, even if the build
Hi Daniel,
> -Original Message-
> From: Chen, Zide
> Sent: Wednesday, May 13, 2020 3:39 PM
> To: 'Daniel Kiper'
> Cc: grub-devel@gnu.org
> Subject: RE: [MULTIBOOT2 SPEC PATCH V2] multiboot2: Add module load and
> preference tag
> > >
> > > @@ -730,6 +731,46 @@ Boot loader should follow i
In the cases of users have preferences over Multiboot2 module load
addresses, currently GRUB has no way to achieve it.
Similar to the relocatable header tag, this new tag allows users to
specify the minimum and maximum load addresses, and other load
preferences on Multiboot2 modules.
Bump version
Hi Daniel,
> -Original Message-
> From: Daniel Kiper
> Sent: Wednesday, May 13, 2020 8:54 AM
> To: Chen, Zide
> Cc: grub-devel@gnu.org
> Subject: Re: [MULTIBOOT2 SPEC PATCH V2] multiboot2: Add module load and
> preference tag
>
> > diff --git a/doc/multiboot.texi b/doc/multiboot.texi
>
On Wed, 13 May 2020 18:21:11 +0200
Daniel Kiper wrote:
> On Fri, May 08, 2020 at 06:50:47AM +0200, Hans Ulrich Niedermann
> wrote:
> > Add .gitignore file and remove the obsolete .bzrignore file.
> >
> > The doc/.gitignore file is generated by gnulib-tool so we keep
> > that file in addition to t
On Wed, 13 May 2020 18:21:11 +0200
Daniel Kiper wrote:
> On Fri, May 08, 2020 at 06:50:47AM +0200, Hans Ulrich Niedermann
> wrote:
[... lots of gitignore stuff again ... ]
> > +/doc/mdate-sh
> > +/doc/texinfo.tex
> > +/install-sh
> > +/INSTALL
> > +/missing
> > +
> > +# Generated by "configure"
On Fri, May 08, 2020 at 06:50:49AM +0200, Hans Ulrich Niedermann wrote:
> Properly align all Multiboot2 header tags to 8 byte
> boundaries as per the Multiboot2 specification.
>
> Note that the assembler directive ".align 8" is machine
> dependent: On i386, it means "align to 8 byte boundary".
> On
On Fri, May 08, 2020 at 06:50:48AM +0200, Hans Ulrich Niedermann wrote:
> The example kernel has assembly language boot code for both
> i386 and mips, but the mips assembly code used to be built
> unconditionally, even if the build is using non-mips build
> tools such as for x86_64 or i386.
>
> Thi
On Fri, May 08, 2020 at 06:50:47AM +0200, Hans Ulrich Niedermann wrote:
> Add .gitignore file and remove the obsolete .bzrignore file.
>
> The doc/.gitignore file is generated by gnulib-tool so we keep
> that file in addition to the top-level .gitignore file which
> covers everything else in the su
On Fri, May 08, 2020 at 06:50:46AM +0200, Hans Ulrich Niedermann wrote:
> Current gnulib's gnulib-tool (which is called by autogen.sh)
> only runs if configure.ac contains at least AC_PREREQ(2.63).
>
> Requiring Autoconf 2.63 (release tagged in 2008-09) instead of
> Autoconf 2.59 (release 2.59 tag
On Thu, May 07, 2020 at 03:09:23PM -0700, Zide Chen wrote:
> In the cases of users have preferences over Multiboot2 module load
> addresses, currently GRUB has no way to achieve it.
>
> Similar to the relocatable header tag, this new tag allows users to
> specify the minimum and maximum load addres
Hi Daniel
On Thu, 2020-05-07 at 13:06 +0200, Daniel Kiper wrote:
> > There is a function that verifies if platform is TXT capable
> > -grub_txt_verify_platform(), it only checks SMX and GETSEC features.
> > Although BIOS should enforce both VMX and VT-d enabled when enabling
> > TXT, I think that
On Wed, May 13, 2020 at 09:13:29PM +0800, Tianjia Zhang wrote:
> grub_tpm_log_event() and grub_tpm_measure() are two functions that
> have the same effect, so keep grub_tpm_log_event() and rename it
> to grub_tpm_measure(). There is also a more clear semantics.
>
> Signed-off-by: Tianjia Zhang
Re
grub_tpm_log_event() and grub_tpm_measure() are two functions that
have the same effect, so keep grub_tpm_log_event() and rename it
to grub_tpm_measure(). There is also a more clear semantics.
Signed-off-by: Tianjia Zhang
---
grub-core/commands/efi/tpm.c | 2 +-
grub-core/commands/tpm.c | 7
On 2020/5/13 20:45, Daniel Kiper wrote:
On Wed, May 13, 2020 at 04:53:53PM +0800, Tianjia Zhang wrote:
The grub_tpm_measure() is only used by tpm.c, and this function
is the simple wrapper of grub_tpm_event_log(). So remove it and
keep the code cleaner.
Signed-off-by: Tianjia Zhang
I would
On Mon, May 11, 2020 at 01:12:31AM +0200, Hans Ulrich Niedermann wrote:
> Remove all documentation of and mentions of the uppermem
> command from the docs/grub.texi file.
>
> The uppermem command is not implemented in the GRUB source
> at all and appears to never have been implemented despite
> for
On Mon, May 11, 2020 at 01:12:30AM +0200, Hans Ulrich Niedermann wrote:
> Remove the documentation of the pxe_unload command from the
> docs/grub.texi file.
>
> The pxe_unload command is not implemented in the grub source
> at this time at all. It appears to have been removed in commit
> 71a78acb06
On Wed, May 13, 2020 at 14:02:46 +0200, Daniel Kiper wrote:
> Hey,
>
> As in subject... Please review...
Hi Daniel,
This looks good to me.
For the series:
Reviewed-by: Leif Lindholm
> Daniel
>
> INSTALL | 47 +++
> autogen.sh | 2 +-
> con
On Wed, May 13, 2020 at 11:04:37AM +0200, Jacob Kroon wrote:
> Support was implemented in commit
>
> c7cb11b2198a07098143ecc67b19497ba25df28f
Next time please provide commit subject too. E.g. commit c7cb11b21
(probe: Support probing for msdos PARTUUID).
> Signed-off-by: Jacob Kroon
...otherwise
On Wed, May 13, 2020 at 04:53:53PM +0800, Tianjia Zhang wrote:
> The grub_tpm_measure() is only used by tpm.c, and this function
> is the simple wrapper of grub_tpm_event_log(). So remove it and
> keep the code cleaner.
>
> Signed-off-by: Tianjia Zhang
I would prefer if you drop existing grub_tpm
On Wed, May 13, 2020 at 04:53:41PM +0800, Tianjia Zhang wrote:
> Like grub_verifiers_open(), the grub_verify_string() should also
> display this debug message, which is very helpful for debugging.
>
> Signed-off-by: Tianjia Zhang
Reviewed-by: Daniel Kiper
Daniel
___
On Tue, May 12, 2020 at 02:32:25PM +0200, Javier Martinez Canillas wrote:
> If an existing variable is set with a value whose length is smaller than
> the current value, a memory corruption can happen due copying padding '#'
> characters outside of the environment block buffer.
>
> This is caused b
Hey,
As in subject... Please review...
Daniel
INSTALL | 47 +++
autogen.sh | 2 +-
configure.ac | 19 ++-
3 files changed, 46 insertions(+), 22 deletions(-)
Daniel Kiper (5):
configure: Drop unneeded TARGET_CFLAGS expans
..to reflect the GRUB build reality in them.
Additionally, fix text formatting a bit.
Signed-off-by: Daniel Kiper
---
v3 - suggestions/fixes:
- improve wording of changed text
(suggested by Leif Lindholm),
- drop configure example change from this patch.
---
INSTALL | 27 +++
..because -iname cannot be used to match paths.
Signed-off-by: Daniel Kiper
Reviewed-by: Javier Martinez Canillas
---
autogen.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/autogen.sh b/autogen.sh
index ef43270fc..31b0ced7e 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -13
Signed-off-by: Daniel Kiper
Reviewed-by: Javier Martinez Canillas
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 88c0adbae..b2576b013 100644
--- a/configure.ac
+++ b/configure.ac
@@ -77,7 +77,7 @@ grub_TRANSFORM([grub-file])
Commit d5a32255d (misc: Make grub_strtol() "end" pointers have safer
const qualifiers) introduced "restrict" keyword into some functions
definitions. This keyword was introduced in C99 standard. However, some
compilers by default may use C89 or something different. This behavior
leads to the breaka
..to make it more relevant.
Signed-off-by: Daniel Kiper
---
INSTALL | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/INSTALL b/INSTALL
index 5cea313af..dedf236a8 100644
--- a/INSTALL
+++ b/INSTALL
@@ -160,12 +160,20 @@ For this example the configure line
Support was implemented in commit
c7cb11b2198a07098143ecc67b19497ba25df28f
Signed-off-by: Jacob Kroon
---
docs/grub.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/grub.texi b/docs/grub.texi
index d6408d242..c93613460 100644
--- a/docs/grub.texi
+++ b/docs/grub.tex
The grub_tpm_measure() is only used by tpm.c, and this function
is the simple wrapper of grub_tpm_event_log(). So remove it and
keep the code cleaner.
Signed-off-by: Tianjia Zhang
---
grub-core/commands/tpm.c | 12 ++--
include/grub/tpm.h | 2 --
2 files changed, 2 insertions(+),
Like grub_verifiers_open(), the grub_verify_string() should also
display this debug message, which is very helpful for debugging.
Signed-off-by: Tianjia Zhang
---
grub-core/commands/verifiers.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/grub-core/commands/verifiers.c b/grub-core/comm
32 matches
Mail list logo
