Re: [PATCH 3/4] efinet: UEFI IPv6 PXE support

2020-06-05 Thread Javier Martinez Canillas
[adding Peter Jones as Cc that I forgot when sending the patches] On 6/5/20 4:15 AM, Michael Chang wrote: > On Thu, Jun 04, 2020 at 01:37:52PM +0200, Thomas Frauendorfer wrote: >> Hi, >> >> You replace the 'unused[52]' field before dhcp_discover with 51 bytes. >> While the UEFI spec also defines t

Re: [PATCH 3/4] efinet: UEFI IPv6 PXE support

2020-06-05 Thread Thomas Frauendorfer
On Fri, Jun 5, 2020 at 4:16 AM Michael Chang wrote: > > You're probably right if the data type for `station_ip` is > `grub_efi_pxe_ip_address_t`, but here it is `grub_efi_ip_address_t` declared > as: > > typedef grub_uint8_t grub_efi_ip_address_t[8] __attribute__ ((aligned(4))); > > So the compi