Re: [PATCH 2/2] autogen.sh: Detect python

2021-08-09 Thread Daniel Kiper
On Mon, Aug 09, 2021 at 01:52:29PM +0200, Daniel Kiper wrote: > On Fri, Aug 06, 2021 at 08:45:08AM +0200, Petr Vorel wrote: > > It help to avoid error on distros which has only python3 binary: > > ./autogen.sh: line 20: python: command not found > > > > Using bash builtin 'command -v' to avoid requ

Re: [PATCH v2 4/4] efi: mm: Implement runtime addition of pages

2021-08-09 Thread Daniel Kiper
On Sun, Aug 08, 2021 at 03:31:53PM +0200, Patrick Steinhardt wrote: > Adjust the interface of `grub_efi_mm_add_regions ()` to take a set of > `GRUB_MM_REGION_*` flags, which most notably is currently only the > `CONSECUTVE` flag. This allows us to set the function up as callback for > the memory su

Re: [PATCH v2 3/4] efi: mm: Pass up errors from `add_memory_regions ()`

2021-08-09 Thread Daniel Kiper
On Sun, Aug 08, 2021 at 03:31:49PM +0200, Patrick Steinhardt wrote: > The function `add_memory_regions ()` is currently only called on system > initialization to allocate a fixed amount of pages. As such, it didn't > need to return any errors: in case it failed, we cannot proceed anyway. > This wil

Re: [PATCH v2 2/4] efi: mm: Extract function to add memory regions

2021-08-09 Thread Daniel Kiper
On Sun, Aug 08, 2021 at 03:31:45PM +0200, Patrick Steinhardt wrote: > In preparation of support for runtime-allocating additional memory > region, this patch extracts the function to retrieve the EFI memory map > and add a subset of it to GRUB's own memory regions. > > Note that this commit also ch

Re: [PATCH v2 1/4] mm: Allow dynamically requesting additional memory regions

2021-08-09 Thread Daniel Kiper
On Sun, Aug 08, 2021 at 03:31:41PM +0200, Patrick Steinhardt wrote: > Currently, all platforms will set up their heap on initialization of the > platform code. While this works mostly fine, it poses some limitations > on memory management on us. Most notably, allocating big chunks of > memory in th

Re: [PATCH] diskfilter: use nodes in logical volume's segment as member device

2021-08-09 Thread Daniel Kiper
On Mon, Aug 02, 2021 at 05:40:20PM +0800, Michael Chang via Grub-devel wrote: > Currently the grub_diskfilter_memberlist function returns all physical > volumes added to a volume group to which a logical volume (LV) belongs. > However this is suboptimal as it doesn't fit the intended behavior of >

Re: [PATCH v3 1/4] ieee1275: Move #defines into common ieee1275.h header

2021-08-09 Thread Daniel Kiper
On Thu, Aug 05, 2021 at 06:22:24PM -0400, Stefan Berger wrote: > On 7/30/21 11:45 AM, Stefan Berger wrote: > > From: Stefan Berger > > > > Move some #defines from ieee1275.c into the common ieee1275.h > > header file. Adjust the case used in IHANDLE_INVALID to use > > proper ihandle_t. > > > > Sig

Re: Bug#991691: Possible CVE-2014-5461 in grub2

2021-08-09 Thread Daniel Kiper
Hi, On Fri, Jul 30, 2021 at 08:55:06PM +0400, Movses Tovmasyan wrote: > Package: grub2 > Version: 2.02~beta3-5+deb9u2 > Tags: patch > > grub2 uses the obsolete version of minilua > (single-file port of Lua) which has CVE-2014-5461 > Patch attached below. Thanks for the report. This patch does not

Re: [PATCH 2/2] autogen.sh: Detect python

2021-08-09 Thread Daniel Kiper
On Fri, Aug 06, 2021 at 08:45:08AM +0200, Petr Vorel wrote: > It help to avoid error on distros which has only python3 binary: > ./autogen.sh: line 20: python: command not found > > Using bash builtin 'command -v' to avoid requiring which as extra > dependency (usable on containers). It looks the

Re: [PATCH 1/2] bootstrap: Require patch

2021-08-09 Thread Daniel Kiper
On Fri, Aug 06, 2021 at 08:45:07AM +0200, Petr Vorel wrote: > bootstrap.conf uses patch, let's require it. > > Better than multiple messages: > ./bootstrap.conf: line 84: patch: command not found > > Signed-off-by: Petr Vorel Reviewed-by: Daniel Kiper Daniel ___