[PATCH v3] Fix build error in binutils 2.36

2021-09-27 Thread Michael Chang via Grub-devel
The following procedure to build xen/pvgrub is broken. git clone https://git.savannah.gnu.org/git/grub.git cd grub ./bootstrap mkdir build-xen cd build-xen ../configure --with-platform=xen make It fails with the message: /usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse

Re: [PATCH v2] Fix build error in binutils 2.36

2021-09-27 Thread Michael Chang via Grub-devel
On Mon, Sep 27, 2021 at 10:18:49AM -0400, Mike Gilbert wrote: > On Mon, Sep 27, 2021 at 5:41 AM Michael Chang via Grub-devel > wrote: > > It is also worth mentioning that binutils upstream apparently doesn't > > seem to consider this as a bug [2] and proposed to use > > -Wl,-Ttext-segment,0 which'

[PATCH v2 4/4] cryptodisk: Remove unneeded found_uuid from cryptomount args

2021-09-27 Thread Glenn Washburn
The member found_uuid was never used by the crypto-backends, but was used to determine if a crypto-backend successfully mounted a cryptodisk with a given uuid. This is not needed however, because grub_device_iterate will return 1 iff grub_cryptodisk_scan_device returns 1. And grub_cryptodisk_scan_d

[PATCH v2 3/4] cryptodisk: Move global variables into grub_cryptomount_args struct

2021-09-27 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- grub-core/disk/cryptodisk.c | 26 +- grub-core/disk/geli.c | 9 - grub-core/disk/luks.c | 11 +-- grub-core/disk/luks2.c | 6 +++--- include/grub/cryptodisk.h | 6 -- 5 files changed, 25 insertions

[PATCH v2 2/4] cryptodisk: Refactor password input from crypto dev modules into cryptodisk

2021-09-27 Thread Glenn Washburn
The crypto device modules should only be setting up the crypto devices and not getting user input. This has the added benefit of simplifying the code such that three essentially duplicate pieces of code are merged into one. Signed-off-by: Glenn Washburn --- grub-core/disk/cryptodisk.c | 52 +

[PATCH v2 1/4] cryptodisk: Add infrastructure to pass data from cryptomount to cryptodisk modules

2021-09-27 Thread Glenn Washburn
As an example, passing a password as a cryptomount argument is implemented. However, the backends are not implemented, so testing this will return a not implemented error. Signed-off-by: Glenn Washburn --- grub-core/disk/cryptodisk.c | 31 +-- grub-core/disk/geli.c

[PATCH v2 0/4] Refactor/improve cryptomount data passing to crypto modules

2021-09-27 Thread Glenn Washburn
In this version of this patch series the cargs struct was moved out of the device struct and is passed around as a function parameter. Also a fourth patch was added to remove the found_uuid flag from the cargs struct, which is not needed because the same information can be obtained from the return

Re: [PATCH v3 2/6] mm: Allow dynamically requesting additional memory regions

2021-09-27 Thread Daniel Axtens
Hi Daniel, >> I still would really prefer to bypass grub mm completely as described in >> my other mail. If we are able to give memory back to fw, we can claim >> 1GB chunks (on SLOF, PFW is going to be another issue) without having to >> worry about where we put them and if we have enough memory

Re: [PATCH v2] Fix build error in binutils 2.36

2021-09-27 Thread Mike Gilbert
On Mon, Sep 27, 2021 at 5:41 AM Michael Chang via Grub-devel wrote: > It is also worth mentioning that binutils upstream apparently doesn't > seem to consider this as a bug [2] and proposed to use > -Wl,-Ttext-segment,0 which's not fruitful as what has been tested by > gentoo [3]. > ... > [2] Ref:

[PATCH v2] Fix build error in binutils 2.36

2021-09-27 Thread Michael Chang via Grub-devel
The following procedure to build xen/pvgrub is broken. git clone https://git.savannah.gnu.org/git/grub.git cd grub ./bootstrap mkdir build-xen cd build-xen ../configure --with-platform=xen make It fails with the message: /usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse

[PATCH v3] diskfilter: use nodes in logical volume's segment as member device

2021-09-27 Thread Michael Chang via Grub-devel
Currently the grub_diskfilter_memberlist function returns all physical volumes added to a volume group to which a logical volume (LV) belongs. However this is suboptimal as it doesn't fit the intended behavior of returning underlying devices that make up the LV. To give a clear picture, the result