Re: [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses.

2021-10-11 Thread Glenn Washburn
On Mon, 11 Oct 2021 14:48:44 -0400 Robbie Harwood wrote: > From: Peter Jones > > This makes a grub_dprintf() call during platform init and during module > loading that tells us the virtual addresses of the .text and .data > sections of grub-core/kernel.exec and any modules it loads. > > Specif

Re: [PATCH 1/2] Add grub_qdprintf() - grub_dprintf() without the file+line number.

2021-10-11 Thread Glenn Washburn
On Mon, 11 Oct 2021 14:48:43 -0400 Robbie Harwood wrote: > From: Peter Jones > > This just makes copy+paste of our debug loading info easier. > > Signed-off-by: Peter Jones > Signed-off-by: Robbie Harwood > --- > grub-core/kern/misc.c | 18 ++ > include/grub/misc.h | 2 ++

[PATCH 1/2] Add grub_qdprintf() - grub_dprintf() without the file+line number.

2021-10-11 Thread Robbie Harwood
From: Peter Jones This just makes copy+paste of our debug loading info easier. Signed-off-by: Peter Jones Signed-off-by: Robbie Harwood --- grub-core/kern/misc.c | 18 ++ include/grub/misc.h | 2 ++ 2 files changed, 20 insertions(+) diff --git a/grub-core/kern/misc.c b/gru

[PATCH 2/2] Make a "gdb" dprintf that tells us load addresses.

2021-10-11 Thread Robbie Harwood
From: Peter Jones This makes a grub_dprintf() call during platform init and during module loading that tells us the virtual addresses of the .text and .data sections of grub-core/kernel.exec and any modules it loads. Specifically, it displays them in the gdb "add-symbol-file" syntax, with the pr

[PATCH 0/2] Print out load addresses for .text and .data

2021-10-11 Thread Robbie Harwood
Hi, These patches display (in format that can be copy/pasted to gdb) the virtual addresses of grub-core/kernel.exec (and any modules it loads). First patch is prep work - adds a print without numbering. The second patch is better with this call, since it makes copy/pasting easier. (These have b

Re: [PATCH v3 2/4] tests: Do not occlude subshell error codes

2021-10-11 Thread Glenn Washburn
On Mon, 11 Oct 2021 16:20:46 +0200 Daniel Kiper wrote: > On Thu, Oct 07, 2021 at 03:33:25PM -0500, Glenn Washburn wrote: > > When a subshell's output is used as input to a "simple command", its return > > code is not checked. These subshells contain an execution of the grub-shell > > script which

Re: [PATCH v2] docs: Add fuller accounting of make check prerequisites

2021-10-11 Thread Daniel Kiper
On Fri, Oct 08, 2021 at 01:10:07PM -0500, Glenn Washburn wrote: > On Tue, 5 Oct 2021 18:08:10 +0200 > Daniel Kiper wrote: > > > On Tue, Oct 05, 2021 at 12:45:04AM -0500, Glenn Washburn wrote: > > > Many of the prerequisites for exercising the full `make check' test suite > > > > I would prefer if

Re: [PATCH v2] osdep/linux: Fix md array device enumeration

2021-10-11 Thread Daniel Kiper
On Thu, Oct 07, 2021 at 04:33:16PM -0700, Kees Cook wrote: > GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO's > disk.number, which is an internal kernel index. If an array has had drives > added, removed, etc, there may be gaps in GET_DISK_INFO's results. But > since the consumer of d

Re: [PATCH 0/2] More test fixes

2021-10-11 Thread Daniel Kiper
On Thu, Oct 07, 2021 at 04:07:30PM -0500, Glenn Washburn wrote: > The first patch changes the test exit status from skipped to hard error, for > tests which fail due to missing dependencies in the environment. > > The second is a trivial patch to parameterize all uses of parted in the > partmap_tes

Re: [PATCH v3 2/4] tests: Do not occlude subshell error codes

2021-10-11 Thread Daniel Kiper
On Thu, Oct 07, 2021 at 03:33:25PM -0500, Glenn Washburn wrote: > When a subshell's output is used as input to a "simple command", its return > code is not checked. These subshells contain an execution of the grub-shell > script which does the work of the actual test. If grub-shell returns an > err

Re: [PATCH v3 4/4] tests: Exit with skipped exit code when test not performed

2021-10-11 Thread Daniel Kiper
On Thu, Oct 07, 2021 at 03:33:27PM -0500, Glenn Washburn wrote: > These tests were not performed and therefore did not pass, nor fail. This > fixes misleading test exit code where, for instance, the pseries_test will > pass on i386-pc, which is not a pseries architecture. > > Signed-off-by: Glenn W

Re: [PATCH v3 3/4] tests: Do not occlude grub-shell return code

2021-10-11 Thread Daniel Kiper
On Thu, Oct 07, 2021 at 03:33:26PM -0500, Glenn Washburn wrote: > The script grub-shell does the bulk of the testing. If it returns an error > code, that means that the test failed and the test should immediately exit > with that error code. When grub-shell is used as a non-terminating command > in

Re: [PATCH v3 1/4] tests: Add set -e to missing tests

2021-10-11 Thread Daniel Kiper
On Thu, Oct 07, 2021 at 03:33:24PM -0500, Glenn Washburn wrote: > This helps to ensure that error codes do not get ignored. > > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://list

Re: [PATCH v2] grub-shell: Boot PowerPC using PMU instead of CUDA for power management

2021-10-11 Thread Daniel Axtens
Glenn Washburn writes: > A recent refactoring of CUDA command code has exposed a bug in OpenBIOS[1] > which was causing system powerdown and system reset to fail, thus causing > the Qemu instance to hang. This in turn caused the grub-shell command to > timeout causing it to return an error code w