Re: [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses.

2021-10-15 Thread Glenn Washburn
On Fri, 15 Oct 2021 16:55:17 -0400 Robbie Harwood wrote: > Glenn Washburn writes: > > > Robbie Harwood wrote: > >> Glenn Washburn writes: > >> > >>> I don't agree with suppressing file:line for debug output. I have > >>> some changes in the pipeline which will allow selectively disabling > >

[PATCH] fs/btrfs: Make extent item iteration to handle gaps

2021-10-15 Thread Qu Wenruo via Grub-devel
[BUG] Grub btrfs implementation can't handle two very basic btrfs file layouts: 1. Mixed inline/regualr extents # mkfs.btrfs -f test.img # mount test.img /mnt/btrfs # xfs_io -f -c "pwrite 0 1k" -c "sync" -c "falloc 0 4k" \ -c "pwrite 4k 4k" /mnt/btrfs/file # umount /mnt/

Re: About the code style requirement

2021-10-15 Thread Qu Wenruo via Grub-devel
On 2021/10/8 08:22, Qu Wenruo via Grub-devel wrote: On 2021/10/7 21:51, Daniel Kiper wrote: On Fri, Oct 01, 2021 at 03:14:02PM +0800, Qu Wenruo via Grub-devel wrote: On 2021/10/1 14:08, Vladimir 'phcoder' Serbinenko wrote: [...] GRUB already has a btrfs implementation. Writing new one f

Re: [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses.

2021-10-15 Thread Robbie Harwood
Glenn Washburn writes: > Robbie Harwood wrote: >> Glenn Washburn writes: >> >>> I don't agree with suppressing file:line for debug output. I have >>> some changes in the pipeline which will allow selectively disabling >>> conditions when also using "debug=all". Suppressing file:line makes >>>

Re: [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses.

2021-10-15 Thread Glenn Washburn
On Thu, 14 Oct 2021 13:09:21 -0400 Robbie Harwood wrote: > Glenn Washburn writes: > > > I don't agree with suppressing file:line for debug output. I have some > > changes in the pipeline which will allow selectively disabling > > conditions when also using "debug=all". Suppressing file:line mak