On Tue, Oct 26, 2021 at 02:55:21PM +0200, Daniel Kiper wrote:
> On Fri, Sep 10, 2021 at 05:22:22PM +0800, Michael Chang via Grub-devel wrote:
> > On Wed, Sep 08, 2021 at 09:37:52PM +0200, Daniel Kiper wrote:
> > > On Fri, Sep 03, 2021 at 09:21:39AM +0800, Michael Chang via Grub-devel
> > > wrote:
Hi Daniel,
Thank you for another detailed response. Please let me know how that
section related to IPv6 should be commented, and I will submit an
updated patch.
- Steve
On 10/26/2021 8:52 AM, Daniel Kiper wrote:
Hi Stephen,
On Sun, Oct 10, 2021 at 03:15:34PM -0700, Stephen Balousek wrote:
On Tue, Oct 26, 2021 at 12:08:23PM -0400, Robbie Harwood wrote:
> Daniel Kiper writes:
>
> > On Mon, Oct 25, 2021 at 06:17:03PM -0400, Robbie Harwood wrote:
> >> Before performing the license check, resolve the module name so that it
> >> can be printed if the license check fails. Prior to this
Daniel Axtens writes:
>> ChangeLog-2015 has been untouched for nearly 5 years now, and any
>> information in it is purely for historical purposes. At the same time,
>> grepping for code winds up matching this file quite a bit, almost never
>> accomplishing anything other than cluttering up your
Daniel Kiper writes:
> On Mon, Oct 25, 2021 at 06:17:03PM -0400, Robbie Harwood wrote:
>> Before performing the license check, resolve the module name so that it
>> can be printed if the license check fails. Prior to this change, grub
>> would only indicate that the check had been failed, but
Hi Stephen,
On Sun, Oct 10, 2021 at 03:15:34PM -0700, Stephen Balousek wrote:
> Hi Daniel,
>
> Thank you for the review. This is my first submission to the project, and I
> apologize for my lack of familiarity with the conventions and guidelines.
No worries!
> I reworked the patch with your
Coverity has flagged a number of small issues that should be fixed to help in
cleaning up the code - these here are primarily memory leaks or uninitialized
variables.
In theory leaked memory is significant, but for short-lived processes it is
minor.
Similarly for unitinialized variables - some
In zap_leaf_array_get() the chunk size passed in is considered tainted
by Coverity, and is being used before it is tested for validity.
To fix this the assignment of 'la' is moved until after the test of the
value of 'chunk'.
Fixes: CID 314014
Signed-off-by: Darren Kenny
---
The copy_all() function skips a section of code using continue, but
fails to free the memory in srcf first, leaking it.
Fixes: CID 314026
Signed-off-by: Darren Kenny
---
util/grub-install-common.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/util/grub-install-common.c
In the function write_part(), the value of 'inname' is not used beyond
the grub_util_fopen() call, so is should be freed to avoid leakage.
Fixes: CID 314028
Signed-off-by: Darren Kenny
---
util/grub-mkrescue.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/grub-mkrescue.c
In huft_build() it is possible to reach the for loop where 'r' is being
assigned to 'q[j]' without 'r.v' ever being initialized.
Fixes: CID 314024
Signed-off-by: Darren Kenny
---
grub-core/io/gzio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grub-core/io/gzio.c
In the function write_font_pf2() memory is allocated for 'font_name' to
construct a new name, but it is not released before returning from the
function, leaking the allocated memory.
Fixes: CID 314015
Signed-off-by: Darren Kenny
---
util/grub-mkfont.c | 1 +
1 file changed, 1 insertion(+)
In the function cmd_cmp() within the while loop, srcnew and destnew are
being allocated but are never freed either before leaving scope or in
the recursive calls being made to cmd_cmp().
Fixes: CID 314032
Fixes: CID 314045
Signed-off-by: Darren Kenny
---
util/grub-fstest.c | 7 ++-
1 file
On Thu, Sep 23, 2021 at 08:59:14PM -0600, Chris Murphy wrote:
> On Wed, Jul 28, 2021 at 6:23 AM Daniel Kiper wrote:
> >
> > At this point I am not fully convinced the /boot/grub should be on
> > a separate filesystem. Though after going through this thread it seems
> > to me we should add full
Thanks for the detailed reply, I think I’ve got to the bottom of this now, I
realised what I missed just after I sent this email.
> On 26 Oct 2021, at 13:35, Daniel Kiper wrote:
>
> Hey,
>
>> On Thu, Oct 21, 2021 at 08:46:06PM +0100, Chris Plant wrote:
>> Hello,
>>
>> I'm continuing to play
On Fri, Sep 10, 2021 at 05:22:22PM +0800, Michael Chang via Grub-devel wrote:
> On Wed, Sep 08, 2021 at 09:37:52PM +0200, Daniel Kiper wrote:
> > On Fri, Sep 03, 2021 at 09:21:39AM +0800, Michael Chang via Grub-devel
> > wrote:
> > > On Thu, Sep 02, 2021 at 02:12:52PM +0200, Daniel Kiper wrote:
>
Hey,
On Thu, Oct 21, 2021 at 08:46:06PM +0100, Chris Plant wrote:
> Hello,
>
> I'm continuing to play with Multiboot2 on ARM64 on a Raspberry Pi, and
> I've run into something which I'm trying to understand.
Why do you use Multiboot2 on ARM64?
> I have an ELF file for my kernel which has two
On Tue, Oct 26, 2021 at 03:11:00PM +0800, Michael Chang via Grub-devel wrote:
> The POSIX locale is default or native operating system's locale
> identical to the C locale, so no translation to human speaking languages
> provided.
>
> For this reason we should filter out LANG=POSIX as well as
On Mon, Oct 25, 2021 at 06:17:03PM -0400, Robbie Harwood wrote:
> Before performing the license check, resolve the module name so that it
> can be printed if the license check fails. Prior to this change, grub
> would only indicate that the check had been failed, but not by what
> module. This
The POSIX locale is default or native operating system's locale
identical to the C locale, so no translation to human speaking languages
provided.
For this reason we should filter out LANG=POSIX as well as LANG=C upon
generating grub.cfg to avoid looking up for it's gettext's message
catalogs
20 matches
Mail list logo
