Re: [PATCH] Revert "iee1275/datetime: Fix off-by-1 error."

2022-02-07 Thread Daniel Axtens
Hi, I tested a pseries guest under: - qemu + KVM on a Power8 host with a fairly modern qemu - qemu + TCG Here the 'date' command simply reports "error: no cmos found", so this patch will have no impact on those platforms. I also tested an LPAR on a Power8 PowerVM machine. In this case, before

Re: search by partition type guid supported?

2022-02-07 Thread Chris Murphy
On Sat, Jan 29, 2022 at 6:25 AM Maxim Fomin wrote: > > Hi, > > It seems that grub 'search' command does not work with gpt partition type > codes. However search for partition *type* uuid (unlike unique partition > uuid) can result in two or more devices in multiboot environment - this > leaves

How to boot Windows when Bitlocker enabled with key sealed in TPM

2022-02-07 Thread Chris Murphy
Hi, It's increasingly common to see Windows 10 systems with full disk encryption (BitLocker) enabled out of the box, with the encryption key sealed in the TPM 2.0. [1][2][3] The system uses Measured Boot to determine if boot related components have been tampered with, and if not, the BitLocker

Re: [PATCH v3 5/5] tests: Ensure that loopback devices and zfs devices are cleaned up

2022-02-07 Thread Glenn Washburn
On Mon, 7 Feb 2022 19:36:14 +0100 Daniel Kiper wrote: > On Sun, Feb 06, 2022 at 04:00:12PM -0600, Glenn Washburn wrote: > > ZFS file systems are not unmounted using umount, but instead by exporting > > them. So export the ZFS file system that has the same label as the one that > > was created

Re: [PATCH] search: new --efidisk-only option on EFI systems

2022-02-07 Thread Glenn Washburn
On Mon, 7 Feb 2022 12:12:14 +0100 Renaud Métrich wrote: > Please find inline the new patch integrating Glenn's comments (new > "flags" option instead of "no-floppy" / "efidisk-only"). Thanks for making this inline, but its still not in a great format for maintainers. Please use "git

Re: [PATCH v4 2/2] efi: Add API for retrieving the EFI secret for cryptodisk

2022-02-07 Thread James Bottomley
On Mon, 2022-02-07 at 17:00 +, Dr. David Alan Gilbert wrote: > * James Bottomley (j...@linux.ibm.com) wrote: [...] > > +static grub_err_t > > +grub_efi_secret_put (const char *arg __attribute__((unused)), int > > have_it, > > +grub_uint8_t **ptr) > > +{ > > + struct

Re: [PATCH v3 5/5] tests: Ensure that loopback devices and zfs devices are cleaned up

2022-02-07 Thread Daniel Kiper
On Sun, Feb 06, 2022 at 04:00:12PM -0600, Glenn Washburn wrote: > ZFS file systems are not unmounted using umount, but instead by exporting > them. So export the ZFS file system that has the same label as the one that > was created during the test, if such one exists. This is required to delete >

Re: [PATCH v4 2/2] efi: Add API for retrieving the EFI secret for cryptodisk

2022-02-07 Thread Dr. David Alan Gilbert
* James Bottomley (j...@linux.ibm.com) wrote: > This module is designed to provide an efisecret provider which > interrogates the EFI configuration table to find the location of the > confidential computing secret and tries to register the secret with > the cryptodisk. > > The secret is stored in

[PATCH v4 2/2] efi: Add API for retrieving the EFI secret for cryptodisk

2022-02-07 Thread James Bottomley
This module is designed to provide an efisecret provider which interrogates the EFI configuration table to find the location of the confidential computing secret and tries to register the secret with the cryptodisk. The secret is stored in a boot allocated area, usually a page in size. The layout

[PATCH v4 1/2] cryptodisk: add OS provided secret support

2022-02-07 Thread James Bottomley
Make use of the new OS provided secrets API so that if the new '-s' option is passed in we try to extract the secret from the API rather than prompting for it. The primary consumer of this is AMD SEV, which has been programmed to provide an injectable secret to the encrypted virtual machine.

[PATCH v4 0/2] use confidential computing provisioned secrets for disk decryption

2022-02-07 Thread James Bottomley
From: James Bottomley v4: Update to new password passing API and fold in review comments original patch 1 (which contained a password passing API) is removed and patch 2 is updated and patch 3 largely unchanged. v3: make password getter specify prompt requirement. Update for TDX:

Re: [PATCH 3/4] luks2: set up dummy sector size during scan

2022-02-07 Thread Josselin Poiret via Grub-devel
Hi Fabian, Fabian Vogt writes: > Did you have a look at my approach? That effectively does the same, but using > a > single ioctl instead of anything complex with DM directly. I agree that it's sufficient for sector_size, but we still need the cryptodisk algorithm so that grub-install will

Re: [PATCH] search: new --efidisk-only option on EFI systems

2022-02-07 Thread Renaud Métrich
Please find inline the new patch integrating Glenn's comments (new "flags" option instead of "no-floppy" / "efidisk-only"). When using 'search' on EFI systems, we sometimes want to exclude devices that are not EFI disks (e.g. md, lvm). This is typically used when wanting to chainload when

Re: [PATCH] search: new --efidisk-only option on EFI systems

2022-02-07 Thread Renaud Métrich
See inline, sorry for the format. Le 2/4/22 à 23:28, Glenn Washburn a écrit : On Tue, 1 Feb 2022 11:36:01 +0100 Renaud Métrich wrote: When using 'search' on EFI systems, we sometimes want to exclude devices that are not EFI disks (e.g. md, lvm). This is typically used when wanting to