Re: [PATCH] efidisk: pass buffers with higher alignment

2022-05-09 Thread Heinrich Schuchardt
On 5/9/22 21:45, Stefan Agner wrote: On 2022-05-09 21:19, Heinrich Schuchardt wrote: On 5/5/22 15:54, Stefan Agner wrote: Despite the UEFI specification saying "the requirement is that the start address of a buffer must be evenly divisible by IoAlign with no remainder.", it seems that a higher

Re: [PATCH v2 3/3] grub-core/kern/disk.c: handle LUKS2 devices

2022-05-09 Thread Josselin Poiret via Grub-devel
Hello everyone, Glenn Washburn writes: > I don't really like this, but it gets the job done and is a work-around > for a peculiarity of the LUKS2 backend. The cheat mount code for > cryptodisk does only calls scan() and not recover_key(). For LUKS1 scan > will return a grub_cryptodisk_t with

Re: [PATCH] efidisk: pass buffers with higher alignment

2022-05-09 Thread Stefan Agner
On 2022-05-09 21:19, Heinrich Schuchardt wrote: > On 5/5/22 15:54, Stefan Agner wrote: >> Despite the UEFI specification saying "the requirement is that the >> start address of a buffer must be evenly divisible by IoAlign with >> no remainder.", it seems that a higher alignment requirement is >>

Re: [PATCH] efidisk: pass buffers with higher alignment

2022-05-09 Thread Heinrich Schuchardt
On 5/5/22 15:54, Stefan Agner wrote: Despite the UEFI specification saying "the requirement is that the start address of a buffer must be evenly divisible by IoAlign with no remainder.", it seems that a higher alignment requirement is neecssary on some system (e.g. a Intel NUC system with NVMe

Re: [PATCH] efidisk: pass buffers with higher alignment

2022-05-09 Thread Stefan Agner
On 2022-05-05 17:42, Vladimir 'phcoder' Serbinenko wrote: > Le jeu. 5 mai 2022, 15:55, Stefan Agner a écrit : > >> Despite the UEFI specification saying "the requirement is that the >> start address of a buffer must be evenly divisible by IoAlign with >> no remainder.", it seems that a higher