Re: [PATCH v3] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-19 Thread Oskari Pirhonen
On Thu, May 19, 2022 at 04:52:54PM -0400, Mathieu Desnoyers wrote: > - On May 19, 2022, at 2:36 PM, Daniel Kiper dki...@net-space.pl wrote: > > Did you consider Oskari's comment sent in the other email? > > I just did, sorry for the delay, I missed his email because it was only > sent to the

Re: [PATCH v2 3/5] cryptodisk: Add options to cryptomount to support keyfiles

2022-05-19 Thread Glenn Washburn
On Thu, 19 May 2022 20:23:12 +0200 Daniel Kiper wrote: > On Fri, May 13, 2022 at 12:00:49PM -0500, Glenn Washburn wrote: > > From: John Lane > > > > Add the options --key-file, --keyfile-offset, and --keyfile-size to > > cryptomount and code to put read the requested key file data and pass > >

Re: Linux DRTM on UEFI platforms

2022-05-19 Thread Daniel P. Smith
Hey Ard, Apologies for the lag in response, I wanted to have this to you sooner, but between a variety of events and working on building consensus on how to address your comments made it drag out a little. Before reading this message, I would recommend reading the proposal posted to the top of

Re: Linux DRTM on UEFI platforms

2022-05-19 Thread Daniel P. Smith
Greetings, Based on the discussions that occurred in this thread, there seems to be two issues at hand that should be decoupled, as their solutions can and should be implemented independently. These are: - the handling of the Dynamic Launch preamble - providing the complete kernel configuration

Re: [PATCH v3] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-19 Thread Mathieu Desnoyers
- On May 19, 2022, at 2:36 PM, Daniel Kiper dki...@net-space.pl wrote: [...] > > Could you do the same in util/grub.d/20_linux_xen.in? Both should be > kept in sync. And you are not first one who updates 10_linux.in only. > If you could make a patch which adds something like "Keep logic in

Re: [PATCH v2 4/5] cryptodisk: Use enum constants as indexes into cryptomount option array

2022-05-19 Thread Glenn Washburn
On Thu, 19 May 2022 20:24:11 +0200 Daniel Kiper wrote: > On Fri, May 13, 2022 at 12:00:50PM -0500, Glenn Washburn wrote: > > Signed-off-by: Glenn Washburn > > --- > > grub-core/disk/cryptodisk.c | 53 ++--- > > 1 file changed, 32 insertions(+), 21 deletions(-) >

Re: [PATCH v3] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-19 Thread Mathieu Desnoyers
- On May 5, 2022, at 7:02 PM, Oskari Pirhonen xxc3ncore...@gmail.com wrote: > On Thu, May 05, 2022 at 10:24:56AM -0400, Mathieu Desnoyers wrote: [...] > > Instead of creating a separate function, would it be better to let > `version_sort()` accept an argument/set of arguments? > >> + >>

Re: [PATCH] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-19 Thread Mathieu Desnoyers
- On May 3, 2022, at 1:15 PM, Mihai Moldovan io...@ionic.de wrote: > Just a nit, feel free to ignore it... > > > * On 5/3/22 4:42 PM, Mathieu Desnoyers wrote: >> How does the following paragraph sound ? >> >> >> Here is the improved algorithm proposed: >> >> - Prepare a list with

Re: [PATCH 0/7] Various docs improvements

2022-05-19 Thread Daniel Kiper
On Wed, May 11, 2022 at 09:56:17PM -0500, Glenn Washburn wrote: > The first 4 patches need no explanation. The 5th patch creates a new section > just for loader commands and moves loader commands to that section from the > general commands section. Patch #6 adds an itemized list of currently >

Re: [PATCH v3] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-19 Thread Daniel Kiper
On Thu, May 05, 2022 at 10:24:56AM -0400, Mathieu Desnoyers wrote: > The current implementation of the 10_linux script implements its menu > items sorting in bash with a quadratic algorithm, calling "sed", "sort", > "head", and "grep" to compare versions between individual lines, which > is

Re: [PATCH v2 4/5] cryptodisk: Use enum constants as indexes into cryptomount option array

2022-05-19 Thread Daniel Kiper
On Fri, May 13, 2022 at 12:00:50PM -0500, Glenn Washburn wrote: > Signed-off-by: Glenn Washburn > --- > grub-core/disk/cryptodisk.c | 53 ++--- > 1 file changed, 32 insertions(+), 21 deletions(-) > > diff --git a/grub-core/disk/cryptodisk.c

Re: [PATCH v2 3/5] cryptodisk: Add options to cryptomount to support keyfiles

2022-05-19 Thread Daniel Kiper
On Fri, May 13, 2022 at 12:00:49PM -0500, Glenn Washburn wrote: > From: John Lane > > Add the options --key-file, --keyfile-offset, and --keyfile-size to > cryptomount and code to put read the requested key file data and pass > via the cargs struct. Note, key file data is for all intents and

Re: [PATCH v2 00/15] Dynamic allocation of memory regions and IBM vTPM v2

2022-05-19 Thread Daniel Kiper
On Wed, May 18, 2022 at 11:24:48AM -0400, Stefan Berger wrote: > On 4/14/22 11:30, Daniel Kiper wrote: > > On Thu, Apr 07, 2022 at 04:41:04PM +0200, Daniel Kiper wrote: > > > On Mon, Mar 28, 2022 at 05:22:25PM +1100, Daniel Axtens wrote: > > > > Hi all, > > > > > > > > This is, at long last, an

Re: [PATCH v3] efidisk: pass buffers with higher alignment

2022-05-19 Thread Stefan Agner
On 2022-05-18 10:59, Stefan Agner wrote: > Some devices report a IoAlign value of 2, however seem to require a > buffer with higher alignment. After releasing Home Assistant OS 8.0 publicly, some systems still refuse to boot even with this patch applied. See bug reports collected in this issue: