Re: [PATCH] cryptodisk: Support encrypted volumes using detached headers on a partition

Hi Daniel! No problem, I will do some more testing end of this week with different setups. Van: Daniel Kiper Aan: Glenn Washburn Onderwerp: Re: [PATCH] cryptodisk: Support encrypted volumes using detached headers on a partition Datum: 09/08/2022 15:17:59 Europe/Paris Cc:

Re: [PATCH 2/2] util: confirm directory creation in grub_install_mkdir_p

Hi Vladimir, I admit, that I did not previously. I just tried it out where one of the components in a deeper path was a symlink, and it works as I would expect. It will see it as a directory in grub_util_is_directory() using stat(), since that is looking at what is pointed to, in comparison to

Re: [PATCH 2/2] util: confirm directory creation in grub_install_mkdir_p

Did you test the case when some of components exist and are symlinks? E.g. /temp being a symlinkto /var/tmp Le mar. 9 août 2022, 15:30, Darren Kenny a écrit : > Because grub_util_mkdir() is implemented to not return a value on any > platform, grub_instal_mkdir_p can test for success by

Re: [PATCH] Makefile: Make grub_fstest.pp depend on config-util.h

On Thu, Aug 04, 2022 at 11:57:49AM +0200, Stefan Agner wrote: > If you build with "make -j25", sometimes you see: > /build/output_generic_x86_64/host/bin/x86_64-buildroot-linux-gnu-gcc -E > -DHAVE_CONFIG_H -I. -I.. -Wall -W -DGRUB_UTIL=1 -D_FILE_OFFSET_BITS=64 > -I./include

[PATCH 1/2] util: Ignore return value for grub_util_mkdir() on all platforms

Coverity signaled 2 issues where the return value of grub_util_mkdir() was not being tested. The Windows variant of this code defines the function as having no return value (void), but the UNIX variants all are mapped using a macro to the libc mkdir() function, which returns an int value. To be

[PATCH 0/2] util: Resolve issues with use of grub_util_mkdir

Coverity flagged some issues where grub_util_mkdir() was being called but the return value was not being checked. After examining the implementation, on UNIX and ACROS, grub_util_mkdir() is a macro that maps to libc's mkdir(), which returns an int. But on MS Windows, grub_util_mkdir() is a

[PATCH 2/2] util: confirm directory creation in grub_install_mkdir_p

Because grub_util_mkdir() is implemented to not return a value on any platform, grub_instal_mkdir_p can test for success by confirming that the directory requested exists after attempting to create it, otherwise it should fail with an error and exit. While fixing this, a flaw in the logic was

Re: [PATCH] grub-shell: Use shell variable instead of autoconf

On Sat, Aug 06, 2022 at 01:26:31AM -0500, Glenn Washburn wrote: > By using shell variable that are set once by the expansion of an autoconf > variable, the resulting shell script is more easily moved and modified > from the build/install directory it was generated for. The resulting > script is

Re: [PATCH] cryptodisk: Support encrypted volumes using detached headers on a partition

On Sun, Aug 07, 2022 at 12:18:52AM -0500, Glenn Washburn wrote: > Update the read hook to take into account encrypted volumes on a partition. > Grub disk read hooks supply an absolute sector number at which the read is > started from. If the encrypted volume is in a partition, the sector number >

Re: Linux DRTM on UEFI platforms

On 7/23/22 01:15, Brendan Trotter wrote: Hi, Greetings, On Sat, Jul 23, 2022 at 2:53 AM Daniel P. Smith wrote: On 7/7/22 23:36, Brendan Trotter wrote: On Thu, Jul 7, 2022 at 7:18 PM Daniel P. Smith wrote: On 7/5/22 20:03, Brendan Trotter wrote: On Wed, Jul 6, 2022 at 4:52 AM Daniel P.