Re: [PATCH v2 0/5] Fix coverity bugs and add checks for elf values in grub-core

2022-08-15 Thread Darren Kenny
Hi Alec, These changes look good to me, Reviewed-by: Darren Kenny Thanks, Darren. On Friday, 2022-08-12 at 18:25:44 -04, Alec Brown wrote: > Updates from v1: > - A few patches didn't work on 32-bit platforms. Fixed this by renaming > function definitions in multiboot_elfxx.c. The

Re: [PATCH v2 1/1] Add support for grub-emu to kexec Linux menu entries

2022-08-15 Thread Raymund Will
Hi, please let me try to add a bit of context and explain three IMHO crucial points of the proposed patch. First, it is meant to work without any changes to config-files on 'linux'-systems, simply by calling `grub-emu --kexec`. And, called this way, it actually uses `systemctl kexec` exclusively

Re: [PATCH] luks2: Continue trying all keyslots even if there are some failures

2022-08-15 Thread Patrick Steinhardt
On Fri, Jul 22, 2022 at 03:04:50AM -0500, Glenn Washburn wrote: > luks2_get_keyslot can fail for a variety of reasons that do not neccesarily > mean the next keyslot should not be tried (eg. a new kdf type). So always > try the next slot. This will make GRUB more resilient to non-spec json data > t

Re: [PATCH v5 2/2] cryptodisk: Allows UUIDs to be compared in a dash-insensitive manner

2022-08-15 Thread Patrick Steinhardt
On Thu, Aug 11, 2022 at 12:48:43PM -0500, Glenn Washburn wrote: > A user can now specify UUID strings with dashes, instead of having to remove > dashes. This is backwards-compatability preserving and also fixes a source > of user confusion over the inconsistency with how UUIDs are specified > betwe

Re: [PATCH v5 1/2] json: Add function to unescape JSON-encoded strings

2022-08-15 Thread Patrick Steinhardt
On Tue, Jul 12, 2022 at 03:39:13PM +0200, Daniel Kiper wrote: > On Mon, Jul 11, 2022 at 09:08:09AM -0400, Nicholas Vinson wrote: > > On 7/11/22 06:44, Patrick Steinhardt wrote: > > > JSON strings require certain characters to be encoded, either by using a > > > single reverse solidus character "\"

Re: [PATCH v9 03/10] LoongArch: Add setjmp implementation

2022-08-15 Thread 孙海勇
Hi I've tested this patch set on a physical machine, the OS environment is a CLFS system I made based on LoongArch and they work well. It would be great if this patch set could be merged into the master branch. That way, I can happily boot my system directly with the official code. 在

Re: [PATCH v9 03/10] LoongArch: Add setjmp implementation

2022-08-15 Thread 孙海勇
Hi I've tested this patch set on a physical machine, the OS environment is a CLFS system I made based on LoongArch and they work well. It would be great if this patch set could be merged into the master branch. That way, I can happily boot my system directly with the official code. > ---

[PATCH v6 0/2] luks2: Fix decoding of digests and salts with escaped chars

2022-08-15 Thread Patrick Steinhardt
Hi, this is the sixth version of my patch series which fixes decoding of digests and salts in LUKS2 headers in case they happen to contain escaped characters. While modern cryptsetup versions in fact don't escape any characters part of the Base64 alphabet, old versions of cryptsetup did this until

[PATCH v6 1/2] json: Add function to unescape JSON-encoded strings

2022-08-15 Thread Patrick Steinhardt
JSON strings require certain characters to be encoded, either by using a single reverse solidus character "\" for a set of popular characters, or by using a Unicode representation of "\uX". The jsmn library doesn't handle unescaping for us, so we must implement this functionality for ourselves.

[PATCH v6 2/2] luks2: Fix decoding of digests and salts with escaped chars

2022-08-15 Thread Patrick Steinhardt
It was reported in the #grub IRC channel on Libera that decryption of LUKS2 partitions fails with errors about invalid digests and/or salts. In all of these cases, what failed was decoding the Base64 representation of these, where the encoded data contained invalid characters. As it turns out, the

Re: [PATCH v6 0/2] luks2: Fix decoding of digests and salts with escaped chars

2022-08-15 Thread Glenn Washburn
On Mon, 15 Aug 2022 17:52:45 +0200 Patrick Steinhardt wrote: > Hi, > > this is the sixth version of my patch series which fixes decoding of > digests and salts in LUKS2 headers in case they happen to contain > escaped characters. While modern cryptsetup versions in fact don't > escape any charac

Re: [PATCH v5 2/2] cryptodisk: Allows UUIDs to be compared in a dash-insensitive manner

2022-08-15 Thread Glenn Washburn
On Mon, 15 Aug 2022 17:28:24 +0200 Patrick Steinhardt wrote: > On Thu, Aug 11, 2022 at 12:48:43PM -0500, Glenn Washburn wrote: > > A user can now specify UUID strings with dashes, instead of having to remove > > dashes. This is backwards-compatability preserving and also fixes a source > > of use