[PATCH] efi: Correct function prototype for register_key_notify method of grub_efi_simple_text_input_ex_interface

2022-08-24 Thread Glenn Washburn
From: Li Gen The register_key_notify() method should have an output parameter which is a pointer to the unique handle assigned to the registered notification. Signed-off-by: Li Gen Signed-off-by: Glenn Washburn --- include/grub/efi/api.h | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [PATCH 2/2] Ensure nvram is available and functional on IEEE1275

2022-08-24 Thread Michael Chang via Grub-devel
On Wed, Aug 24, 2022 at 06:03:11PM +0200, Ismael Luceno wrote: > Otherwise the installation will fail, and the system will be left in an > unbootable state. > > On ppc64le, the boot process shows: > > Welcome to GRUB! > > error: ../../grub-core/kern/dl.c:380:symbol

Re: [PATCH] term/serial: Add support for PCI serial devices

2022-08-24 Thread Glenn Washburn
On Wed, 24 Aug 2022 23:01:22 +0200 Peter Zijlstra wrote: > On Wed, Aug 24, 2022 at 03:13:55PM -0500, Glenn Washburn wrote: > > Hi Peter, > > > > Thanks for the submission. I'm adding Daniel, the maintainer, because > > otherwise he might not see it. Please TO or CC him on further > >

Re: [PATCH] term/serial: Add support for PCI serial devices

2022-08-24 Thread Peter Zijlstra
On Wed, Aug 24, 2022 at 03:13:55PM -0500, Glenn Washburn wrote: > Hi Peter, > > Thanks for the submission. I'm adding Daniel, the maintainer, because > otherwise he might not see it. Please TO or CC him on further > submissions. Sure thing; not too familiar with the grub community. > On Wed, 24

Re: [PATCH] term/serial: Add support for PCI serial devices

2022-08-24 Thread Glenn Washburn
Hi Peter, Thanks for the submission. I'm adding Daniel, the maintainer, because otherwise he might not see it. Please TO or CC him on further submissions. On Wed, 24 Aug 2022 13:28:03 +0200 Peter Zijlstra wrote: > > Loosely based on early_pci_serial_init() from Linux, allow GRUB to make > use

[PATCH v2 0/1] ofnet: Fix incorrect mask for ppc64

2022-08-24 Thread Robbie Harwood
Changes in this version: - Replaced changed swap_bytes32(le_to_cpu32()) with be_to_cpu32(). Please note that I'm not an expert on this platform and can only perform very basic testing there. However, this patch is functionally the same as one we've been carrying downstream since late 2016

[PATCH v2] net/drivers/ieee1275/ofnet: fix incorrect netmask

2022-08-24 Thread Robbie Harwood
From: Masahiro Matsuya The netmask configured in firmware is not respected on ppc64 (big endian). When 255.255.252.0 is set as netmask in firmware, the following is the value of bootpath string in grub_ieee1275_parse_bootpath():

[PATCH 1/2] Add helper to load linux kmods

2022-08-24 Thread Ismael Luceno
The function checks for already loaded (incl. built-in) modules first at /sys/module/, then tries to load it. Abort when unable to load efivarfs/efivars. Signed-off-by: Ismael Luceno --- grub-core/osdep/unix/platform.c | 24 1 file changed, 20 insertions(+), 4

[PATCH 2/2] Ensure nvram is available and functional on IEEE1275

2022-08-24 Thread Ismael Luceno
Otherwise the installation will fail, and the system will be left in an unbootable state. On ppc64le, the boot process shows: Welcome to GRUB! error: ../../grub-core/kern/dl.c:380:symbol `grub_disk_get_size' not found. Entering rescue mode... grub rescue>

[PATCH 0/2] Fix installation issues on ppc64le

2022-08-24 Thread Ismael Luceno
When the /dev/nvram device is unavailable, the installation fails and leaves the system in an unbootable state. The patches in this series introduce a handler for the boilerplate code and make sure nvram is available. Ismael Luceno (2): Add helper to load linux kmods Ensure nvram is

[PATCH] term/serial: Add support for PCI serial devices

2022-08-24 Thread Peter Zijlstra
Loosely based on early_pci_serial_init() from Linux, allow GRUB to make use of PCI serial devices. Specifically, my Alderlake NUC exposes the Intel AMT SoL UART as a PCI enumerated device but doesn't include it in the EFI tables. Tested and confirmed working on a "Lenovo P360 Tiny" with Intel

[PATCH] Initialize BSD relocator state variables

2022-08-24 Thread Ross Philipson
Numerous register fields in the relocator state are simply not used depending on the relocator. This causes Coverity to flag these fields but there is no real bug here. Simply initializing the variable to {0} solves the issue. Fixed in the else case too for consistency. Fixes: CID 396932

Re: [PATCH v3 1/1] Add support for grub-emu to kexec Linux menu entries

2022-08-24 Thread Robbie Harwood
Raymund Will writes: > Robbie Harwood wrote on 2022-08-23T17:15:42 -0400: >> From: Raymund Will > [...] >> By default the systemctl kexec option is used so systemd can shutdown >> all of the running services before doing a reboot using kexec. But if >> this is not present, it fallbacks to

[RESEND PATCH] templates: Set defaults using var substitution

2022-08-24 Thread Ismael Luceno
Signed-off-by: Ismael Luceno --- util/grub.d/10_linux.in | 6 ++ util/grub.d/20_linux_xen.in | 6 ++ 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/util/grub.d/10_linux.in b/util/grub.d/10_linux.in index c6a1ec935bfc..321e590da192 100644 --- a/util/grub.d/10_linux.in

Re: [PATCH v3 1/1] Add support for grub-emu to kexec Linux menu entries

2022-08-24 Thread Raymund Will
Robbie Harwood wrote on 2022-08-23T17:15:42 -0400: > From: Raymund Will [...] > By default the systemctl kexec option is used so systemd can shutdown all > of the running services before doing a reboot using kexec. But if this is > not present, it fallbacks to executing the kexec user-space tool

[PATCH v10 06/11] LoongArch: Add awareness for LoongArch relocations

2022-08-24 Thread Xiaotian Wu
Signed-off-by: Xiaotian Wu Signed-off-by: Zhou Yang --- grub-core/kern/dl.c| 9 +- grub-core/kern/loongarch64/dl.c| 102 + grub-core/kern/loongarch64/dl_helper.c | 202 + include/grub/dl.h | 1 +

[PATCH v10 08/11] LoongArch: Add to build system

2022-08-24 Thread Xiaotian Wu
Signed-off-by: Xiaotian Wu Signed-off-by: Zhou Yang --- Makefile.util.def | 1 + configure.ac| 22 - gentpl.py | 25 ++- grub-core/Makefile.am | 6 + grub-core/Makefile.core.def | 16

[PATCH v10 09/11] LoongArch: Support new relocation types

2022-08-24 Thread Xiaotian Wu
Signed-off-by: Xiaotian Wu --- conf/Makefile.common | 3 + configure.ac | 14 +++-- grub-core/kern/dl.c| 9 +-- grub-core/kern/loongarch64/dl.c| 71 - grub-core/kern/loongarch64/dl_helper.c | 68

[PATCH v10 10/11] LoongArch: add efistub kernel support

2022-08-24 Thread Xiaotian Wu
Signed-off-by: Xiaotian Wu Signed-off-by: Sun Haiyong --- gentpl.py| 2 +- grub-core/loader/loongarch64/linux.c | 329 ++- include/grub/loongarch64/linux.h | 18 +- 3 files changed, 338 insertions(+), 11 deletions(-) diff --git

[PATCH v10 11/11] tests: add support for LoongArch

2022-08-24 Thread Xiaotian Wu
Signed-off-by: Xiaotian Wu --- tests/ahci_test.in | 2 +- tests/ehci_test.in | 2 +- tests/ohci_test.in | 2 +- tests/pata_test.in | 2 +- tests/uhci_test.in | 2 +- tests/util/grub-shell.in | 14 ++ 6 files changed, 19 insertions(+), 5 deletions(-)

[PATCH v10 02/11] Add LoongArch definitions

2022-08-24 Thread Xiaotian Wu
Signed-off-by: Xiaotian Wu Signed-off-by: Zhou Yang --- include/grub/elf.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/include/grub/elf.h b/include/grub/elf.h index 0e70651d4..beef94512 100644 --- a/include/grub/elf.h +++ b/include/grub/elf.h @@ -252,6 +252,7 @@

[PATCH v10 05/11] LoongArch: Add stubs for Linux loading commands

2022-08-24 Thread Xiaotian Wu
Signed-off-by: Xiaotian Wu --- grub-core/loader/loongarch64/linux.c | 59 include/grub/loongarch64/linux.h | 31 +++ 2 files changed, 90 insertions(+) create mode 100644 grub-core/loader/loongarch64/linux.c create mode 100644

[PATCH v10 07/11] LoongArch: Add auxiliary files

2022-08-24 Thread Xiaotian Wu
Signed-off-by: Xiaotian Wu Signed-off-by: Zhou Yang --- grub-core/kern/efi/mm.c | 3 +- grub-core/kern/loongarch64/cache.c | 39 grub-core/kern/loongarch64/cache_flush.S | 33 ++ grub-core/kern/loongarch64/efi/init.c| 77

[PATCH v10 04/11] LoongArch: Add early startup code

2022-08-24 Thread Xiaotian Wu
Signed-off-by: Xiaotian Wu Signed-off-by: Zhou Yang --- grub-core/kern/loongarch64/efi/startup.S | 34 1 file changed, 34 insertions(+) create mode 100644 grub-core/kern/loongarch64/efi/startup.S diff --git a/grub-core/kern/loongarch64/efi/startup.S

[PATCH v10 01/11] PE: Add LoongArch definitions

2022-08-24 Thread Xiaotian Wu
Signed-off-by: Xiaotian Wu Signed-off-by: Zhou Yang --- include/grub/efi/pe32.h | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/include/grub/efi/pe32.h b/include/grub/efi/pe32.h index 0ed8781f0..de56edef6 100644 ---

Re: [PATCH] Remove HFS support

2022-08-24 Thread John Paul Adrian Glaubitz
On 8/20/22 15:53, Daniel Axtens wrote: Really, plain HFS, not HFS+? Wowsers! Yes, we're currently using HFS. Just to be clear, by PowerMacs you mean Macs with PowerPC chips, so machines last produced around 2006? Yes. Have you checked that you can't boot them with HFS+? Because HFS+ came

[PATCH v10 03/11] LoongArch: Add setjmp implementation

2022-08-24 Thread Xiaotian Wu
Signed-off-by: Xiaotian Wu Signed-off-by: Zhou Yang Signed-off-by: Sun Haiyong --- grub-core/lib/loongarch64/setjmp.S | 69 ++ grub-core/lib/setjmp.S | 2 + include/grub/loongarch64/setjmp.h | 27 3 files changed, 98 insertions(+) create

[PATCH v10 00/11] Add support for LoongArch

2022-08-24 Thread Xiaotian Wu
LoongArch is a new Loongson 3A5000 CPU instruction set, you can read documents[1] or visit the development community[2] to get more information. [1]: https://loongson.github.io/LoongArch-Documentation/README-EN.html [2]: https://github.com/loongson This patchset adds support for LoongArch to

Re: [PATCH] Remove HFS support

2022-08-24 Thread John Paul Adrian Glaubitz
Hi Vladimir! On 8/19/22 21:45, Vladimir 'phcoder' Serbinenko wrote: This kind of consideration was taken into account when designing security system and even when GRUB2 itself was designed. The solution is modules whitelist. There are many modules that can be dropped from signed build not

Re: [PATCH] Remove HFS support

2022-08-24 Thread John Paul Adrian Glaubitz
Hello! On 8/19/22 21:04, Dimitri John Ledkov wrote: There is no need for that code on any signed grubs or upstream. Ports that want to support this patch can have it conditionally compiled / enabled only on that arch, but not other. That's not how open source works. Individual projects do