Re: [PATCH v2 2/3] term/serial: Add support for PCI serial devices

2022-08-26 Thread Glenn Washburn
On Fri, 26 Aug 2022 13:01:44 +0200 pet...@infradead.org wrote: > Loosely based on early_pci_serial_init() from Linux, allow GRUB to make > use of PCI serial devices. > > Specifically, my Alderlake NUC exposes the Intel AMT SoL UART as a PCI > enumerated device but doesn't include it in the EFI ta

Re: [PATCH 1/2] efi/chainloader: Do not require a valid $root when chainloading

2022-08-26 Thread Glenn Washburn
On Fri, 26 Aug 2022 10:12:18 +0100 Dimitri John Ledkov wrote: > Hi, > > This is interesting. I had to work around this same issue in loopback > to allow chainloading from loopback devices see > https://github.com/rhboot/grub2/commit/0e5cb733f3cb227293ea58397ea10891519095f0 Hmm, now that I think

Re: [PATCH] Remove HFS support

2022-08-26 Thread Vladimir 'phcoder' Serbinenko
Le ven. 26 août 2022, 17:46, John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de> a écrit : > Hi Vladimir! > > On 8/19/22 21:01, Vladimir 'phcoder' Serbinenko wrote: > > But booting old machines is still desirable for GRUB. Is there a reason > why > > HFS is actively bad for modern machines?

Re: [PATCH] Remove HFS support

2022-08-26 Thread Vladimir 'phcoder' Serbinenko
Le ven. 26 août 2022, 15:47, Daniel Axtens a écrit : > Let me answer this out of order. > > > I understand the need to sometimes get rid of old code, but since the HFS > > module can be blacklisted as Vladimir explains, I don't really understand > > the reasoning in this particular case. > > I wa

Re: [PATCH] Remove HFS support

2022-08-26 Thread John Paul Adrian Glaubitz
Hi Vladimir! On 8/19/22 21:01, Vladimir 'phcoder' Serbinenko wrote: But booting old machines is still desirable for GRUB. Is there a reason why HFS is actively bad for modern machines? Especially if it's disabled in case of lockdown. Can I have more details about your security concerns? I may c

Re: [PATCH] Remove HFS support

2022-08-26 Thread John Paul Adrian Glaubitz
On 8/26/22 15:31, Daniel Axtens wrote: I want _all_ grub code to reach a minimum standard of not crashing or corrupting memory in the presence of malicious input. HFS does not reach that standard. I surely understand that although it sounds a little academic to me. Whether or not the HFS modu

Re: [PATCH] Remove HFS support

2022-08-26 Thread Daniel Axtens
Let me answer this out of order. > I understand the need to sometimes get rid of old code, but since the HFS > module can be blacklisted as Vladimir explains, I don't really understand > the reasoning in this particular case. I want _all_ grub code to reach a minimum standard of not crashing or c

[PATCH v2 1/3] configure: Add -DGRUB_HAS_PCI when compiling C/C++ files on targets that support PCI

2022-08-26 Thread peterz
From: Glenn Washburn The list of targets that support PCI is in gentpl.py. However, there is no support for generating makefile script from a .def file that will apply globally to the makefile, but on a per target basis. So instead, use gentpl.py in configure to get the list of targets and check

[PATCH v2 2/3] term/serial: Add support for PCI serial devices

2022-08-26 Thread peterz
Loosely based on early_pci_serial_init() from Linux, allow GRUB to make use of PCI serial devices. Specifically, my Alderlake NUC exposes the Intel AMT SoL UART as a PCI enumerated device but doesn't include it in the EFI tables. Tested and confirmed working on a "Lenovo P360 Tiny" with Intel AMT

[PATCH v2 0/3] term/serial: Add PCI-serial device support

2022-08-26 Thread peterz
Hi! A small collection of patches that adds PCI serial support. The first patch is by Glenn and adds GRUB_HAS_PCI -- it is included so that it is a complete posting. The second patch is the actual PCI serial support, and the last patch a cleanup requested by Glenn. Much thanks to Glenn for all

[PATCH v2 3/3] pci: Rename GRUB_PCI_CLASS_*

2022-08-26 Thread peterz
Glenn suggested to rename the existing PCI_CLASS defines to have explicit class and subclass names. Suggested-by: Glenn Washburn Signed-off-by: Peter Zijlstra (Intel) --- Index: grub/grub-core/kern/i386/qemu/init.c === --- grub.orig

Re: [PATCH 1/2] efi/chainloader: Do not require a valid $root when chainloading

2022-08-26 Thread Dimitri John Ledkov
Hi, This is interesting. I had to work around this same issue in loopback to allow chainloading from loopback devices see https://github.com/rhboot/grub2/commit/0e5cb733f3cb227293ea58397ea10891519095f0 On Fri, 26 Aug 2022 at 05:34, Glenn Washburn wrote: > > The EFI chainloader checks that a de