Re: [PATCH v2 0/5] loongarch: add relaxation support

2023-06-12 Thread WANG Xuerui
On 6/13/23 11:25, mengqinggang wrote: Is this  patch used to check if ld supports --no-relax option? It need to pass -mno-relax option to as or gcc to disable binutils generate relaxation relocations. It shouldn't be necessary to disable relaxation that early, because code before relaxation

[PATCH] kern/acpi: use xsdt_addr if present

2023-06-12 Thread Qiumiao Zhang via Grub-devel
According to the ACPI specification, in ACPI 2.0 or later, an ACPI-compatible OS must use the XSDT if present. So, we should use xsdt_addr instead of rsdt_addr if xsdt_addr is valid. Signed-off-by: Qiumiao Zhang --- grub-core/kern/acpi.c | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCH v2] commands/acpi: use xsdt_addr if present

2023-06-12 Thread Qiumiao Zhang via Grub-devel
According to the ACPI specification, in ACPI 2.0 or later, an ACPI-compatible OS must use the XSDT if present. So, we should use xsdt_addr instead of rsdt_addr if xsdt_addr is valid. Signed-off-by: Qiumiao Zhang --- Changes since v2: * update the commit message Qiumiao ---

Re: Re: [PATCH] acpi: use xsdt_addr if present

2023-06-12 Thread zhangqiumiao via Grub-devel
On Thu, Jun 08, 2023 at 07:09:36PM +0800, Qiumiao Zhang via Grub-devel wrote: >> According to the UEFI specification, in ACPI 2.0 or later, an >> ACPI-compatible OS must use the XSDT if present. > Sorry, I cannot find this in the UEFI spec. Though something more generic is > in the ACPI spec.

Re: [PATCH v2 0/5] loongarch: add relaxation support

2023-06-12 Thread Xiaotian Wu
New patch is ready: https://github.com/loongarch64/grub/commits/dev-master I need your help to confirm that binutils-2.40 and binutils-dev code have the same behavior when using compile options, thanks. 在 2023-06-12星期一的 06:35 +0800，Xi Ruoyao via Grub-devel写道： > On Wed, 2023-06-07 at 15:34 +0800,

Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers

2023-06-12 Thread Robin Candau
Le 12/06/2023 à 21:05, Daniel Kiper a écrit : On Mon, Jun 12, 2023 at 07:19:53PM +0200, Christian Hesse wrote: Ard Biesheuvel on Tue, 2023/05/23 17:31: Now that GCC can generate function calls using the correct calling convention for us, we can stop using the efi_call_XX () wrappers, and just

Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers

2023-06-12 Thread Daniel Kiper
On Mon, Jun 12, 2023 at 07:19:53PM +0200, Christian Hesse wrote: > Ard Biesheuvel on Tue, 2023/05/23 17:31: > > Now that GCC can generate function calls using the correct calling > > convention for us, we can stop using the efi_call_XX () wrappers, and > > just dereference the function pointers

Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers

2023-06-12 Thread Christian Hesse
Ard Biesheuvel on Tue, 2023/05/23 17:31: > Now that GCC can generate function calls using the correct calling > convention for us, we can stop using the efi_call_XX () wrappers, and > just dereference the function pointers directly. > > This avoids the untyped variadic wrapper routines, which

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-06-12 Thread Daniel Kiper
On Tue, Jun 06, 2023 at 12:48:39AM -0500, Glenn Washburn wrote: > Debugging GRUB can be tricky and require arcane knowledge. This will > help those unfamiliar with the process to get started debugging GRUB > with less effort. > > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Thank

Re: [PATCH] osdep/linux: Fix md array device enumeration

2023-06-12 Thread Daniel Kiper
On Wed, Jun 07, 2023 at 02:33:35PM -0700, Kees Cook wrote: > On Wed, Jun 07, 2023 at 03:39:24PM +0200, Daniel Kiper wrote: > > On Tue, Jun 06, 2023 at 11:02:31AM -0700, Kees Cook wrote: > > > On Tue, Jun 6, 2023 at 10:27 AM Julian Andres Klode > > > wrote: > > > > > > > > On Tue, Jun 06, 2023 at

Re: [PATCH v2 1/1] fs/udf: Fix out of bounds access

2023-06-12 Thread Daniel Kiper
On Wed, Jun 07, 2023 at 08:26:44PM +0100, Darren Kenny wrote: > Hi Li,, > > LGTM! > > Reviewed-by: Darren Kenny Reviewed-by: Daniel Kiper Thank you for fixing these issues! Daniel ___ Grub-devel mailing list Grub-devel@gnu.org

Re: [PATCH] acpi: use xsdt_addr if present

2023-06-12 Thread Daniel Kiper
On Thu, Jun 08, 2023 at 07:09:36PM +0800, Qiumiao Zhang via Grub-devel wrote: > According to the UEFI specification, in ACPI 2.0 or later, an ACPI-compatible > OS must use the XSDT if present. Sorry, I cannot find this in the UEFI spec. Though something more generic is in the ACPI spec. Could

Re: [PATCH v2 0/5] loongarch: add relaxation support

2023-06-12 Thread Daniel Kiper
On Mon, Jun 12, 2023 at 04:20:41PM +0800, Xi Ruoyao via Grub-devel wrote: > On Mon, 2023-06-12 at 14:54 +0800, WANG Xuerui wrote: > > On 6/12/23 11:09, Xiaotian Wu wrote: > > > 在 2023-06-12星期一的 06:35 +0800，Xi Ruoyao via Grub-devel写道： > > > > On Wed, 2023-06-07 at 15:34 +0800, Xiaotian Wu wrote: >

Re: [PATCH v2 0/5] loongarch: add relaxation support

2023-06-12 Thread Daniel Kiper
On Wed, Jun 07, 2023 at 03:34:52PM +0800, Xiaotian Wu wrote: > Because the binutils of the loongarch architecture adds relaxation support > [1], the next version of binutils will not be able to build grub. > > So we added the R_LARCH_B16, R_LARCH_B21 and R_LARCH_RELAX relocations to > enhance

Re: [PATCH v2 0/5] loongarch: add relaxation support

2023-06-12 Thread Xi Ruoyao via Grub-devel
On Mon, 2023-06-12 at 14:54 +0800, WANG Xuerui wrote: > On 6/12/23 11:09, Xiaotian Wu wrote: > > 在 2023-06-12星期一的 06:35 +0800，Xi Ruoyao via Grub-devel写道： > > > On Wed, 2023-06-07 at 15:34 +0800, Xiaotian Wu wrote: > > > > Because the binutils of the loongarch architecture adds relaxation > > > >

Re: [PATCH v2 0/5] loongarch: add relaxation support

2023-06-12 Thread WANG Xuerui
On 6/12/23 11:09, Xiaotian Wu wrote: 在 2023-06-12星期一的 06:35 +0800，Xi Ruoyao via Grub-devel写道： On Wed, 2023-06-07 at 15:34 +0800, Xiaotian Wu wrote: Because the binutils of the loongarch architecture adds relaxation support [1], the next version of binutils will not be able to build grub. So