Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-06-15 Thread Oskari Pirhonen
On Thu, Jun 15, 2023 at 13:06:09 +0200, Daniel Kiper wrote: > On Thu, Jun 15, 2023 at 01:21:57AM -0500, Oskari Pirhonen wrote: > > Oops, apologies for the late reply. Reading through it again, I found a > > few more small nits: > > Right now patch is in the git repo. If you want to improve that

[PATCH v2 0/1] tpm: Enable boot despite unknown firmware failure

2023-06-15 Thread Michał Grzelak
Hi all, This patch fixes small problem with my computer being unbootable under certain circumstances. It also addresses concerns pointed out by Daniel with previous version. If there are any, I would appreciate further comments. Best regards, Michał --- Changelog: v1->v2: - change

[PATCH v2 1/1] tpm: Enable boot despite unknown firmware failure

2023-06-15 Thread Michał Grzelak
Currently booting the system is prevented when call to EFI firmware hash_log_extend_event() returns unknown error. Solve this by following convention used in commit a4356538d (commands/tpm: Don't propagate measurement failures to the verifiers layer). Let the system to be bootable by default when

GRUB 2.02 and APFS filesystems causing boot-time issue

2023-06-15 Thread vincent
Hi all, I'm new to this list and I hope it's the right place to ask for help.. I'd like to better understand how to rebuild grubx64.efi from upstream source so I could give a try at fixing the issue I've come across: https://bugzilla.redhat.com/show_bug.cgi?id=1524685

Re: [PATCH] efi: Add missing __grub_efi_api attributes

2023-06-15 Thread Christian Hesse
Daniel Kiper on Thu, 2023/06/15 16:45: > The commit bb4aa6e06 (efi: Drop all uses of efi_call_XX() wrappers) did > not add some __grub_efi_api attributes to the EFI calls. Lack of them > led to hangs on x86_64-efi target. So, let's add missing __grub_efi_api > attributes. > > Fixes: bb4aa6e06

Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers

2023-06-15 Thread Christian Hesse
Daniel Kiper on Thu, 2023/06/15 17:05: > > It looks I was able to reproduce this problem. I will be checking what > > is going on in following days... > > Here [1] is the fix. Please test... Works for me, thanks! -- main(a){char*c=/*Schoene Gruesse */"B?IJj;MEH"

Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers

2023-06-15 Thread Daniel Kiper
On Wed, Jun 14, 2023 at 05:15:43PM +0200, Daniel Kiper wrote: > On Mon, Jun 12, 2023 at 10:53:09PM +0200, Robin Candau wrote: > > Le 12/06/2023 à 21:05, Daniel Kiper a écrit : > > > On Mon, Jun 12, 2023 at 07:19:53PM +0200, Christian Hesse wrote: > > > > Ard Biesheuvel on Tue, 2023/05/23 17:31: >

Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers

2023-06-15 Thread Thomas Frauendorfer
On Wed, Jun 14, 2023 at 5:17 PM Daniel Kiper wrote: > > On Mon, Jun 12, 2023 at 10:53:09PM +0200, Robin Candau wrote: > > Le 12/06/2023 à 21:05, Daniel Kiper a écrit : > > > On Mon, Jun 12, 2023 at 07:19:53PM +0200, Christian Hesse wrote: > > > > Ard Biesheuvel on Tue, 2023/05/23 17:31: > > > >

[PATCH] bootstrap: Fix patching warnings

2023-06-15 Thread Daniel Kiper
Currently bootstrap complains in the following way when patching gnulib files: patching file argp-help.c Hunk #1 succeeded at 52 (offset 1 line). Hunk #2 succeeded at 1548 (offset 115 lines). patching file mbswidth.c patching file mbswidth.h Hunk #1 succeeded at 40 (offset -5 lines).

[PATCH] efi: Add missing __grub_efi_api attributes

2023-06-15 Thread Daniel Kiper
The commit bb4aa6e06 (efi: Drop all uses of efi_call_XX() wrappers) did not add some __grub_efi_api attributes to the EFI calls. Lack of them led to hangs on x86_64-efi target. So, let's add missing __grub_efi_api attributes. Fixes: bb4aa6e06 (efi: Drop all uses of efi_call_XX() wrappers)

[PATCH v5 0/1] loongarch: Disable relaxation for grub

2023-06-15 Thread Xiaotian Wu
v4->v5: - update commit message v3->v4: - rebase on the latest master branch - check "-mno-relax" and "-Wa,-mno-relax" v2->v3: - Use the -mno-relax cflags for gcc v1->v2: - split patch - drop cast code Xiaotian Wu (1): loongarch: disable relaxation relocations configure.ac | 23

[PATCH v5 1/1] loongarch: disable relaxation relocations

2023-06-15 Thread Xiaotian Wu
A working grub cannot be built with upcoming binutils and gcc, because linker relaxation was added [1] causing new unsupported relocations to appear in modules. So we pass -mno-relax to gcc if it is supported, to disable relaxation and make grub forward-compatible with new toolchains. While

Re: [PATCH] tpm: Enable boot despite unknown firmware failure

2023-06-15 Thread Daniel Kiper
On Wed, Jun 14, 2023 at 04:59:29PM +0200, Michał Grzelak wrote: > Currently booting the system is prevented when call to EFI firmware > hash_log_extend_event() returns unknown error. Solve this by following > convention used in commit a4356538d (commands/tpm: Don't propagate > measurement failures

Re: [PATCH] Generalize MD_MAX_DISKS to GRUB_MDRAID_MAX_DISKS

2023-06-15 Thread Daniel Kiper
On Tue, Jun 13, 2023 at 12:33:36PM -0700, Kees Cook wrote: > On Tue, Jun 13, 2023 at 02:54:48PM +0200, Julian Andres Klode wrote: > > Move the constant from getroot.c to disk.h and then reuse > > it place of the hardcoded 1024 limit in diskfilter. > > > > Fixes: 2a5e3c1f2 (disk/diskfilter: Don't

Re: [PATCH v3 5/5] loongarch: Use the -mno-relax cflags for gcc

2023-06-15 Thread Daniel Kiper
On Thu, Jun 15, 2023 at 10:04:23AM +0800, Xiaotian Wu wrote: > 在 2023-06-13星期二的 20:09 +0800,Xi Ruoyao via Grub-devel写道: > > On Tue, 2023-06-13 at 13:39 +0200, Daniel Kiper wrote: > > > On Tue, Jun 13, 2023 at 05:06:35PM +0800, Xiaotian Wu wrote: > > > > Because the binutils of the loongarch

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-06-15 Thread Daniel Kiper
On Thu, Jun 15, 2023 at 01:21:57AM -0500, Oskari Pirhonen wrote: > Oops, apologies for the late reply. Reading through it again, I found a > few more small nits: Right now patch is in the git repo. If you want to improve that part of doc please send a fix to grub-devel and CC interested folks.

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-06-15 Thread Oskari Pirhonen
Oops, apologies for the late reply. Reading through it again, I found a few more small nits: On Tue, Jun 06, 2023 at 00:48:39 -0500, Glenn Washburn wrote: > Debugging GRUB can be tricky and require arcane knowledge. This will > help those unfamiliar with the process to get started debugging GRUB