Re: [PATCH] docs: Minor edits to debugging chapter

On Thu, Jun 22, 2023 at 11:07:40 -0500, Glenn Washburn wrote: > On Sun, 18 Jun 2023 22:56:31 -0500 > Oskari Pirhonen wrote: > > > Small set of wording and grammatical edits which did not make it in time > > for the original review of the chapter. > > > > Signed-off-by: Oskari Pirhonen > > --- >

Re: [PATCH] lib/relocator: Enforce GRUB_RELOCATOR_FIRMWARE_REQUESTS_QUANT divisibility by 8

Reviewed-by: Vladimir Serbinenko Le ven. 23 juin 2023, 00:08, Daniel Kiper a écrit : > Most of leftover code blindly assumes > GRUB_RELOCATOR_FIRMWARE_REQUESTS_QUANT > divisibility by 8. So, enforce this at compile time. > > Signed-off-by: Daniel Kiper > --- > grub-core/lib/relocator.c | 2 ++

Re: [PATCH] lib/relocator: Fix OOB write when initializing lo->freebytes[]

Reviewedby: Vladimir Serbinenko Le ven. 23 juin 2023, 00:09, Daniel Kiper a écrit : > Fixes: CID 96636 > > Signed-off-by: Daniel Kiper > --- > grub-core/lib/relocator.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/grub-core/lib/relocator.c b/grub-core/lib/r

[PATCH] lib/relocator: Enforce GRUB_RELOCATOR_FIRMWARE_REQUESTS_QUANT divisibility by 8

Most of leftover code blindly assumes GRUB_RELOCATOR_FIRMWARE_REQUESTS_QUANT divisibility by 8. So, enforce this at compile time. Signed-off-by: Daniel Kiper --- grub-core/lib/relocator.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/grub-core/lib/relocator.c b/grub-core/lib/relocator.c

[PATCH] lib/relocator: Fix OOB write when initializing lo->freebytes[]

Fixes: CID 96636 Signed-off-by: Daniel Kiper --- grub-core/lib/relocator.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/grub-core/lib/relocator.c b/grub-core/lib/relocator.c index 568fc0b8f..e0478ae5b 100644 --- a/grub-core/lib/relocator.c +++ b/grub-core/lib/reloc

Re: [PATCH] bootstrap: Fix patching warnings

On Thu, Jun 22, 2023 at 01:15:05PM -0400, Alec Brown wrote: > On Thu, Jun 15, 2023 at 04:47:09PM +0200, Daniel Kiper wrote: > > Currently bootstrap complains in the following way when > > patching gnulib files: > > > > patching file argp-help.c > > Hunk #1 succeeded at 52 (offset 1 line). > >

Re: [PATCH] bootstrap: Fix patching warnings

On Thu, Jun 15, 2023 at 04:47:09PM +0200, Daniel Kiper wrote: > Currently bootstrap complains in the following way when > patching gnulib files: > > patching file argp-help.c > Hunk #1 succeeded at 52 (offset 1 line). > Hunk #2 succeeded at 1548 (offset 115 lines). > patching file mbswidth

Re: [PATCH] docs: Minor edits to debugging chapter

On Sun, 18 Jun 2023 22:56:31 -0500 Oskari Pirhonen wrote: > Small set of wording and grammatical edits which did not make it in time > for the original review of the chapter. > > Signed-off-by: Oskari Pirhonen > --- > docs/grub-dev.texi | 39 +++ > 1 file ch

Re: Bad shim signature on kernel loading with patchset from 25.05.2023 and up

Hi tackled it down to this commit: https://git.savannah.gnu.org/cgit/grub.git/commit/?id=6a080b9cde0be5d08b71daf17a806067e32fc13f starting with this commit shim verification fails for kernel hash with bad shim verification and makes Secure Boot impossible. Hope you find a quick solution for fixing

Re: Bad shim signature on kernel loading with patchset from 25.05.2023 and up

Hi, further debugged it, it appears to be the patchset from Ard to cause this bad shim verification breakage. greetings tpowa -- Tobias Powalowski Arch Linux Developer & Package Maintainer (tpowa) https://www.archlinux.org tp...@archlinux.org Archboot Developer https://

Bad shim signature on kernel loading with patchset from 25.05.2023 and up

Hi, just curious since the patchset from 25.05.2023, I cannot use Secure Boot on my project anymore. The kernel hash cannot be validated anymore and shim bails out with bad shim signature. Any help would be appreciated. greetings tpowa -- Tobias Powalowski Arch Linux Developer & Package Maintaine

Re: [PATCH v2 2/2] grub-emu: Add SDL2 support

On Wed, Jun 21, 2023 at 03:49:20PM +0200, Gerd Hoffmann wrote: > On Wed, Jun 21, 2023 at 03:14:17PM +0200, Julian Andres Klode wrote: > > So all we did with the surface in SDL1 was split into window, > > surface, renderer, and texture. Instead of drawing into the > > surface and then flipping, you

Re: [PATCH v2 0/2] grub-emu: Add SDL2 support

On Wed, Jun 21, 2023 at 03:14:13PM +0200, Julian Andres Klode wrote: > This is version 2 of the patch series, addressing the > review from v1a. > > It's split in two batches to first change the sdl code > to match the coding style and then introduce the sdl2 > support in the correct style, to avoid

Bad shim signature on kernel loading with patchset from 25.05.2023 and up

Hi , I tackled it down to this commit: https://git.savannah.gnu.org/cgit/grub.git/commit/?id=6a080b9cde0be5d08b71daf17a806067e32fc13f starting with this commit shim verification fails for kernel hash with bad shim verification and makes Secure Boot impossible. Hope you find a quick solution for fi