A question about --removable

2023-09-01 Thread Oskari Pirhonen
Hi, Recently me and a few others were helping someone in #gentoo on libera.chat with their Gentoo install. Things were going smoothly up until rebooting into the fresh installation. Instead of getting GRUB, it kept booting straight into the UEFI menu. After scratching our heads a bit, we tried `gr

[PATCH] util/grub-install-common: Print usable grub-mkimage command

2023-09-01 Thread Glenn Washburn
When grub-install is run with the verbose option, it will print a log message indicating the grub-mkimage command and arguments used. GRUB no longer calls the grub-mkimage binary internally, however the command logged is a command that if run should effectively be what grub-install used. However, a

[PATCH] misc: Set grub_errno on all failures in grub_xvasprintf()

2023-09-01 Thread Glenn Washburn
When failing to allocate the preallocate buffer, grub_xvasprintf() returns NULL, but does not set grub_errno. Returning NULL is sufficient for a caller to determine there was an error. However, some usages of grub_xvasprintf() check for a NULL return value and then return grub_errno, which could re